tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ShellPkg: Refine code by initializing local variable and adding ASSERT statement. 

Add ASSERT statement and initialize local variable to make code more readable.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18689 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Qiu Shumin 2015-10-28 01:14:34 +00:00 committed by shenshushi
parent ae658d9163
commit c617380446
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ShellPkg/Application/Shell/ShellProtocol.c
View File

@ -1633,6 +1633,8 @@ EfiShellExecute(
UINTN Size; UINTN Size;
EFI_STATUS CalleeStatusCode; EFI_STATUS CalleeStatusCode;
CalleeStatusCode = EFI_SUCCESS;
if ((PcdGet8(PcdShellSupportLevel) < 1)) { if ((PcdGet8(PcdShellSupportLevel) < 1)) {
return (EFI_UNSUPPORTED); return (EFI_UNSUPPORTED);
} }

1
ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
View File

@ -341,6 +341,7 @@ ShellCommandRunTftp (
} }
RemoteFilePath = ShellCommandLineGetRawValue (CheckPackage, 2); RemoteFilePath = ShellCommandLineGetRawValue (CheckPackage, 2);
ASSERT(RemoteFilePath != NULL);
AsciiRemoteFilePath = AllocatePool ( AsciiRemoteFilePath = AllocatePool (
(StrLen (RemoteFilePath) + 1) * sizeof (CHAR8) (StrLen (RemoteFilePath) + 1) * sizeof (CHAR8)
); );