From c91fb6b4fc8b484e13ba180fa12c6736908d8017 Mon Sep 17 00:00:00 2001 From: Yonghong Zhu Date: Wed, 13 Jun 2018 09:12:28 +0800 Subject: [PATCH] BaseTools: remove the unneeded code Do a clean up to remove the unneeded code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu Reviewed-by: Liming Gao --- .../Source/Python/Workspace/MetaFileParser.py | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/BaseTools/Source/Python/Workspace/MetaFileParser.py b/BaseTools/Source/Python/Workspace/MetaFileParser.py index a2ded0c845..71da731e32 100644 --- a/BaseTools/Source/Python/Workspace/MetaFileParser.py +++ b/BaseTools/Source/Python/Workspace/MetaFileParser.py @@ -1551,23 +1551,6 @@ class DscParser(MetaFileParser): self.IncludedFiles.add (IncludedFile1) - # todo: rework the nested include checking logic - # Current nested include checking rely on dsc file order inside build.db. - # It is not reliable and will lead to build fail in some case. - # - # When project A and B include a common dsc file C. - # Build project A. It give dsc file A = ID 1 in build.db, and C ID = 2. - # Build project B. It give dsc file B ID = 3, and C ID still = 2. - # Then, we build project B fail, unless we clean build.db. - # In oldder BaseTools, the project B ID will still be 1, - # that's why it work before. - - # Does not allow lower level included file to include upper level included file - #if Parser._From != Owner and int(Owner) > int (Parser._From): - # EdkLogger.error('parser', FILE_ALREADY_EXIST, File=self._FileWithError, - # Line=self._LineIndex + 1, ExtraData="{0} is already included at a higher level.".format(IncludedFile1)) - - # set the parser status with current status Parser._SectionName = self._SectionName if self._InSubsection: