tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SecurityPkg: Optimization by moving PeiServicesLocatePpi outside loop 

This update refactors the code by moving the LocatePpi function call
outside of the for loop where it was previously called repeatedly.
By relocating the LocatePpi invocation outside of the loop,
we improve the efficiency of the code by avoiding redundant lookups.

Signed-off-by: Ashraf Ali <ashraf.ali.s@intel.com>
This commit is contained in:
Ashraf Ali 2024-08-14 23:16:29 +05:30 committed by mergify[bot]
parent a859f4fc03
commit cb9bdf3753
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
SecurityPkg/FvReportPei/FvReportPei.c
View File

@ -150,6 +150,16 @@ VerifyHashedFv (
HashValue = AllocateZeroPool (AlgInfo->HashSize * (FvNumber + 1));
ASSERT (HashValue != NULL);
Status = PeiServicesLocatePpi (
&gEdkiiPeiFirmwareVolumeShadowPpiGuid,
0,
NULL,
(VOID **)&FvShadowPpi
);
if (EFI_ERROR (Status)) {
FvShadowPpi = NULL;
}
//
// Calculate hash value for each FV first.
//
@ -194,14 +204,8 @@ VerifyHashedFv (
FvBuffer = AllocatePages (EFI_SIZE_TO_PAGES ((UINTN)FvInfo[FvIndex].Length));
ASSERT (FvBuffer != NULL);
Status = PeiServicesLocatePpi (
&gEdkiiPeiFirmwareVolumeShadowPpiGuid,
0,
NULL,
(VOID **)&FvShadowPpi
);
if (!EFI_ERROR (Status)) {
if (FvShadowPpi != NULL) {
Status = FvShadowPpi->FirmwareVolumeShadow (
(EFI_PHYSICAL_ADDRESS)FvInfo[FvIndex].Base,
FvBuffer,
@ -209,7 +213,7 @@ VerifyHashedFv (
);
}
if (EFI_ERROR (Status)) {
if ((FvShadowPpi == NULL) || (EFI_ERROR (Status))) {
CopyMem (
FvBuffer,
(CONST VOID *)(UINTN)FvInfo[FvIndex].Base,