tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-10-30 18:53:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

IntelFrameworkModulePkg GenericBdsLib: Resolve array size mismatch

Browse Source 
Match the size of array GaugeString defined in function
WriteBootToOsPerformanceData() with the size of field 'Token' defined in
struct PERF_DATA in MdeModulePkg\Include\Guid\Performance.h.

Doing so will ensure the size consistency when doing StrCpyS() between
PERF_DATA.Token and GaugeString (like here in Performance.c).

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17851 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Hao Wu 2015-07-07 06:13:53 +00:00 committed by hwu1225
parent dd4e2bcfaa
commit cce50970ce
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
IntelFrameworkModulePkg/Library/GenericBdsLib/Performance.c
View File

@ -40,7 +40,7 @@ GetShortPdbFileName (
UINTN EndIndex; UINTN EndIndex;
if (PdbFileName == NULL) { if (PdbFileName == NULL) {
AsciiStrCpyS (GaugeString, PERF_TOKEN_LENGTH, " "); AsciiStrCpyS (GaugeString, PERF_TOKEN_SIZE, " ");
} else { } else {
StartIndex = 0; StartIndex = 0;
for (EndIndex = 0; PdbFileName[EndIndex] != 0; EndIndex++) for (EndIndex = 0; PdbFileName[EndIndex] != 0; EndIndex++)
@ -60,7 +60,7 @@ GetShortPdbFileName (
for (Index = StartIndex; Index < EndIndex; Index++) { for (Index = StartIndex; Index < EndIndex; Index++) {
GaugeString[Index1] = PdbFileName[Index]; GaugeString[Index1] = PdbFileName[Index];
Index1++; Index1++;
if (Index1 == PERF_TOKEN_LENGTH - 1) { if (Index1 == PERF_TOKEN_LENGTH) {
break; break;
} }
} }
@ -91,7 +91,7 @@ GetNameFromHandle (
CHAR8 *PdbFileName; CHAR8 *PdbFileName;
EFI_DRIVER_BINDING_PROTOCOL *DriverBinding; EFI_DRIVER_BINDING_PROTOCOL *DriverBinding;
AsciiStrCpyS (GaugeString, PERF_TOKEN_LENGTH, " "); AsciiStrCpyS (GaugeString, PERF_TOKEN_SIZE, " ");
// //
// Get handle name from image protocol // Get handle name from image protocol
@ -153,7 +153,7 @@ WriteBootToOsPerformanceData (
UINT32 LimitCount; UINT32 LimitCount;
EFI_HANDLE *Handles; EFI_HANDLE *Handles;
UINTN NoHandles; UINTN NoHandles;
CHAR8 GaugeString[PERF_TOKEN_LENGTH]; CHAR8 GaugeString[PERF_TOKEN_SIZE];
UINT8 *Ptr; UINT8 *Ptr;
UINT32 Index; UINT32 Index;
UINT64 Ticker; UINT64 Ticker;