tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RedfishDiscoverDxe: refine InitInformationData() function 

Cache size of ASCII string in local variable.

Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
This commit is contained in:
Mike Maslenkin 2023-12-14 03:18:57 +03:00 committed by mergify[bot]
parent 17870bf3f5
commit d1c21f8d55
1 changed files with 21 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
View File

@ -738,39 +738,47 @@ InitInformationData (
IN CONST CHAR8 *ProductVer OPTIONAL IN CONST CHAR8 *ProductVer OPTIONAL
) )
{ {
UINTN AllocationSize;
if (RedfishVersion != NULL) { if (RedfishVersion != NULL) {
Information->RedfishVersion = *RedfishVersion; Information->RedfishVersion = *RedfishVersion;
DEBUG ((DEBUG_MANAGEABILITY, "Redfish service version: %d.\n", Information->RedfishVersion)); DEBUG ((DEBUG_MANAGEABILITY, "Redfish service version: %d.\n", Information->RedfishVersion));
} }
if (RedfishLocation != NULL) { if (RedfishLocation != NULL) {
Information->Location = AllocatePool (AsciiStrSize (RedfishLocation) * sizeof (CHAR16)); AllocationSize = AsciiStrSize (RedfishLocation) * sizeof (CHAR16);
AsciiStrToUnicodeStrS (RedfishLocation, Information->Location, AsciiStrSize (RedfishLocation) * sizeof (CHAR16)); Information->Location = AllocatePool (AllocationSize);
AsciiStrToUnicodeStrS (RedfishLocation, Information->Location, AllocationSize);
DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", Information->Location)); DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", Information->Location));
} }
if (Uuid != NULL) { if (Uuid != NULL) {
Information->Uuid = AllocatePool (AsciiStrSize (Uuid) * sizeof (CHAR16)); AllocationSize = AsciiStrSize (Uuid) * sizeof (CHAR16);
AsciiStrToUnicodeStrS (Uuid, Information->Uuid, AsciiStrSize (Uuid) * sizeof (CHAR16)); Information->Uuid = AllocatePool (AllocationSize);
AsciiStrToUnicodeStrS (Uuid, Information->Uuid, AllocationSize);
DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", Information->Uuid)); DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", Information->Uuid));
} }
if (Os != NULL) { if (Os != NULL) {
Information->Os = AllocatePool (AsciiStrSize (Os) * sizeof (CHAR16)); AllocationSize = AsciiStrSize (Os) * sizeof (CHAR16);
AsciiStrToUnicodeStrS (Os, Information->Os, AsciiStrSize (Os) * sizeof (CHAR16)); Information->Os = AllocatePool (AllocationSize);
DEBUG ((DEBUG_MANAGEABILITY, "Redfish service OS: %s, Version:%s.\n", Information->Os, Information->OsVersion)); AsciiStrToUnicodeStrS (Os, Information->Os, AllocationSize);
} }
if (OsVer != NULL) { if (OsVer != NULL) {
Information->OsVersion = AllocatePool (AsciiStrSize (OsVer) * sizeof (CHAR16)); AllocationSize = AsciiStrSize (OsVer) * sizeof (CHAR16);
AsciiStrToUnicodeStrS (OsVer, Information->OsVersion, AsciiStrSize (OsVer) * sizeof (CHAR16)); Information->OsVersion = AllocatePool (AllocationSize);
AsciiStrToUnicodeStrS (OsVer, Information->OsVersion, AllocationSize);
DEBUG ((DEBUG_MANAGEABILITY, "Redfish service OS: %s, Version:%s.\n", Information->Os, Information->OsVersion));
} }
if ((Product != NULL) && (ProductVer != NULL)) { if ((Product != NULL) && (ProductVer != NULL)) {
Information->Product = AllocatePool (AsciiStrSize (Product) * sizeof (CHAR16)); AllocationSize = AsciiStrSize (Product) * sizeof (CHAR16);
AsciiStrToUnicodeStrS (Product, Information->Product, AsciiStrSize (Product) * sizeof (CHAR16)); Information->Product = AllocatePool (AllocationSize);
Information->ProductVer = AllocatePool (AsciiStrSize (ProductVer) * sizeof (CHAR16)); AsciiStrToUnicodeStrS (Product, Information->Product, AllocationSize);
AsciiStrToUnicodeStrS (ProductVer, Information->ProductVer, AsciiStrSize (ProductVer) * sizeof (CHAR16)); AllocationSize = AsciiStrSize (ProductVer) * sizeof (CHAR16);
Information->ProductVer = AllocatePool (AllocationSize);
AsciiStrToUnicodeStrS (ProductVer, Information->ProductVer, AllocationSize);
DEBUG ((DEBUG_MANAGEABILITY, "Redfish service product: %s, Version:%s.\n", Information->Product, Information->ProductVer)); DEBUG ((DEBUG_MANAGEABILITY, "Redfish service product: %s, Version:%s.\n", Information->Product, Information->ProductVer));
} }
} }