tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MdePkg: MmControl: Fix function and structure definition mismatches 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3397

Current Ppi/MmControl.h file has structure definition of "struct
_PEI_MM_CONTROL_PPI". This name mismatches with its definition in PI
Specification v1.7 (Errata) as "struct _EFI_PEI_MM_CONTROL_PPI".

In addition, field types "PEI_MM_ACTIVATE" and "PEI_MM_DEACTIVATE" used
in "struct _PEI_MM_CONTROL_PPI" mismatches with the definition of
"EFI_PEI_MM_ACTIVATE" and "EFI_PEI_MM_DEACTIVATE" in the PI spec.

This change fixes these mismatches by using the PI spec defined names.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>

Fixes: 6f33f7a262
Signed-off-by: Kun Qin <kuqin12@gmail.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
This commit is contained in:
Kun Qin 2021-05-27 16:17:23 +08:00 committed by mergify[bot]
parent fe5da0927a
commit d3ff5dbe1d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
MdePkg/Include/Ppi/MmControl.h
View File

@ -69,7 +69,7 @@ EFI_STATUS
**/ **/
typedef typedef
EFI_STATUS EFI_STATUS
(EFIAPI *PEI_MM_DEACTIVATE) ( (EFIAPI *EFI_PEI_MM_DEACTIVATE) (
IN EFI_PEI_SERVICES **PeiServices, IN EFI_PEI_SERVICES **PeiServices,
IN EFI_PEI_MM_CONTROL_PPI * This, IN EFI_PEI_MM_CONTROL_PPI * This,
IN BOOLEAN Periodic OPTIONAL IN BOOLEAN Periodic OPTIONAL
@ -80,9 +80,9 @@ EFI_STATUS
/// platform hardware that generates an MMI. There are often I/O ports that, when accessed, will /// platform hardware that generates an MMI. There are often I/O ports that, when accessed, will
/// generate the MMI. Also, the hardware optionally supports the periodic generation of these signals. /// generate the MMI. Also, the hardware optionally supports the periodic generation of these signals.
/// ///
struct _PEI_MM_CONTROL_PPI { struct _EFI_PEI_MM_CONTROL_PPI {
PEI_MM_ACTIVATE Trigger; EFI_PEI_MM_ACTIVATE Trigger;
PEI_MM_DEACTIVATE Clear; EFI_PEI_MM_DEACTIVATE Clear;
}; };
extern EFI_GUID gEfiPeiMmControlPpiGuid; extern EFI_GUID gEfiPeiMmControlPpiGuid;