tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SecurityPkg FmpAuthenticationLibRsa2048Sha256: Remove PCD reference 

PcdRsa2048Sha256PublicKeyBuffer is referenced but not used in the
library, that makes me a little confusing.
Actually, the PublicKeyData should be from the caller of
AuthenticateFmpImage() as input parameter, for example
EdkiiSystemCapsuleLib.

This patch is to remove the PCD reference in this library instance
to be aligned with FmpAuthenticationLibPkcs7 that does not reference
PcdPkcs7CertBuffer.

Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
This commit is contained in:
Star Zeng 2018-04-16 16:39:28 +08:00
parent 0f3cd8a92b
commit d4ccf26491
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.c
View File

@ -10,7 +10,7 @@
FmpAuthenticatedHandlerRsa2048Sha256(), AuthenticateFmpImage() will receive FmpAuthenticatedHandlerRsa2048Sha256(), AuthenticateFmpImage() will receive
untrusted input and do basic validation. untrusted input and do basic validation.
Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR> Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at which accompanies this distribution. The full text of the license may be found at
@ -133,7 +133,7 @@ FmpAuthenticatedHandlerRsa2048Sha256 (
} }
// //
// Fail if the PublicKey is not one of the public keys in PcdRsa2048Sha256PublicKeyBuffer // Fail if the PublicKey is not one of the public keys in the input PublicKeyData.
// //
PublicKey = (VOID *)PublicKeyData; PublicKey = (VOID *)PublicKeyData;
PublicKeyBufferSize = PublicKeyDataLength; PublicKeyBufferSize = PublicKeyDataLength;

5
SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
View File

@ -3,7 +3,7 @@
# #
# Instance of FmpAuthentication Library for DXE/PEI post memory phase. # Instance of FmpAuthentication Library for DXE/PEI post memory phase.
# #
# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR> # Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials # This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License # are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at # which accompanies this distribution. The full text of the license may be found at
@ -45,9 +45,6 @@
MemoryAllocationLib MemoryAllocationLib
BaseCryptLib BaseCryptLib
[Pcd]
gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer ## CONSUMES
[Guids] [Guids]
gEfiCertTypeRsa2048Sha256Guid ## SOMETIMES_CONSUMES ## GUID # Unique ID for the type of the certificate. gEfiCertTypeRsa2048Sha256Guid ## SOMETIMES_CONSUMES ## GUID # Unique ID for the type of the certificate.
gEfiHashAlgorithmSha256Guid ## SOMETIMES_CONSUMES ## GUID gEfiHashAlgorithmSha256Guid ## SOMETIMES_CONSUMES ## GUID