Refine all R9 call back function to return EFI_UNSUPPORTED for all unsupported call back type.

Signed-off-by:  ydong10
Reviewed-by: lgao4


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11681 6f19259b-4bc3-4df7-8a09-765794883524

IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/BootMaint.c

@@ -296,14 +296,9 @@ BootMaintCallback (
   UINT8             *NewLegacyDev;
   UINT8             *DisMap;
   EFI_FORM_ID       FormId;
+  Status = EFI_SUCCESS;
 
-  if ((Action == EFI_BROWSER_ACTION_FORM_OPEN) || (Action == EFI_BROWSER_ACTION_FORM_CLOSE)) {
+  if (Action == EFI_BROWSER_ACTION_CHANGING) {
-    //
-    // Do nothing for UEFI OPEN/CLOSE Action
-    //
-    return EFI_SUCCESS;
-  }
-
     if ((Value == NULL) || (ActionRequest == NULL)) {
       return EFI_INVALID_PARAMETER;
     }
@@ -636,8 +631,13 @@ BootMaintCallback (
     // Pass changed uncommitted data back to Form Browser
     //
     Status = HiiSetBrowserData (&mBootMaintGuid, mBootMaintStorageName, sizeof (BMM_FAKE_NV_DATA), (UINT8 *) CurrentFakeNVMap, NULL);
-
     return Status;
+  }
+
+  //
+  // All other action return unsupported.
+  //
+  return EFI_UNSUPPORTED;
 }
 
 /**

IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/FileExplorer.c

@@ -1,7 +1,7 @@
 /** @file
   File explorer related functions.
 
-Copyright (c) 2004 - 2010, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2004 - 2011, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
@@ -249,13 +249,7 @@ FileExplorerCallback (
   FILE_EXPLORER_NV_DATA *NvRamMap;
   EFI_STATUS            Status;
 
-  if ((Action == EFI_BROWSER_ACTION_FORM_OPEN) || (Action == EFI_BROWSER_ACTION_FORM_CLOSE)) {
+  if (Action == EFI_BROWSER_ACTION_CHANGING) {
-    //
-    // Do nothing for UEFI OPEN/CLOSE Action
-    //
-    return EFI_SUCCESS;
-  }
-
     if ((Value == NULL) || (ActionRequest == NULL)) {
       return EFI_INVALID_PARAMETER;
     }
@@ -318,4 +312,9 @@ FileExplorerCallback (
     }
 
     return Status;
+  }
+  //
+  // All other action return unsupported.
+  //
+  return EFI_UNSUPPORTED;
 }

IntelFrameworkModulePkg/Universal/BdsDxe/BootMngr/BootManager.c

@@ -99,13 +99,7 @@ BootManagerCallback (
   LIST_ENTRY              *Link;
   UINT16                  KeyCount;
 
-  if ((Action == EFI_BROWSER_ACTION_FORM_OPEN) || (Action == EFI_BROWSER_ACTION_FORM_CLOSE)) {
+  if (Action == EFI_BROWSER_ACTION_CHANGING) {
-    //
-    // Do nothing for UEFI OPEN/CLOSE Action
-    //
-    return EFI_SUCCESS;
-  }
-
     if ((Value == NULL) || (ActionRequest == NULL)) {
       return EFI_INVALID_PARAMETER;
     }
@@ -140,6 +134,12 @@ BootManagerCallback (
     }
 
     return EFI_SUCCESS;
+  }
+
+  //
+  // All other action return unsupported.
+  //
+  return EFI_UNSUPPORTED;
 }
 
 /**

IntelFrameworkModulePkg/Universal/BdsDxe/DeviceMngr/DeviceManager.c

@@ -142,19 +142,12 @@ DeviceManagerCallback (
 {
   UINTN CurIndex;
 
-  if ((Action == EFI_BROWSER_ACTION_FORM_OPEN) || (Action == EFI_BROWSER_ACTION_FORM_CLOSE)) {
+  if (Action == EFI_BROWSER_ACTION_CHANGING) {
-    //
-    // Do nothing for UEFI OPEN/CLOSE Action
-    //
-    return EFI_SUCCESS;
-  }
-
     if ((Value == NULL) || (ActionRequest == NULL)) {
       return EFI_INVALID_PARAMETER;
     }
 
     gCallbackKey = QuestionId;
-
     if ((QuestionId < MAX_KEY_SECTION_LEN + NETWORK_DEVICE_LIST_KEY_OFFSET) && (QuestionId >= NETWORK_DEVICE_LIST_KEY_OFFSET)) {
       //
       // If user select the mac address, need to record mac address string to support next form show.
@@ -172,6 +165,12 @@ DeviceManagerCallback (
     *ActionRequest = EFI_BROWSER_ACTION_REQUEST_EXIT;
 
     return EFI_SUCCESS;
+  }
+
+  //
+  // All other action return unsupported.
+  //
+  return EFI_UNSUPPORTED;
 }
 
 /**
@@ -1109,13 +1108,7 @@ DriverHealthCallback (
   OUT EFI_BROWSER_ACTION_REQUEST             *ActionRequest
   )
 {
-  if ((Action == EFI_BROWSER_ACTION_FORM_OPEN) || (Action == EFI_BROWSER_ACTION_FORM_CLOSE)) {
+  if (Action == EFI_BROWSER_ACTION_CHANGING) {
-    //
-    // Do nothing for UEFI OPEN/CLOSE Action
-    //
-    return EFI_SUCCESS;
-  }
-
     if ((Value == NULL) || (ActionRequest == NULL)) {
       return EFI_INVALID_PARAMETER;
     }
@@ -1128,6 +1121,12 @@ DriverHealthCallback (
     *ActionRequest = EFI_BROWSER_ACTION_REQUEST_EXIT;
 
     return EFI_SUCCESS;
+  }
+
+  //
+  // All other action return unsupported.
+  //
+  return EFI_UNSUPPORTED;
 }
 
 /**

IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c

@@ -174,13 +174,7 @@ FrontPageCallback (
   CHAR8                         *PlatformSupportedLanguages;
   CHAR8                         *BestLanguage;
 
-  if ((Action == EFI_BROWSER_ACTION_FORM_OPEN) || (Action == EFI_BROWSER_ACTION_FORM_CLOSE)) {
+  if (Action == EFI_BROWSER_ACTION_CHANGING) {
-    //
-    // Do nothing for UEFI OPEN/CLOSE Action
-    //
-    return EFI_SUCCESS;
-  }
-
     if ((Value == NULL) || (ActionRequest == NULL)) {
       return EFI_INVALID_PARAMETER;
     }
@@ -286,6 +280,12 @@ FrontPageCallback (
     *ActionRequest = EFI_BROWSER_ACTION_REQUEST_EXIT;
 
     return EFI_SUCCESS;
+  }
+
+  //
+  // All other action return unsupported.
+  //
+  return EFI_UNSUPPORTED;
 }
 
 /**