OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for PEI fw_cfg instance

In the PEI fw_cfg instance:

- QemuFwCfgS3Enabled() queries S3 enablement via fw_cfg. This behavior is
  shared with the DXE fw_cfg instance, and the PEI fw_cfg instance already
  pulls in the function from "QemuFwCfgS3PeiDxe.c".

- If QemuFwCfgS3Enabled() returns TRUE, the client module is permitted to
  call QemuFwCfgS3CallWhenBootScriptReady(). However, in the PEI phase we
  have no support for capturing ACPI S3 Boot Script opcodes, hence we
  return RETURN_UNSUPPORTED unconditionally. This behavior is unique to
  the PEI fw_cfg instance, so add the function to "QemuFwCfgS3Pei.c".

- Consequently, the QemuFwCfgS3ScriptWriteBytes(),
  QemuFwCfgS3ScriptReadBytes(), QemuFwCfgS3ScriptSkipBytes(), and
  QemuFwCfgS3ScriptCheckValue() functions must never be called. (They
  could only be called from the client module's callback, but
  QemuFwCfgS3CallWhenBootScriptReady() will never install such callback in
  the PEI fw_cfg instance -- see above.)

  This behavior is not unique to the PEI fw_cfg instance (it is shared
  with the Base Null instance), so pull in these functions from
  "QemuFwCfgS3BasePei.c".

Cc: Jordan Justen <jordan.l.justen@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=394
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
This commit is contained in:
Laszlo Ersek 2017-02-22 10:34:48 +01:00
parent 33ead2dd14
commit da58d987cc
2 changed files with 89 additions and 0 deletions

View File

@ -31,6 +31,8 @@
#
[Sources]
QemuFwCfgS3BasePei.c
QemuFwCfgS3Pei.c
QemuFwCfgS3PeiDxe.c
[Packages]
@ -38,4 +40,5 @@
OvmfPkg/OvmfPkg.dec
[LibraryClasses]
DebugLib
QemuFwCfgLib

View File

@ -0,0 +1,86 @@
/** @file
Limited functionality QemuFwCfgS3Lib instance, for PEI phase modules.
QemuFwCfgS3Enabled() queries S3 enablement via fw_cfg. Other library APIs
will report lack of support.
Copyright (C) 2017, Red Hat, Inc.
This program and the accompanying materials are licensed and made available
under the terms and conditions of the BSD License which accompanies this
distribution. The full text of the license may be found at
http://opensource.org/licenses/bsd-license.php
THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, WITHOUT
WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
**/
#include <Library/QemuFwCfgS3Lib.h>
/**
Install the client module's FW_CFG_BOOT_SCRIPT_CALLBACK_FUNCTION callback for
when the production of ACPI S3 Boot Script opcodes becomes possible.
Take ownership of the client-provided Context, and pass it to the callback
function, when the latter is invoked.
Allocate scratch space for those ACPI S3 Boot Script opcodes to work upon
that the client will produce in the callback function.
@param[in] Callback FW_CFG_BOOT_SCRIPT_CALLBACK_FUNCTION to invoke
when the production of ACPI S3 Boot Script
opcodes becomes possible. Callback() may be
called immediately from
QemuFwCfgS3CallWhenBootScriptReady().
@param[in,out] Context Client-provided data structure for the
Callback() callback function to consume.
If Context points to dynamically allocated
memory, then Callback() must release it.
If Context points to dynamically allocated
memory, and
QemuFwCfgS3CallWhenBootScriptReady() returns
successfully, then the caller of
QemuFwCfgS3CallWhenBootScriptReady() must
neither dereference nor even evaluate Context
any longer, as ownership of the referenced area
has been transferred to Callback().
@param[in] ScratchBufferSize The size of the scratch buffer that will hold,
in reserved memory, all client data read,
written, and checked by the ACPI S3 Boot Script
opcodes produced by Callback().
@retval RETURN_UNSUPPORTED The library instance does not support this
function.
@retval RETURN_NOT_FOUND The fw_cfg DMA interface to QEMU is
unavailable.
@retval RETURN_BAD_BUFFER_SIZE ScratchBufferSize is too large.
@retval RETURN_OUT_OF_RESOURCES Memory allocation failed.
@retval RETURN_SUCCESS Callback() has been installed, and the
ownership of Context has been transferred.
Reserved memory has been allocated for the
scratch buffer.
A successful invocation of
QemuFwCfgS3CallWhenBootScriptReady() cannot
be rolled back.
@return Error codes from underlying functions.
**/
EFIAPI
RETURN_STATUS
QemuFwCfgS3CallWhenBootScriptReady (
IN FW_CFG_BOOT_SCRIPT_CALLBACK_FUNCTION *Callback,
IN OUT VOID *Context, OPTIONAL
IN UINTN ScratchBufferSize
)
{
return RETURN_UNSUPPORTED;
}