tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-21 12:44:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

RedfishPkg/RedfishPlatformConfigDxe: check attribute max. and min. value

Browse Source 
- For integer attribute, check and see if its value is between maximum
and minimum value defined by HII question.
- For string attribute, check and see if its string length is between
maximum string length and minimum string length defined by HII question.

Signed-off-by: Nickle Wang <nicklew@nvidia.com>
This commit is contained in:
Nickle Wang 2024-11-20 14:39:02 +08:00 committed by mergify[bot]
parent a7cc0014d2
commit dca265a8ca
1 changed files with 35 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
View File

@ -1764,6 +1764,7 @@ RedfishPlatformConfigSetStatementCommon (
UINTN Index; UINTN Index;
UINT64 Value; UINT64 Value;
CHAR8 **CharArray; CHAR8 **CharArray;
UINTN StrLength;
if ((RedfishPlatformConfigPrivate == NULL) || IS_EMPTY_STRING (Schema) || IS_EMPTY_STRING (ConfigureLang) || (StatementValue == NULL)) { if ((RedfishPlatformConfigPrivate == NULL) || IS_EMPTY_STRING (Schema) || IS_EMPTY_STRING (ConfigureLang) || (StatementValue == NULL)) {
return EFI_INVALID_PARAMETER; return EFI_INVALID_PARAMETER;
@ -1771,6 +1772,7 @@ RedfishPlatformConfigSetStatementCommon (
TempBuffer = NULL; TempBuffer = NULL;
StringArray = NULL; StringArray = NULL;
StrLength = 0;
Status = ProcessPendingList (&RedfishPlatformConfigPrivate->FormsetList, &RedfishPlatformConfigPrivate->PendingList); Status = ProcessPendingList (&RedfishPlatformConfigPrivate->FormsetList, &RedfishPlatformConfigPrivate->PendingList);
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
@ -1840,12 +1842,27 @@ RedfishPlatformConfigSetStatementCommon (
StatementValue->Buffer = StringArray; StatementValue->Buffer = StringArray;
StatementValue->BufferLen = TargetStatement->HiiStatement->StorageWidth; StatementValue->BufferLen = TargetStatement->HiiStatement->StorageWidth;
StatementValue->BufferValueType = TargetStatement->HiiStatement->Value.BufferValueType; StatementValue->BufferValueType = TargetStatement->HiiStatement->Value.BufferValueType;
} else if ((TargetStatement->HiiStatement->Operand == EFI_IFR_NUMERIC_OP) && (StatementValue->Type == EFI_IFR_TYPE_NUM_SIZE_64)) { } else if (TargetStatement->HiiStatement->Operand == EFI_IFR_NUMERIC_OP) {
if (StatementValue->Type == EFI_IFR_TYPE_NUM_SIZE_64) {
//
// Redfish only has numeric value type and it does not care about the value size.
// Do a patch here so we have proper value size applied.
//
StatementValue->Type = TargetStatement->HiiStatement->Value.Type;
}
// //
// Redfish only has numeric value type and it does not care about the value size. // Check maximum and minimum values when they are set.
// Do a patch here so we have proper value size applied.
// //
StatementValue->Type = TargetStatement->HiiStatement->Value.Type; if ((TargetStatement->StatementData.NumMaximum > 0) && (TargetStatement->StatementData.NumMaximum >= TargetStatement->StatementData.NumMinimum)) {
if (StatementValue->Value.u64 > TargetStatement->StatementData.NumMaximum) {
DEBUG ((DEBUG_ERROR, "%a: integer value: %lu is greater than maximum value: %lu\n", __func__, StatementValue->Value.u64, TargetStatement->StatementData.NumMaximum));
return EFI_ACCESS_DENIED;
} else if (StatementValue->Value.u64 < TargetStatement->StatementData.NumMinimum) {
DEBUG ((DEBUG_ERROR, "%a: integer value: %lu is smaller than minimum value: %lu\n", __func__, StatementValue->Value.u64, TargetStatement->StatementData.NumMinimum));
return EFI_ACCESS_DENIED;
}
}
} else { } else {
DEBUG ((DEBUG_ERROR, "%a: catch value type mismatch! input type: 0x%x but target value type: 0x%x\n", __func__, StatementValue->Type, TargetStatement->HiiStatement->Value.Type)); DEBUG ((DEBUG_ERROR, "%a: catch value type mismatch! input type: 0x%x but target value type: 0x%x\n", __func__, StatementValue->Type, TargetStatement->HiiStatement->Value.Type));
ASSERT (FALSE); ASSERT (FALSE);
@ -1853,6 +1870,20 @@ RedfishPlatformConfigSetStatementCommon (
} }
if ((TargetStatement->HiiStatement->Operand == EFI_IFR_STRING_OP) && (StatementValue->Type == EFI_IFR_TYPE_STRING)) { if ((TargetStatement->HiiStatement->Operand == EFI_IFR_STRING_OP) && (StatementValue->Type == EFI_IFR_TYPE_STRING)) {
//
// Check string length when length limitation is set.
//
if ((TargetStatement->StatementData.StrMaxSize > 0) && (TargetStatement->StatementData.StrMaxSize >= TargetStatement->StatementData.StrMinSize)) {
StrLength = StrLen ((EFI_STRING)StatementValue->Buffer);
if (StrLength > TargetStatement->StatementData.StrMaxSize) {
DEBUG ((DEBUG_ERROR, "%a: string length: %u is greater than maximum string length: %u\n", __func__, StrLength, TargetStatement->StatementData.StrMaxSize));
return EFI_ACCESS_DENIED;
} else if (StrLength < TargetStatement->StatementData.StrMinSize) {
DEBUG ((DEBUG_ERROR, "%a: string length: %u is smaller than minimum string length: %u\n", __func__, StrLength, TargetStatement->StatementData.StrMinSize));
return EFI_ACCESS_DENIED;
}
}
// //
// Create string ID for new string. // Create string ID for new string.
// //