tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FspInitPei function calling parameters not matching with the function definition. 

IntelFspWrapperPkg, In the file FspInitPeiV1.c and FspInitPeiV2.c, there are function calling:
GetStackInfo (BootMode, FALSE, &StackBase, &StackSize);

But the function GetStackInfo() defined as EFI_STATUS EFIAPI GetStackInfo (
  IN  UINT32               BootMode,
  IN  BOOLEAN              FspInitDone,
  OUT UINT64               *StackSize,
  OUT EFI_PHYSICAL_ADDRESS *StackBase
  )

It should be GetStackInfo (BootMode, FALSE, &StackSize, &StackBase); 

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: "Yao, Jiewen" <Jiewen.yao@intel.com>
Reviewed-by: "Ma, Maurice" <maurice.ma@intel.com>
Reviewed-by: "Rangarajan, Ravi P" <ravi.p.rangarajan@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17850 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Yao, Jiewen 2015-07-07 05:47:08 +00:00 committed by jyao1
parent ebf735f119
commit dd4e2bcfaa
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
IntelFspWrapperPkg/FspInitPei/FspInitPeiV1.c
View File

@ -47,7 +47,7 @@ ContinuationFunc (
//
BootMode = GetBootMode ();
GetStackInfo (BootMode, TRUE, &StackBase, &StackSize);
GetStackInfo (BootMode, TRUE, &StackSize, &StackBase);
DEBUG ((DEBUG_INFO, "StackBase - 0x%x\n", StackBase));
DEBUG ((DEBUG_INFO, "StackSize - 0x%x\n", StackSize));
CallPeiCoreEntryPoint (
@ -81,7 +81,7 @@ PeiFspInit (
PeiServicesGetBootMode (&BootMode);
DEBUG ((DEBUG_INFO, "BootMode - 0x%x\n", BootMode));
GetStackInfo (BootMode, FALSE, &StackBase, &StackSize);
GetStackInfo (BootMode, FALSE, &StackSize, &StackBase);
DEBUG ((DEBUG_INFO, "StackBase - 0x%x\n", StackBase));
DEBUG ((DEBUG_INFO, "StackSize - 0x%x\n", StackSize));

2
IntelFspWrapperPkg/FspInitPei/FspInitPeiV2.c
View File

@ -148,7 +148,7 @@ PeiFspMemoryInit (
PeiServicesGetBootMode (&BootMode);
DEBUG ((DEBUG_INFO, "BootMode - 0x%x\n", BootMode));
GetStackInfo (BootMode, FALSE, &StackBase, &StackSize);
GetStackInfo (BootMode, FALSE, &StackSize, &StackBase);
DEBUG ((DEBUG_INFO, "StackBase - 0x%x\n", StackBase));
DEBUG ((DEBUG_INFO, "StackSize - 0x%x\n", StackSize));