From ddb8cedce7e07b87c0ac6b84cd750a6d3dac47c8 Mon Sep 17 00:00:00 2001 From: "Rebecca Cran via Groups.Io" Date: Fri, 5 Apr 2019 01:56:16 +0800 Subject: [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output Fix a few typos in LegacyBiosBuildE820, and improve the debug output of the E820 table to pad with zeros instead of spaces, remove extra hyphens and display the memory type in decimal. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Rebecca Cran Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Liming Gao --- .../Csm/LegacyBiosDxe/LegacyBootSupport.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBootSupport.c b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBootSupport.c index 8e54bf7e71..211750c012 100644 --- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBootSupport.c +++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBootSupport.c @@ -1704,9 +1704,9 @@ LegacyBiosBuildE820 ( do { // - // Use size returned back plus 1 descriptor for the AllocatePool. + // Use size returned for the AllocatePool. // We don't just multiply by 2 since the "for" loop below terminates on - // EfiMemoryMapEnd which is dependent upon EfiMemoryMapSize. Otherwize + // EfiMemoryMapEnd which is dependent upon EfiMemoryMapSize. Otherwise // we process bogus entries and create bogus E820 entries. // EfiMemoryMap = (EFI_MEMORY_DESCRIPTOR *) AllocatePool (EfiMemoryMapSize); @@ -1794,7 +1794,7 @@ LegacyBiosBuildE820 ( MemoryBlockLength = (UINT64) (LShiftU64 (EfiEntry->NumberOfPages, 12)); if ((EfiEntry->PhysicalStart + MemoryBlockLength) < 0x100000) { // - // Skip the memory block is under 1MB + // Skip the memory block if under 1MB // } else { if (EfiEntry->PhysicalStart < 0x100000) { @@ -1919,7 +1919,7 @@ LegacyBiosBuildE820 ( *Size = (UINTN) (Index * sizeof (EFI_E820_ENTRY64)); // - // Determine OS usable memory above 1Mb + // Determine OS usable memory above 1MB // Private->IntThunk->EfiToLegacy16BootTable.OsMemoryAbove1Mb = 0x0000; for (TempIndex = Above1MIndex; TempIndex < Index; TempIndex++) { @@ -1941,7 +1941,7 @@ LegacyBiosBuildE820 ( // Print DEBUG information // for (TempIndex = 0; TempIndex < Index; TempIndex++) { - DEBUG((EFI_D_INFO, "E820[%2d]: 0x%16lx ---- 0x%16lx, Type = 0x%x \n", + DEBUG((EFI_D_INFO, "E820[%2d]: 0x%016lx - 0x%016lx, Type = %d\n", TempIndex, E820Table[TempIndex].BaseAddr, (E820Table[TempIndex].BaseAddr + E820Table[TempIndex].Length),