tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

RedfishPkg/RedfishDiscoverDxe: Fix memory free issue 

Check the memory block pointer before freeing it.

Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Signed-off-by: Abner Chang <abner.chang@amd.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
This commit is contained in:
Abner Chang 2022-10-28 18:16:55 +08:00 committed by mergify[bot]
parent 66772bc852
commit df7ce74e6c
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
View File

@ -261,6 +261,7 @@ Tcp6GetSubnetInfo (
Tcp6 = (EFI_TCP6_PROTOCOL *)Instance->NetworkInterfaceProtocolInfo.NetworkProtocolInterface; Tcp6 = (EFI_TCP6_PROTOCOL *)Instance->NetworkInterfaceProtocolInfo.NetworkProtocolInterface;
ZeroMem ((VOID *)&IpModedata, sizeof (EFI_IP6_MODE_DATA));
Status = Tcp6->GetModeData (Tcp6, NULL, NULL, &IpModedata, NULL, NULL); Status = Tcp6->GetModeData (Tcp6, NULL, NULL, &IpModedata, NULL, NULL);
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", __FUNCTION__)); DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", __FUNCTION__));
@ -282,12 +283,15 @@ Tcp6GetSubnetInfo (
} }
Instance->SubnetAddrInfoIPv6Number = IpModedata.AddressCount; Instance->SubnetAddrInfoIPv6Number = IpModedata.AddressCount;
CopyMem ( if ((IpModedata.AddressCount != 0) && (IpModedata.AddressList != NULL)) {
(VOID *)Instance->SubnetAddrInfoIPv6, CopyMem (
(VOID *)&IpModedata.AddressList, (VOID *)Instance->SubnetAddrInfoIPv6,
IpModedata.AddressCount * sizeof (EFI_IP6_ADDRESS_INFO) (VOID *)&IpModedata.AddressList,
); IpModedata.AddressCount * sizeof (EFI_IP6_ADDRESS_INFO)
FreePool (IpModedata.AddressList); );
FreePool (IpModedata.AddressList);
}
return EFI_SUCCESS; return EFI_SUCCESS;
} }