tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ShellPkg: acpiview: RSDP: Make code consistent with other parsers 

List ParseAcpi() function arguments one per line in order to make this
function call consistent with ParseAcpi() calls in other ACPI table
parsers.

Also, notify the user that XsdtAddress value of 0 results in RSDP
parsing being terminated and that the XSDT table will not be processed.

This effectively means that no more ACPI tables will be parsed because
of this RSDP table content error.

Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
This commit is contained in:
Krzysztof Koch 2019-07-22 15:50:23 -07:00 committed by Jaben Carsey
parent eefa8f8bf2
commit e0cf5ac693
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c
View File

@ -129,7 +129,14 @@ ParseAcpiRsdp (
VerifyChecksum (TRUE, Ptr, AcpiTableLength);
}
ParseAcpi (Trace, 0, "RSDP", Ptr, AcpiTableLength, PARSER_PARAMS (RsdpParser));
ParseAcpi (
Trace,
0,
"RSDP",
Ptr,
AcpiTableLength,
PARSER_PARAMS (RsdpParser)
);
// This code currently supports parsing of XSDT table only
// and does not parse the RSDT table. Platforms provide the
@ -137,7 +144,7 @@ ParseAcpiRsdp (
// Therefore the RSDT should not be used on ARM platforms.
if ((*XsdtAddress) == 0) {
IncrementErrorCount ();
Print (L"ERROR: XSDT Pointer is not set.\n");
Print (L"ERROR: XSDT Pointer is not set. RSDP parsing aborted.\n");
return;
}