MdePkg/BaseSynchronizationLib GCC: fix X64 InternalSyncCompareExchange64()

(This patch is identical to the X64 half of the last one, except for the
InternalSyncCompareExchange32() -> InternalSyncCompareExchange64() and
"cmpxchgl" -> "cmpxchgq" replacements.)

The CMPXCHG instruction has the following operands:
- AX (implicit, CompareValue):    input and output
- destination operand (*Value):   input and output
- source operand (ExchangeValue): input

The X64 version of InternalSyncCompareExchange64() attempts to mark both
CompareValue and (*Value) as input/output, but it doesn't use the
appropriate constraints for either operand.

Fix these issues. Furthermore, prefer the short "+" constraint for I/O
operands over the <output-operand-number> constraint that can be applied
to the input instances of I/O operands.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1208
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
Laszlo Ersek 2018-09-29 21:22:57 +02:00
parent 7149d40938
commit e5d4e7500f
1 changed files with 4 additions and 6 deletions

View File

@ -194,12 +194,10 @@ InternalSyncCompareExchange64 (
{ {
__asm__ __volatile__ ( __asm__ __volatile__ (
"lock \n\t" "lock \n\t"
"cmpxchgq %3, %1 \n\t" "cmpxchgq %2, %1 \n\t"
: "=a" (CompareValue), // %0 : "+a" (CompareValue), // %0
"=m" (*Value) // %1 "+m" (*Value) // %1
: "a" (CompareValue), // %2 : "r" (ExchangeValue) // %2
"r" (ExchangeValue), // %3
"m" (*Value) // %4
: "memory", : "memory",
"cc" "cc"
); );