tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

This patch uses dummy routine as NotifyFunction to make sure those 2 APIs provided from library can create event as expected when the caller does not feed in a NotifyFunction. Also, typo is corrected. 

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Mars Lin <Mars_Lin@phoenix.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14631 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Mars Lin 2013-09-05 06:12:04 +00:00 committed by lgao4
parent 10516d293f
commit e8326a006a
1 changed files with 27 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
MdePkg/Library/UefiLib/UefiNotTiano.c
View File

@ -34,7 +34,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
**/ **/
VOID VOID
EFIAPI EFIAPI
InternalEmptyFuntion ( InternalEmptyFunction (
IN EFI_EVENT Event, IN EFI_EVENT Event,
IN VOID *Context IN VOID *Context
) )
@ -67,7 +67,7 @@ EfiCreateEventLegacyBoot (
{ {
return EfiCreateEventLegacyBootEx ( return EfiCreateEventLegacyBootEx (
TPL_CALLBACK, TPL_CALLBACK,
InternalEmptyFuntion, InternalEmptyFunction,
NULL, NULL,
LegacyBootEvent LegacyBootEvent
); );
@ -101,7 +101,8 @@ EfiCreateEventLegacyBootEx (
OUT EFI_EVENT *LegacyBootEvent OUT EFI_EVENT *LegacyBootEvent
) )
{ {
EFI_STATUS Status; EFI_STATUS Status;
EFI_EVENT_NOTIFY WorkerNotifyFunction;
ASSERT (LegacyBootEvent != NULL); ASSERT (LegacyBootEvent != NULL);
@ -114,10 +115,19 @@ EfiCreateEventLegacyBootEx (
// //
// For UEFI 2.0 and the future use an Event Group // For UEFI 2.0 and the future use an Event Group
// //
if (NotifyFunction == NULL) {
//
// CreateEventEx will check NotifyFunction is NULL or not and return error.
// Use dummy routine for the case NotifyFunction is NULL.
//
WorkerNotifyFunction = InternalEmptyFunction;
} else {
WorkerNotifyFunction = NotifyFunction;
}
Status = gBS->CreateEventEx ( Status = gBS->CreateEventEx (
EVT_NOTIFY_SIGNAL, EVT_NOTIFY_SIGNAL,
NotifyTpl, NotifyTpl,
NotifyFunction, WorkerNotifyFunction,
NotifyContext, NotifyContext,
&gEfiEventLegacyBootGuid, &gEfiEventLegacyBootGuid,
LegacyBootEvent LegacyBootEvent
@ -152,7 +162,7 @@ EfiCreateEventReadyToBoot (
{ {
return EfiCreateEventReadyToBootEx ( return EfiCreateEventReadyToBootEx (
TPL_CALLBACK, TPL_CALLBACK,
InternalEmptyFuntion, InternalEmptyFunction,
NULL, NULL,
ReadyToBootEvent ReadyToBootEvent
); );
@ -186,7 +196,8 @@ EfiCreateEventReadyToBootEx (
OUT EFI_EVENT *ReadyToBootEvent OUT EFI_EVENT *ReadyToBootEvent
) )
{ {
EFI_STATUS Status; EFI_STATUS Status;
EFI_EVENT_NOTIFY WorkerNotifyFunction;
ASSERT (ReadyToBootEvent != NULL); ASSERT (ReadyToBootEvent != NULL);
@ -199,10 +210,19 @@ EfiCreateEventReadyToBootEx (
// //
// For UEFI 2.0 and the future use an Event Group // For UEFI 2.0 and the future use an Event Group
// //
if (NotifyFunction == NULL) {
//
// CreateEventEx will check NotifyFunction is NULL or not and return error.
// Use dummy routine for the case NotifyFunction is NULL.
//
WorkerNotifyFunction = InternalEmptyFunction;
} else {
WorkerNotifyFunction = NotifyFunction;
}
Status = gBS->CreateEventEx ( Status = gBS->CreateEventEx (
EVT_NOTIFY_SIGNAL, EVT_NOTIFY_SIGNAL,
NotifyTpl, NotifyTpl,
NotifyFunction, WorkerNotifyFunction,
NotifyContext, NotifyContext,
&gEfiEventReadyToBootGuid, &gEfiEventReadyToBootGuid,
ReadyToBootEvent ReadyToBootEvent