tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-04-08 17:05:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/DxeCore: Call BeforeExitBootServices event group only once

Browse Source 
According to UEFI spec 2.10 errata A section 7.4.6

  "All events from the EFI_EVENT_GROUP_BEFORE_EXIT_BOOT_SERVICES and
  EFI_EVENT_GROUP_EXIT_BOOT_SERVICES event notification groups as well
  as events of type EVT_SIGNAL_EXIT_BOOT_SERVICES must be signaled
  before ExitBootServices() returns EFI_SUCCESS. The events are only
  signaled once even if ExitBootServices() is called multiple times."

So keep track of whether ExitBootServices() has been called, and signal
the event group EFI_EVENT_GROUP_BEFORE_EXIT_BOOT_SERVICES only the first
time around.

EFI_EVENT_GROUP_EXIT_BOOT_SERVICES will only be signalled if
ExitBootServices() is going to run to [successful] completion, after
which calling it a second time is not possible anyway. So for this case,
no special handling is needed.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
This commit is contained in:
Ard Biesheuvel 2024-11-28 12:05:37 +01:00 committed by Liming Gao
parent 47e28a6d44
commit e8668d2dee
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
View File

@ -203,6 +203,8 @@ EFI_HANDLE gDxeCoreImageHandle = NULL;
BOOLEAN gMemoryMapTerminated = FALSE;
static BOOLEAN mExitBootServicesCalled = FALSE;
//
// EFI Decompress Protocol
//
@ -778,7 +780,10 @@ CoreExitBootServices (
// Notify other drivers of their last chance to use boot services
// before the memory map is terminated.
//
CoreNotifySignalList (&gEfiEventBeforeExitBootServicesGuid);
if (!mExitBootServicesCalled) {
CoreNotifySignalList (&gEfiEventBeforeExitBootServicesGuid);
mExitBootServicesCalled = TRUE;
}
//
// Disable Timer