tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

NetworkPkg/IScsiDxe: clean up library class dependencies 

Sort the library class dependencies in the #include directives and in the
INF file. Remove the DpcLib class from the #include directives -- it is
not listed in the INF file, and IScsiDxe doesn't call either DpcLib API
(QueueDpc(), DispatchDpc()). No functional changes.

Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3356
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Message-Id: <20210608121259.32451-5-lersek@redhat.com>
This commit is contained in:
Laszlo Ersek 2021-06-08 14:12:53 +02:00 committed by mergify[bot]
parent 95616b8661
commit e8f28b09e6
2 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
NetworkPkg/IScsiDxe/IScsiDxe.inf
View File

@ -65,6 +65,7 @@
NetworkPkg/NetworkPkg.dec NetworkPkg/NetworkPkg.dec
[LibraryClasses] [LibraryClasses]
BaseCryptLib
BaseLib BaseLib
BaseMemoryLib BaseMemoryLib
DebugLib DebugLib
@ -72,14 +73,13 @@
HiiLib HiiLib
MemoryAllocationLib MemoryAllocationLib
NetLib NetLib
TcpIoLib
PrintLib PrintLib
TcpIoLib
UefiBootServicesTableLib UefiBootServicesTableLib
UefiDriverEntryPoint UefiDriverEntryPoint
UefiHiiServicesLib
UefiLib UefiLib
UefiRuntimeServicesTableLib UefiRuntimeServicesTableLib
UefiHiiServicesLib
BaseCryptLib
[Protocols] [Protocols]
gEfiAcpiTableProtocolGuid ## SOMETIMES_CONSUMES ## SystemTable gEfiAcpiTableProtocolGuid ## SOMETIMES_CONSUMES ## SystemTable

19
NetworkPkg/IScsiDxe/IScsiImpl.h
View File

@ -35,21 +35,20 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include <Protocol/AdapterInformation.h> #include <Protocol/AdapterInformation.h>
#include <Protocol/NetworkInterfaceIdentifier.h> #include <Protocol/NetworkInterfaceIdentifier.h>
#include <Library/HiiLib.h> #include <Library/BaseCryptLib.h>
#include <Library/UefiHiiServicesLib.h>
#include <Library/DevicePathLib.h>
#include <Library/DebugLib.h>
#include <Library/BaseLib.h> #include <Library/BaseLib.h>
#include <Library/BaseMemoryLib.h> #include <Library/BaseMemoryLib.h>
#include <Library/DebugLib.h>
#include <Library/DevicePathLib.h>
#include <Library/HiiLib.h>
#include <Library/MemoryAllocationLib.h> #include <Library/MemoryAllocationLib.h>
#include <Library/PrintLib.h>
#include <Library/UefiBootServicesTableLib.h>
#include <Library/UefiRuntimeServicesTableLib.h>
#include <Library/UefiLib.h>
#include <Library/DpcLib.h>
#include <Library/NetLib.h> #include <Library/NetLib.h>
#include <Library/PrintLib.h>
#include <Library/TcpIoLib.h> #include <Library/TcpIoLib.h>
#include <Library/BaseCryptLib.h> #include <Library/UefiBootServicesTableLib.h>
#include <Library/UefiHiiServicesLib.h>
#include <Library/UefiLib.h>
#include <Library/UefiRuntimeServicesTableLib.h>
#include <Guid/MdeModuleHii.h> #include <Guid/MdeModuleHii.h>
#include <Guid/EventGroup.h> #include <Guid/EventGroup.h>