tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-27 07:34:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

IntelFsp2WrapperPkg: Fix constant if statements issue

Browse Source 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1351

Internal code quality scanning found 2 constant if
statements related to FixedPcdGet8 () usage.
Since the PCD can be PatchableInModule too, it should be
changed to PcdGet8 () to fix this issue.

Test: Verified on internal platform and booted successfully.

Cc: Jiewen Yao <Jiewen.yao@intel.com>
Cc: Desimone Nathaniel L <nathaniel.l.desimone@intel.com>
Cc: Wu Hao A <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
This commit is contained in:
Chasel, Chiu 2018-11-22 10:51:21 +08:00
parent 2098de6279
commit e8f40b770f
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c
View File

@ -157,7 +157,7 @@ FspmWrapperInit (
Status = EFI_SUCCESS; Status = EFI_SUCCESS;
if (FixedPcdGet8 (PcdFspModeSelection) == 1) { if (PcdGet8 (PcdFspModeSelection) == 1) {
Status = PeiFspMemoryInit (); Status = PeiFspMemoryInit ();
ASSERT_EFI_ERROR (Status); ASSERT_EFI_ERROR (Status);
} else { } else {

2
IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
View File

@ -349,7 +349,7 @@ FspsWrapperPeimEntryPoint (
{ {
DEBUG ((DEBUG_INFO, "FspsWrapperPeimEntryPoint\n")); DEBUG ((DEBUG_INFO, "FspsWrapperPeimEntryPoint\n"));
if (FixedPcdGet8 (PcdFspModeSelection) == 1) { if (PcdGet8 (PcdFspModeSelection) == 1) {
FspsWrapperInit (); FspsWrapperInit ();
} else { } else {
PeiServicesInstallFvInfoPpi ( PeiServicesInstallFvInfoPpi (