fixing errors found in code review.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9450 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
jcarsey 2009-11-19 19:53:58 +00:00
parent 125c2cf4f1
commit ef34de257b
4 changed files with 35 additions and 9 deletions

View File

@ -18,7 +18,7 @@
#define SHELLPKG_SHELL_ENV2_EXT_GUID \ #define SHELLPKG_SHELL_ENV2_EXT_GUID \
{ \ { \
0xd2c18636, 0x40e5, 0x4eb5, {0xa3, 0x1b, 0x36, 0x69, 0x5f, 0xd4, 0x2c, 0x87} \ 0xd2c18636, 0x40e5, 0x4eb5, {0xa3, 0x1b, 0x36, 0x69, 0x5f, 0xd4, 0x2c, 0x87} \
}; }
extern EFI_GUID gEfiShellEnvironment2ExtGuid; extern EFI_GUID gEfiShellEnvironment2ExtGuid;

View File

@ -26,12 +26,12 @@
// replaced EFI_LIST_ENTRY with LIST_ENTRY for simplicity. // replaced EFI_LIST_ENTRY with LIST_ENTRY for simplicity.
// they are identical outside of the name. // they are identical outside of the name.
typedef struct { typedef struct {
LIST_ENTRY Link; /// Linked list members LIST_ENTRY Link; ///< Linked list members
EFI_STATUS Status; /// Status of opening the file. Valid only if Handle != NULL. EFI_STATUS Status; ///< Status of opening the file. Valid only if Handle != NULL.
CONST CHAR16 *FullName; /// Fully qualified filename. CONST CHAR16 *FullName; ///< Fully qualified filename.
CONST CHAR16 *FileName; /// name of this file. CONST CHAR16 *FileName; ///< name of this file.
EFI_FILE_HANDLE Handle; /// Handle for interacting with the opened file or NULL if closed. EFI_FILE_HANDLE Handle; ///< Handle for interacting with the opened file or NULL if closed.
EFI_FILE_INFO *Info; /// Pointer to the FileInfo struct for this file or NULL. EFI_FILE_INFO *Info; ///< Pointer to the FileInfo struct for this file or NULL.
} EFI_SHELL_FILE_INFO; } EFI_SHELL_FILE_INFO;
/** /**
Returns whether any script files are currently being processed. Returns whether any script files are currently being processed.

View File

@ -21,10 +21,35 @@
} }
typedef struct _EFI_SHELL_PARAMETERS_PROTOCOL { typedef struct _EFI_SHELL_PARAMETERS_PROTOCOL {
///
/// Points to an Argc-element array of points to null-terminated strings containing
/// the command-line parameters. The first entry in the array is always the full file
/// path of the executable. Any quotation marks that were used to preserve
/// whitespace have been removed.
///
CHAR16 **Argv; CHAR16 **Argv;
///
/// The number of elements in the Argv array.
///
UINTN Argc; UINTN Argc;
///
/// The file handle for the standard input for this executable. This may be different
/// from the ConInHandle in the EFI_SYSTEM_TABLE.
///
EFI_FILE_HANDLE StdIn; EFI_FILE_HANDLE StdIn;
///
/// The file handle for the standard output for this executable. This may be different
/// from the ConOutHandle in the EFI_SYSTEM_TABLE.
///
EFI_FILE_HANDLE StdOut; EFI_FILE_HANDLE StdOut;
///
/// The file handle for the standard error output for this executable. This may be
/// different from the StdErrHandle in the EFI_SYSTEM_TABLE.
///
EFI_FILE_HANDLE StdErr; EFI_FILE_HANDLE StdErr;
} EFI_SHELL_PARAMETERS_PROTOCOL; } EFI_SHELL_PARAMETERS_PROTOCOL;

View File

@ -138,9 +138,10 @@ SHELL_INCOMPATIBLE_VERSION = 25,
SHELL_SECURITY_VIOLATION = 26, SHELL_SECURITY_VIOLATION = 26,
/// ///
/// A CRC error was detected. /// The function was performed and resulted in an unequal
/// comparison..
/// ///
SHELL_CRC_ERROR = 27 SHELL_NOT_EQUAL = 27
}SHELL_STATUS; }SHELL_STATUS;
#endif //__SHELL_BASE__ #endif //__SHELL_BASE__