From f2b9d5417dccf763bcbb68cd0effed0e25890aab Mon Sep 17 00:00:00 2001 From: Leif Lindholm Date: Tue, 21 Nov 2023 16:42:28 +0000 Subject: [PATCH] ArmPkg,MdePkg: move ArmLib.h to MdePkg Related to https://bugzilla.tianocore.org/show_bug.cgi?id=4121, but not resolving it. (Nearly?) all of ArmPkg describes industry standard behaviour, and hence according to general rules, ought to live in MdePkg. Addressing this will however be a substantial task. Take a first step by moving the ArmLib interface definition to MdePkg, as discussed in https://edk2.groups.io/g/devel/topic/patch_v5_2_6/102725178 Continuous-integration-options: PatchCheck.ignore-multi-package Cc: Pierre Gondois Cc: Jiewen Yao Cc: Ard Biesheuvel Cc: Liming Gao Cc: Michael D Kinney Cc: Sami Mujawar Cc: Zhiguang Liu Signed-off-by: Pierre Gondois --- ArmPkg/ArmPkg.dec | 4 ---- Maintainers.txt | 6 ++++++ {ArmPkg => MdePkg}/Include/Library/ArmLib.h | 0 MdePkg/MdePkg.dec | 5 +++++ 4 files changed, 11 insertions(+), 4 deletions(-) rename {ArmPkg => MdePkg}/Include/Library/ArmLib.h (100%) diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index 7fe2b9bca4..4ce59f3e1f 100644 --- a/ArmPkg/ArmPkg.dec +++ b/ArmPkg/ArmPkg.dec @@ -50,10 +50,6 @@ # ArmHvcLib|Include/Library/ArmHvcLib.h - ## @libraryclass Provides an interface to Arm registers. - # - ArmLib|Include/Library/ArmLib.h - ## @libraryclass Provides a Mmu interface. # ArmMmuLib|Include/Library/ArmMmuLib.h diff --git a/Maintainers.txt b/Maintainers.txt index 274554a2c5..6f91c218b4 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -461,6 +461,12 @@ F: MdePkg/Include/IndustryStandard/SpiNorFlashJedecSfdp.h M: Abner Chang [changab] R: Brit Chesley [BritChesley] +MdePkg: ARM/AARCH64 standard interfaces +F: MdePkg/Include/Library/ArmLib.h +M: Leif Lindholm [leiflindholm] +M: Ard Biesheuvel [ardbiesheuvel] +R: Sami Mujawar [samimujawar] + NetworkPkg F: NetworkPkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg diff --git a/ArmPkg/Include/Library/ArmLib.h b/MdePkg/Include/Library/ArmLib.h similarity index 100% rename from ArmPkg/Include/Library/ArmLib.h rename to MdePkg/Include/Library/ArmLib.h diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index bf94549cbf..94170ff9a4 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -339,6 +339,11 @@ ## @libraryclass Provides function to make ecalls to SBI BaseRiscVSbiLib|Include/Library/BaseRiscVSbiLib.h +[LibraryClasses.ARM, LibraryClasses.AARCH64] + ## @libraryclass Provides an interface to Arm registers. + # + ArmLib|Include/Library/ArmLib.h + [Guids] # # GUID defined in UEFI2.1/UEFI2.0/EFI1.1