tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SecurityPkg AuthVariableLib: Correct comment/error log about CleanCertsFromDb 

Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Chao Zhang <chao.b.zhang@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19574 6f19259b-4bc3-4df7-8a09-765794883524
This commit is contained in:
Star Zeng 2015-12-29 09:07:32 +00:00 committed by lzeng14
parent 4a23636a34
commit f3964772d2
2 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
SecurityPkg/Library/AuthVariableLib/AuthService.c
View File

@ -2984,12 +2984,13 @@ InsertCertsToDb (
/** /**
Clean up signer's certificates for common authenticated variable Clean up signer's certificates for common authenticated variable
by corresponding VariableName and VendorGuid from "certdb". by corresponding VariableName and VendorGuid from "certdb".
Sytem may break down during Timebased Variable update & certdb update, System may break down during Timebased Variable update & certdb update,
make them inconsistent, this function is called in AuthVariable Init to ensure make them inconsistent, this function is called in AuthVariable Init
consistency to ensure consistency.
@retval EFI_NOT_FOUND Fail to find matching certs. @retval EFI_NOT_FOUND Fail to find variable "certdb".
@retval EFI_SUCCESS Find matching certs and output parameters. @retval EFI_OUT_OF_RESOURCES The operation is failed due to lack of resources.
@retval EFI_SUCCESS The operation is completed successfully.
**/ **/
EFI_STATUS EFI_STATUS
@ -3040,9 +3041,6 @@ CleanCertsFromDb (
while (Offset < (UINT32) DataSize) { while (Offset < (UINT32) DataSize) {
Ptr = (AUTH_CERT_DB_DATA *) (Data + Offset); Ptr = (AUTH_CERT_DB_DATA *) (Data + Offset);
//
// Check whether VendorGuid matches.
//
NodeSize = ReadUnaligned32 (&Ptr->CertNodeSize); NodeSize = ReadUnaligned32 (&Ptr->CertNodeSize);
NameSize = ReadUnaligned32 (&Ptr->NameSize); NameSize = ReadUnaligned32 (&Ptr->NameSize);

2
SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c
View File

@ -283,7 +283,7 @@ AuthVariableLibInitialize (
// //
Status = CleanCertsFromDb(); Status = CleanCertsFromDb();
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
DEBUG ((EFI_D_INFO, "Clean up CertDB fail! Status %x\n", Status)); DEBUG ((EFI_D_ERROR, "Clean up CertDB fail! Status %x\n", Status));
return Status; return Status;
} }
} }