tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UnitTestFrameworkPkg/UnitTestLib: Fix XCODE parenthesis issues 

https://bugzilla.tianocore.org/show_bug.cgi?id=2512

Remove extra sets of parenthesis that generate warnings on XCODE5
builds.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>
This commit is contained in:
Michael D Kinney 2020-02-10 10:30:19 -08:00 committed by mergify[bot]
parent 69c135462d
commit f76d50166b
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c
View File

@ -247,7 +247,7 @@ UnitTestAssertEqual (
IN CONST CHAR8 *DescriptionB IN CONST CHAR8 *DescriptionB
) )
{ {
if ((ValueA != ValueB)) { if (ValueA != ValueB) {
UnitTestLogFailure ( UnitTestLogFailure (
FAILURETYPE_ASSERTEQUAL, FAILURETYPE_ASSERTEQUAL,
"%a::%d Value %a != %a (%d != %d)!\n", "%a::%d Value %a != %a (%d != %d)!\n",
@ -365,7 +365,7 @@ UnitTestAssertNotEqual (
IN CONST CHAR8 *DescriptionB IN CONST CHAR8 *DescriptionB
) )
{ {
if ((ValueA == ValueB)) { if (ValueA == ValueB) {
UnitTestLogFailure ( UnitTestLogFailure (
FAILURETYPE_ASSERTNOTEQUAL, FAILURETYPE_ASSERTNOTEQUAL,
"%a::%d Value %a == %a (%d == %d)!\n", "%a::%d Value %a == %a (%d == %d)!\n",
@ -420,7 +420,7 @@ UnitTestAssertStatusEqual (
IN CONST CHAR8 *Description IN CONST CHAR8 *Description
) )
{ {
if ((Status != Expected)) { if (Status != Expected) {
UnitTestLogFailure ( UnitTestLogFailure (
FAILURETYPE_ASSERTSTATUSEQUAL, FAILURETYPE_ASSERTSTATUSEQUAL,
"%a::%d Status '%a' is %r, should be %r!\n", "%a::%d Status '%a' is %r, should be %r!\n",

2
UnitTestFrameworkPkg/Library/UnitTestLib/Log.c
View File

@ -136,7 +136,7 @@ UnitTestLogInit (
return; return;
} }
if((Buffer != NULL) && (BufferSize > 0) && ((BufferSize <= UNIT_TEST_MAX_LOG_BUFFER))) { if((Buffer != NULL) && (BufferSize > 0) && (BufferSize <= UNIT_TEST_MAX_LOG_BUFFER)) {
CopyMem (Test->Log, Buffer, BufferSize); CopyMem (Test->Log, Buffer, BufferSize);
} }
} }