From f944ec32e7e1ccc2968838da946bf4fba4cc7bce Mon Sep 17 00:00:00 2001 From: eric_tian Date: Tue, 16 Sep 2008 06:13:42 +0000 Subject: [PATCH] follow up code review git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5894 6f19259b-4bc3-4df7-8a09-765794883524 --- MdePkg/Include/Library/PeiPiLib.h | 36 +++++++++---------- .../Library/PeiServicesTablePointerLib.h | 2 +- MdePkg/Library/PeiPiLib/PeiPiLib.c | 36 +++++++++---------- .../PeiServicesTablePointer.c | 2 +- .../PeiServicesTablePointer.c | 2 +- .../PeiServicesTablePointer.c | 2 +- 6 files changed, 40 insertions(+), 40 deletions(-) diff --git a/MdePkg/Include/Library/PeiPiLib.h b/MdePkg/Include/Library/PeiPiLib.h index c0c2eba873..c0e0a2a204 100644 --- a/MdePkg/Include/Library/PeiPiLib.h +++ b/MdePkg/Include/Library/PeiPiLib.h @@ -15,27 +15,27 @@ #ifndef __PEI_PI_LIB_H__ #define __PEI_PI_LIB_H__ -#include - /** - Install a EFI_PEI_FIRMWARE_VOLUME_INFO PPI to inform PEI core about the existence of a new Firmware Volume. + Install a EFI_PEI_FIRMWARE_VOLUME_INFO PPI to inform PEI core about the existence of a new Firmware Volume. - The function allocate the EFI_PEI_PPI_DESCRIPTOR structure and update the fields accordingly to parameter passed - in and install the PPI. - - @param FvFormat Unique identifier of the format of the memory-mapped firmware volume. If NULL is specified, - EFI_FIRMWARE_FILE_SYSTEM2_GUID is used as the Format GUID. - @param FvInfo Points to a buffer which allows the EFI_PEI_FIRMWARE_VOLUME_PPI to - process the volume. The format of this buffer is specific to the FvFormat. For - memory-mapped firmware volumes, this typically points to the first byte of the - firmware volume. - @param FvInfoSize Size of the data provided by FvInfo. For memory-mapped firmware volumes, this is - typically the size of the firmware volume. - @param ParentFvName, ParentFileName If the firmware volume originally came from a firmware file, then these point to the - parent firmware volume name and firmware volume file. If it did not originally come - from a firmware file, these should be NULL + The function allocate the EFI_PEI_PPI_DESCRIPTOR structure and update the fields accordingly to parameter passed + in and install the PPI. - + @param FvFormat Unique identifier of the format of the memory-mapped firmware volume. + If NULL is specified, EFI_FIRMWARE_FILE_SYSTEM2_GUID is used as the Format GUID. + @param FvInfo Points to a buffer which allows the EFI_PEI_FIRMWARE_VOLUME_PPI to + process the volume. The format of this buffer is specific to the FvFormat. For + memory-mapped firmware volumes, this typically points to the first byte of the + firmware volume. + @param FvInfoSize Size of the data provided by FvInfo. For memory-mapped firmware volumes, this is + typically the size of the firmware volume. + @param ParentFvName If the firmware volume originally came from a firmware file, then these point to the + parent firmware volume name. If it did not originally come from a firmware file, + these should be NULL. + @param ParentFileName If the firmware volume originally came from a firmware file, then these point to the + firmware volume file. If it did not originally come from a firmware file, + these should be NULL. + **/ VOID EFIAPI diff --git a/MdePkg/Include/Library/PeiServicesTablePointerLib.h b/MdePkg/Include/Library/PeiServicesTablePointerLib.h index 973598870e..015d9723be 100644 --- a/MdePkg/Include/Library/PeiServicesTablePointerLib.h +++ b/MdePkg/Include/Library/PeiServicesTablePointerLib.h @@ -39,7 +39,7 @@ GetPeiServicesTablePointer ( VOID EFIAPI SetPeiServicesTablePointer ( - EFI_PEI_SERVICES ** PeiServicesTablePointer + IN EFI_PEI_SERVICES ** PeiServicesTablePointer ); #endif diff --git a/MdePkg/Library/PeiPiLib/PeiPiLib.c b/MdePkg/Library/PeiPiLib/PeiPiLib.c index 4c9cea865c..876f5cab39 100644 --- a/MdePkg/Library/PeiPiLib/PeiPiLib.c +++ b/MdePkg/Library/PeiPiLib/PeiPiLib.c @@ -32,26 +32,26 @@ CONST EFI_PEI_PPI_DESCRIPTOR mPpiListTemplate [] = { }; /** - Install a EFI_PEI_FIRMWARE_VOLUME_INFO PPI to inform PEI core about the existence of a new Firmware Volume. + Install a EFI_PEI_FIRMWARE_VOLUME_INFO PPI to inform PEI core about the existence of a new Firmware Volume. - The function allocate the EFI_PEI_PPI_DESCRIPTOR structure and update the fields accordingly to parameter passed - in and install the PPI. - - @param FvFormat Unique identifier of the format of the memory-mapped firmware volume. If NULL is specified, - EFI_FIRMWARE_FILE_SYSTEM2_GUID is used as the Format GUID. - @param FvInfo Points to a buffer which allows the EFI_PEI_FIRMWARE_VOLUME_PPI to - process the volume. The format of this buffer is specific to the FvFormat. For - memory-mapped firmware volumes, this typically points to the first byte of the - firmware volume. - @param FvInfoSize Size of the data provided by FvInfo. For memory-mapped firmware volumes, this is - typically the size of the firmware volume. - @param ParentFvName If the firmware volume originally came from a firmware file, then these point to the - parent firmware volume name. If it did not originally come - from a firmware file, these should be NULL. - @param ParentFileName If the firmware volume originally came from a firmware file, then these point to the - firmware volume file. If it did not originally come - from a firmware file, these should be NULL. + The function allocate the EFI_PEI_PPI_DESCRIPTOR structure and update the fields accordingly to parameter passed + in and install the PPI. + @param FvFormat Unique identifier of the format of the memory-mapped firmware volume. + If NULL is specified, EFI_FIRMWARE_FILE_SYSTEM2_GUID is used as the Format GUID. + @param FvInfo Points to a buffer which allows the EFI_PEI_FIRMWARE_VOLUME_PPI to + process the volume. The format of this buffer is specific to the FvFormat. For + memory-mapped firmware volumes, this typically points to the first byte of the + firmware volume. + @param FvInfoSize Size of the data provided by FvInfo. For memory-mapped firmware volumes, this is + typically the size of the firmware volume. + @param ParentFvName If the firmware volume originally came from a firmware file, then these point to the + parent firmware volume name. If it did not originally come from a firmware file, + these should be NULL. + @param ParentFileName If the firmware volume originally came from a firmware file, then these point to the + firmware volume file. If it did not originally come from a firmware file, + these should be NULL. + **/ VOID EFIAPI diff --git a/MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c b/MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c index 38051a9173..b601545b8c 100644 --- a/MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c +++ b/MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c @@ -29,7 +29,7 @@ STATIC EFI_PEI_SERVICES **gPeiServices; VOID EFIAPI SetPeiServicesTablePointer ( - EFI_PEI_SERVICES **PeiServices + IN EFI_PEI_SERVICES **PeiServices ) { gPeiServices = PeiServices; diff --git a/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c b/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c index e38db636e8..ba2f9d6cad 100644 --- a/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c +++ b/MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointer.c @@ -65,7 +65,7 @@ GetPeiServicesTablePointer ( VOID EFIAPI SetPeiServicesTablePointer ( - EFI_PEI_SERVICES ** PeiServicesTablePointer + IN EFI_PEI_SERVICES ** PeiServicesTablePointer ) { IA32_DESCRIPTOR Idtr; diff --git a/MdePkg/Library/PeiServicesTablePointerLibKr7/PeiServicesTablePointer.c b/MdePkg/Library/PeiServicesTablePointerLibKr7/PeiServicesTablePointer.c index db85833037..598a9c340d 100644 --- a/MdePkg/Library/PeiServicesTablePointerLibKr7/PeiServicesTablePointer.c +++ b/MdePkg/Library/PeiServicesTablePointerLibKr7/PeiServicesTablePointer.c @@ -71,7 +71,7 @@ PeiServicesTablePointerLibConstructor ( VOID EFIAPI SetPeiServicesTablePointer ( - EFI_PEI_SERVICES ** PeiServicesTablePointer + IN EFI_PEI_SERVICES ** PeiServicesTablePointer ) { AsmWriteKr7 ((UINT64)(UINTN)PeiServicesTablePointer);