From f97a5b5e4cab1f01f92a0899cc95b92c5a9f3ed3 Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Mon, 26 Oct 2015 14:58:26 +0000 Subject: [PATCH] OvmfPkg: QemuFlashFvbServicesRuntimeDxe: remove FvbScratchSpace field The ESAL_FWB_GLOBAL.FvbScratchSpace array is never initialized (it contains garbage from AllocateRuntimePool()). Its element at subscript one (=FVB_VIRTUAL), containing garbage as well, is converted to virtual mapping. Then the array is never used again. Remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Jordan Justen git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18669 6f19259b-4bc3-4df7-8a09-765794883524 --- OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c | 2 -- OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.h | 1 - 2 files changed, 3 deletions(-) diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c index 3e7fe68081..95ae8ccb76 100644 --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c @@ -169,8 +169,6 @@ FvbVirtualddressChangeEvent ( Index++; } - EfiConvertPointer (0x0, - (VOID **) &mFvbModuleGlobal->FvbScratchSpace[FVB_VIRTUAL]); EfiConvertPointer (0x0, (VOID **) &mFvbModuleGlobal); QemuFlashConvertPointers (); } diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.h b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.h index 67140d0a76..7e4ff1e7a0 100644 --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.h +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.h @@ -38,7 +38,6 @@ typedef struct { typedef struct { UINT32 NumFv; EFI_FW_VOL_INSTANCE *FvInstance[2]; - UINT8 *FvbScratchSpace[2]; } ESAL_FWB_GLOBAL; //