tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OvmfPkg/PciHostBridgeLib: silence IA32 VS2015x86 warnings 

When compiling "OvmfPkg\Library\PciHostBridgeLib\XenSupport.c" for IA32,
the VS2015x86 compiler emits the following:

> XenSupport.c(41): error C2220: warning treated as error - no 'object'
>                                file generated
> XenSupport.c(41): warning C4244: 'function': conversion from 'UINT64' to
>                                  'UINTN', possible loss of data
> XenSupport.c(48): warning C4244: 'function': conversion from 'UINT64' to
>                                  'UINTN', possible loss of data
> XenSupport.c(49): warning C4244: 'function': conversion from 'UINT64' to
>                                  'UINTN', possible loss of data
> XenSupport.c(50): warning C4244: 'function': conversion from 'UINT64' to
>                                  'UINTN', possible loss of data
> XenSupport.c(222): warning C4244: 'function': conversion from 'UINT64'
>                                   to 'UINTN', possible loss of data
> XenSupport.c(241): warning C4244: 'function': conversion from 'UINT64'
>                                   to 'UINTN', possible loss of data

PciLib functions take UINTN addresses that were encoded with the
PCI_LIB_ADDRESS() macro. We carry addresses from the macro invocations to
the function calls in two UINT64 variables however. This loses no data,
but it alerts VS2015x86. Change the variable types to UINTN.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
This commit is contained in:
Laszlo Ersek 2016-07-14 17:34:38 +02:00
parent 09a85f6eeb
commit f982bb8d62
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
View File

@ -30,7 +30,7 @@
STATIC STATIC
VOID VOID
PcatPciRootBridgeBarExisted ( PcatPciRootBridgeBarExisted (
IN UINT64 Address, IN UINTN Address,
OUT UINT32 *OriginalValue, OUT UINT32 *OriginalValue,
OUT UINT32 *Value OUT UINT32 *Value
) )
@ -180,7 +180,7 @@ ScanForRootBridges (
UINT8 Device; UINT8 Device;
UINT8 Function; UINT8 Function;
UINTN NumberOfDevices; UINTN NumberOfDevices;
UINT64 Address; UINTN Address;
PCI_TYPE01 Pci; PCI_TYPE01 Pci;
UINT64 Attributes; UINT64 Attributes;
UINT64 Base; UINT64 Base;