ArmPkg: Fix Ecc error 5007 in CompilerIntrinsicsLib

This patch fixes the following Ecc reported error:
There should be no initialization of a variable as
part of its declaration

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

ArmPkg/Library/CompilerIntrinsicsLib/memcmp_ms.c

@@ -18,8 +18,11 @@ int memcmp(void *, void *, size_t);
 #pragma function(memcmp)
 int memcmp(const void *s1, const void *s2, size_t n)
 {
-  unsigned char const *t1 = s1;
-  unsigned char const *t2 = s2;
+  unsigned char const *t1;
+  unsigned char const *t2;
+
+  t1 = s1;
+  t2 = s2;
 
   while (n-- != 0) {
     if (*t1 != *t2)

ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c

@@ -11,8 +11,11 @@ typedef __SIZE_TYPE__ size_t;
 
 static void __memcpy(void *dest, const void *src, size_t n)
 {
-  unsigned char *d = dest;
-  unsigned char const *s = src;
+  unsigned char *d;
+  unsigned char const *s;
+
+  d = dest;
+  s = src;
 
   while (n-- != 0) {
     *d++ = *s++;

ArmPkg/Library/CompilerIntrinsicsLib/memcpy_ms.c

@@ -18,8 +18,11 @@ void* memcpy(void *, const void *, size_t);
 #pragma function(memcpy)
 void* memcpy(void *dest, const void *src, size_t n)
 {
-  unsigned char *d = dest;
-  unsigned char const *s = src;
+  unsigned char *d;
+  unsigned char const *s;
+
+  d = dest;
+  s = src;
 
   while (n-- != 0) {
     *d++ = *s++;

ArmPkg/Library/CompilerIntrinsicsLib/memmove_ms.c

@@ -18,8 +18,11 @@ void* memmove(void *, const void *, size_t);
 #pragma function(memmove)
 void* memmove(void *dest, const void *src, size_t n)
 {
-  unsigned char *d = dest;
-  unsigned char const *s = src;
+  unsigned char *d;
+  unsigned char const *s;
+
+  d = dest;
+  s = src;
 
   if (d < s) {
     while (n-- != 0) {

ArmPkg/Library/CompilerIntrinsicsLib/memset.c

@@ -12,7 +12,9 @@ typedef __SIZE_TYPE__ size_t;
 static __attribute__((__used__))
 void *__memset(void *s, int c, size_t n)
 {
-  unsigned char *d = s;
+  unsigned char *d;
+
+  d = s;
 
   while (n-- != 0) {
     *d++ = c;

ArmPkg/Library/CompilerIntrinsicsLib/memset_ms.c

@@ -18,7 +18,9 @@ void* memset(void *, int, size_t);
 #pragma function(memset)
 void *memset(void *s, int c, size_t n)
 {
-  unsigned char *d = s;
+  unsigned char *d;
+
+  d = s;
 
   while (n-- != 0) {
     *d++ = (unsigned char)c;