tyler.durden/audk
1
0
Fork 0
mirror of https://github.com/acidanthera/audk.git synced 2025-07-31 01:24:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

MdeModulePkg/SetupBrowser: Call submit callback function when no failure

Browse Source 
In current code will always call submit callback function,
but we should call submit callback function when has no failure
in the submit action. This patch to fix this issues.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
Dandan Bi 2016-04-26 19:52:02 +08:00 committed by Star Zeng
parent 8066b27e86
commit fdd530d61b
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
View File

@ -3182,6 +3182,9 @@ SubmitForForm (
EFI_STRING Progress; EFI_STRING Progress;
BROWSER_STORAGE *Storage; BROWSER_STORAGE *Storage;
FORM_BROWSER_CONFIG_REQUEST *ConfigInfo; FORM_BROWSER_CONFIG_REQUEST *ConfigInfo;
BOOLEAN SubmitFormFail;
SubmitFormFail = FALSE;
if (!IsNvUpdateRequiredForForm (Form)) { if (!IsNvUpdateRequiredForForm (Form)) {
return EFI_SUCCESS; return EFI_SUCCESS;
@ -3231,6 +3234,7 @@ SubmitForForm (
// //
// Submit fail, to get the RestoreConfigRequest and SyncConfigRequest. // Submit fail, to get the RestoreConfigRequest and SyncConfigRequest.
// //
SubmitFormFail = TRUE;
GetSyncRestoreConfigRequest (ConfigInfo->Storage, ConfigInfo->ConfigRequest, Progress, &ConfigInfo->RestoreConfigRequest, &ConfigInfo->SyncConfigRequest); GetSyncRestoreConfigRequest (ConfigInfo->Storage, ConfigInfo->ConfigRequest, Progress, &ConfigInfo->RestoreConfigRequest, &ConfigInfo->SyncConfigRequest);
InsertTailList (&gBrowserSaveFailFormSetList, &ConfigInfo->SaveFailLink); InsertTailList (&gBrowserSaveFailFormSetList, &ConfigInfo->SaveFailLink);
continue; continue;
@ -3288,7 +3292,9 @@ SubmitForForm (
// //
// 6 Call callback with Submitted type to inform the driver. // 6 Call callback with Submitted type to inform the driver.
// //
SubmitCallback (FormSet, Form); if (!SubmitFormFail) {
SubmitCallback (FormSet, Form);
}
return Status; return Status;
} }
@ -3324,8 +3330,10 @@ SubmitForFormSet (
FORM_BROWSER_FORM *Form; FORM_BROWSER_FORM *Form;
BOOLEAN HasInserted; BOOLEAN HasInserted;
FORM_BROWSER_STATEMENT *Question; FORM_BROWSER_STATEMENT *Question;
BOOLEAN SubmitFormSetFail;
HasInserted = FALSE; HasInserted = FALSE;
SubmitFormSetFail = FALSE;
if (!IsNvUpdateRequiredForFormSet (FormSet)) { if (!IsNvUpdateRequiredForFormSet (FormSet)) {
return EFI_SUCCESS; return EFI_SUCCESS;
@ -3388,6 +3396,7 @@ SubmitForFormSet (
// //
// Submit fail, to get the RestoreConfigRequest and SyncConfigRequest. // Submit fail, to get the RestoreConfigRequest and SyncConfigRequest.
// //
SubmitFormSetFail = TRUE;
GetSyncRestoreConfigRequest (FormSetStorage->BrowserStorage, FormSetStorage->ConfigRequest, Progress, &FormSetStorage->RestoreConfigRequest, &FormSetStorage->SyncConfigRequest); GetSyncRestoreConfigRequest (FormSetStorage->BrowserStorage, FormSetStorage->ConfigRequest, Progress, &FormSetStorage->RestoreConfigRequest, &FormSetStorage->SyncConfigRequest);
InsertTailList (&FormSet->SaveFailStorageListHead, &FormSetStorage->SaveFailLink); InsertTailList (&FormSet->SaveFailStorageListHead, &FormSetStorage->SaveFailLink);
if (!HasInserted) { if (!HasInserted) {
@ -3481,7 +3490,9 @@ SubmitForFormSet (
// //
// 6. Call callback with Submitted type to inform the driver. // 6. Call callback with Submitted type to inform the driver.
// //
SubmitCallback (FormSet, NULL); if (!SubmitFormSetFail) {
SubmitCallback (FormSet, NULL);
}
return Status; return Status;
} }