jcarsey
28d903168c
ShellPkg: This patch fixes the redirection support for a Shell2 application running in Shell1.
...
signed-off-by: Richard_Chan@Dell.com
reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12951 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-20 21:58:15 +00:00
jcarsey
a32980dd3c
ShellPkg: Fix rm CWD protection to be better at catching similarly named directories.
...
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12950 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-20 18:10:45 +00:00
jcarsey
a7224eefeb
ShellPkg: Check for Abort flag in main 'for' loop of ls command and propagate the condition when found.
...
Also prevents printing of an error output when user selects abort.
signed-off-by: jcarsey
reviewed-by:
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12925 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-11 18:45:23 +00:00
jcarsey
f0b0e7338b
ShellPkg: Propagate verbose flag down so it can be used in all DH command use cases.
...
signed-off-by: jcarsey
reviewed-by: leegrosenbaum
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12923 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-10 20:53:26 +00:00
jcarsey
f4f3c6bf0a
ShellPkg: Add dump information for PCI Root Bridge IO protocol.
...
This indirectly updates the DH command since it will automatically call the new function.
signed-off-by: jcarsey
reviewed-by: leegrosenbaum
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12922 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-10 20:51:04 +00:00
jcarsey
dee3431846
ShellPkg: Add protocols / protocol GUIDs to display and input mapping.
...
This adds all protocols in the MdePkg.dec.
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12920 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-09 19:11:54 +00:00
jcarsey
344b16e151
ShellPkg: fix copyright date.
...
signed-off-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12911 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-05 20:46:16 +00:00
jcarsey
b471606bdf
ShellPkg: fix For command parsing list of values.
...
Fix a check that was checking twice for double quote '"' and not for space ' '.
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12910 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-05 20:43:31 +00:00
jcarsey
d8fdd5247c
ShellPkg: Fix swapping of reset behavior.
...
This fix exchanges the behavior between "reset -c" and "reset" with "reset -w".
signed-off-by: jliu66
reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12909 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-05 18:20:23 +00:00
jcarsey
8fcf74a850
ShellPkg: print error when column index is out of range instead of ASSERT.
...
signed-off-by: jcarsey
reviewed-by: leegrosenbaum
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12904 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-02 21:17:20 +00:00
jcarsey
8f04ca1a8f
ShellPkg: Fix "-b" usage with timezone command.
...
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12799 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-29 21:46:53 +00:00
jcarsey
2e5c97edcd
ShellPkg: Fix handling of empty files in Hexedit
...
Currently hexedit thinks all files that are non-existent (i.e. new) or empty must be a memory error since the pointer is checked, but the file size is not referenced.
Signed-off-by: jcarsey
Reviewed-by: jljusten
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12797 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-29 15:37:04 +00:00
jcarsey
73c83c69c0
ShellPkg: Correct incorrect use of sizeof to use macro for EFI_FILE_INFO size.
...
Signed-off-by: jcarsey
Reviewed-by: niruiyu
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12740 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-18 17:02:36 +00:00
jcarsey
2d3759d8b5
ShellPkg: Update the ‘for’ command to check number length correctly with trailing spaces.
...
This fix corrects the logic that checks number length such that is functions correctly without a trailing space.
Signed-off-by: jcarsey
Reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12736 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-17 21:38:20 +00:00
darylm503
b0934ac4b0
ShellPkg: Update comments for functions to clarify buffer origin.
...
Signed-off-by: darylm503
Reviewed-by: jljusten
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12687 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-12 00:35:11 +00:00
jcarsey
d16efcae82
Shellpkg: Add support for filenames with spaces.
...
This patch changes the file redirection support to allow for quote delimited filenames that contain spaces and updates the edit command to allow spaces in the filename. This also properly fails for attempts to redirect to "" (empty quotes).
signed-off-by: jcarsey
reviewed-by: jliu66
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12685 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-11 16:45:19 +00:00
jcarsey
3372840669
ShellPkg: swap warm and cold to get the default correct for Reset command.
...
sighed-off-by: jcarsey
reviewed-by: gookboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12623 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-01 20:05:11 +00:00
ydong10
d6c06dd776
Fix a code typo.
...
Signed-off-by: ydong10
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12543 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-18 01:47:53 +00:00
jcarsey
c8c2259156
ShellPkg: Add checking for memory allocation and pointer returns from functions.
...
signed-off-by: jcarsey
reviewed-by: lgrosenb
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12542 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-17 17:49:21 +00:00
jcarsey
532691c8ba
ShellPkg: Add checking for memory allocation and pointer returns from functions.
...
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12540 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-14 19:21:13 +00:00
jcarsey
7a95efda40
SShellPkg: updating order of cast and addressing of a pointer (2 identical places).
...
GCC build didn't like the original version.
sighed-off-by: jcarsey
reviewed-by: lgrosenb
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12535 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-13 16:08:18 +00:00
ydong10
0c1950ba5e
Check the pointer before use it to avoid potential access violation.
...
Signed-off-by: ydong10
Reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12533 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-13 02:37:35 +00:00
jcarsey
4d10ab79d7
ShellPkg: Add checks for NULL pointers.
...
This adds lots of pointer verification with ASSERTs only used when the condition should be impossible and never for memory allocation.
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12524 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-10 20:36:44 +00:00
jcarsey
ecae51177e
ShellPkg: Add checks for NULL pointers.
...
This adds lots of pointer verification with ASSERTs only used when the condition should be impossible and never for memory allocation.
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12523 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-10 20:32:17 +00:00
jcarsey
beab0fc5e2
ShellPkg: Verify memory allocations without ASSERT.
...
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12522 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-10 17:26:25 +00:00
sfu5
02a758cb0b
Add pointer check for NULL before dereference it.
...
Signed-off-by: sfu5
Reviewed-by: xdu2
Reviewed-by: ydong10
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12514 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-08 02:55:30 +00:00
lgao4
bca163ff11
Clean up the private GUID definition in module Level.
...
Signed-off-by: lgao4
Reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12394 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-21 01:56:00 +00:00
jcarsey
eca218a7ce
ShellPkg: Verify DevicePathToText was successful before using the resultant pointer.
...
signed-off-by: jcarsey
reviewed-by: darylm503
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12393 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-20 23:06:23 +00:00
jcarsey
1fc3749dad
ShellPkg: fix support for "\" (or "\.") meaning root of drive.
...
Cp command fixed to allow for copying single or multiple files to the root of the drive with destination directory \.
Cd command fixed to allow for changing CWD to the root of the drive with destination directory \.
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12392 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-20 21:01:34 +00:00
jcarsey
b6b22b132a
ShellPkg: Eliminate loss of high bits in return value from exit command on 64 bit platform.
...
submitted-by: jcarsey
reviewed-by: gookboy15a
reviewed-by: niruiyu
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12356 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-15 20:10:39 +00:00
jcarsey
6a5aa4d6dc
ShellPkg: Add 3 missing function declaration comments and change a function static variable to a file global variable.
...
Submitted-by: jcarsey
Reviewed-by: geekboy15a
Reviewed-by: ydong10
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12317 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-09 16:57:26 +00:00
jcarsey
a0cd353dd2
ShellPkg: allow for mm command to properly write PCIe in non-interactive mode.
...
Submitted-by: jcarsey
Reviewed-by: jljusten
Reviewed-by: marothma
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12299 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-08 16:50:17 +00:00
ydong10
4ff7e37b4f
Refine comments and two code style.
...
Signed-off-by: ydong10
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12263 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-02 08:05:34 +00:00
jcarsey
5d46f17ba7
ShellPkg: fix ShellPrint-functions to allow for escape character to prevent attribute changes.
...
This allows for the editors to function easily.
signed-off-by: jcarsey
reviewed-by: kidzyoung
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12187 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-23 15:34:23 +00:00
jcarsey
d159ab9538
ShellPkg: fix build error when converting INTN to INT32.
...
signed-off-by: jcarsey
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12186 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-23 15:32:49 +00:00
jcarsey
382e78c09c
ShellPkg: bug fix for edit search/replace function
...
* Fix the search bug: if word to be searched at the beginning of the line, it can not be found out.
Signed-off-by: kidzyoung
reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12116 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-10 14:48:14 +00:00
jcarsey
573d7e468e
remove CatSPrint from ShellPkg.
...
signed-off-by: jcarsey
reviewed-by: lgrosenb
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12100 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-08 18:22:08 +00:00
jcarsey
1e2b43f1e2
ShellPkg: Added the Ctrl based hot key for hexedit
...
* Add Ctrl based hotkey alternatives to function hotkeys.
* Update help menu for hexedit.
Signed-off-by: kidzyoung
Reviewed-by: jljusten
Reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12082 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-03 17:28:04 +00:00
jcarsey
feccc28a6f
cleanup function and eliminate build error.
...
submitted-by:jcarsey
reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12069 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-01 15:18:19 +00:00
jcarsey
5a2beb745f
ShellPkg: Added the Ctrl based hot key and changed text editor's UI.
...
* Add Ctrl-E hotkey for help
* Add Ctrl based hotkey alternatives to function hotkeys
* Don't show hotkey help on the main screen
* Change the file buffer's row count for display to adjust the new screen format
* Change the edit status bar location, the new edit status bar is in the last line
* Change the location of the edit bar, the new edit input bar is in the last line
Signed-off-by: kidzyoung
reviewed-by: jcarsey
reviewed-by: jljusten
reviewed-by: jiang
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12036 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-20 20:10:45 +00:00
jcarsey
5ddca3b91b
fix issue about slashes on end of comment line.
...
signed-off-by:jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12003 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-11 14:32:34 +00:00
jcarsey
4d0a4fcefe
Move the 2 functions associated with reading whole lines at a single time from the shell command (internal) library to the ShellLib (external) library.
...
signed-off-by: jcarsey
reviewed-by: lgrosenb
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12000 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-06 22:28:36 +00:00
jcarsey
ab94587a7d
This refactors 3 functions out of ShellCommandLib and puts them into a new library (but as 2 functions instead of 3). This allows for users outside of the shell itself to have access to these functions.
...
1) Remove the 3 functions out of the shell's internal library (ShellCommandLib)
2) Add a new library class (PathLib)
3) Add an instance of this class (BasePathLib)
4) Change all internal shell callers to use this new library class.
signed-off-by: jcarsey
reviewed-by: jljusten
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11936 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-30 22:58:53 +00:00
jcarsey
f1518f6970
add fixes for code verification happyness.
...
signed-off-by: jcarsey
reviewed-by: jljusten
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11935 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-30 22:25:46 +00:00
jcarsey
366f81a016
Clarify that the shared variables of the shell protocols are properly named.
...
This removes the non-shared gEfiShellProtocol and gEfiShellParametersProtocol and renames the shared version to those names.
This removes the m-versions of those protocol pointers.
signed-off-by: jcarsey
reviewed-by: darylm503
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11900 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 21:04:22 +00:00
jcarsey
92a5447eda
replace protocol presence ASSERTs with error returns.
...
signed-off-by: jcarsey
reviewed-by: lgrosenb
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11899 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 20:33:13 +00:00
jcarsey
35f26e73cc
replace assert with error.
...
signed-off-by: jcarsey
reviewed-by: lgrosenb
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11897 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 20:28:23 +00:00
jcarsey
03131de30e
Make sure size is correct.
...
signed-off-by: jcarsey
reviewed-by: lgrosenb
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11896 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 20:27:29 +00:00
jcarsey
8bd282bee9
allow for failure return when called without a shell present.
...
signed-off-by: jcarsey
reviewed-by: lgrosenb
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11894 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 16:45:41 +00:00
ydong10
72c8a89a65
Add check code to avoid access violation.
...
Signed-off-by: ydong10
Reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11873 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-23 01:26:06 +00:00