Commit Graph

16 Commits

Author SHA1 Message Date
lgao4 63d55bb98a Replace BufToHexString by UnicodeValueToString
Replace HexStringToBuf by StrHexToUint64

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8034 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-08 00:56:51 +00:00
eric_tian d5893e0b04 fix the bug of calculating subnetmask prefix length. It is a regression issue, which incorrectly take "&" operation as "&&"
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7639 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-24 07:57:25 +00:00
jji4 01a5c99447 use the GUIDed versions of events listed below: EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE and EVT_SIGNAL_EXIT_BOOT_SERVICES
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7420 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 11:09:53 +00:00
ywu21 55a64ae0f4 unified "iSCSI" in all comments
add . at the end of lines
fix 2 file header issues and so on

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7256 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-13 08:44:22 +00:00
ywu21 c5de0d5599 1) delete unused parameter from IScsiCHAPOnRspReceived ()
2)Correct one parameter mistake in IScsiFormCallback ()
3)Add OPTIONAL  in IScsiDriverBindingStop ()
4)delete unused parameter from IScsiCheckOpParams ()
5) fix 30+ [in  out]  issues


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7021 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-14 12:25:48 +00:00
ywu21 963dbb3001 1)update function header coding style issue
change Some unexpected error happened.    to Other errors as indicated.
2) delete unused parameter in IScsiConfigFormInit()
3) correct IN OUT mistake in IScsiSessionInit ()
4)roll back one update for Piece of code in IScsiDhcp.c around line 99 on FieldIndex 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7013 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-12 07:03:44 +00:00
ywu21 036befaf11 delete redundant **/
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6972 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 06:31:56 +00:00
ywu21 1055b68d04 1 update function header
2 update file header 
3 correct some expression: Non-Boolean comparisons must use a compare operator 
4 corrent some variable naming 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6960 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:58:26 +00:00
lgao4 ac7e320cb8 Remove NibbleToHexChar() function from BaseLib
Move IsHexDigit, BufToHexString, HexStringToBuf from BaseLib to MdeModulePkg IfrSupportLib. The reason is:
1) IsHexDigit function provides the logic to check Hex Digit and convert it to Decimal value, which is required by IScsi LUN and HII user input. But this logic is not provided by any functions in MdeLib. So, it can't be deleted. It is moved to IfrSupportLib.
2) BufToHexString function converts a array of buffers to hex string. If the buffer length is less than sizeof (UINT64), it can be directly replaced by UnicodeValueToString(). But HII modules may use BufToHexString to convert the buffers whose length > sizeof (UINT64). For example:
.\MdeModulePkg\Universal\HiiDatabaseDxe\ConfigRouting.c line 201, 1148
.\Universal\SetupBrowserDxe\Setup.c line line 1457, 1503
Like this case, it is not easy to use UnicodeValueToString to replace BufToHexString. So, BufToHexString is still kept. Because such usages are in HII modules, this function is moved to IfrSupportLib. 
3) HexStringToBuf is moved to IfrSupportLib. The reason is similar to BufToHexString.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6782 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-01 02:32:12 +00:00
jji4 fe1e36e550 Patch to remove STATIC modifier. This is on longer recommended by EFI Framework coding style. All duplicated symbols has been renamed accordingly.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6296 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-30 06:05:06 +00:00
vanjeff e53a6ea90e remove EFI_EVENT_ alias, replace them with EVT_
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5813 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 07:42:38 +00:00
qwang12 36fe40c2ea 1) Add BufToHexString, HexStringToBuf and IsHexDigit to BaseLib.
2) Remove the duplicated functions implementation  from the modules that reference these APIs 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5283 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-23 05:30:08 +00:00
eric_tian 12618416ec [Description]
change the old code style to comply with Doxgen format
[Impaction]
add comments for every function
[Reference Info]
add comments to achieve the highest standard of code quality matrix

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5079 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-17 08:28:51 +00:00
jljusten 7c3eaa27b6 edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c:
Resolve warning from gcc. ('Digit' variable may be uninitialized)


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4839 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 19:33:19 +00:00
vanjeff e48e37fce2 Use Mde library and definition instead of some native definitions in NetLib, to simply network library.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4693 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-14 09:40:22 +00:00
eric_tian 7a444476b4 move iscsi driver into network directory, and change its name to comply with name convention.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4612 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-22 08:07:35 +00:00