Commit Graph

22 Commits

Author SHA1 Message Date
Michael Kinney 462a3eba8f Nt32Pkg/WinNtSimpleFileSystemDxe: Fix ASSERT() parsing '\'
https://bugzilla.tianocore.org/show_bug.cgi?id=331

If Nt32 is built using UEFI Shell from the ShellPkg sources,
an ASSERT() is generated when a single '\' character is
entered at the shell prompt.

The WinNtSimpleFileSystemDxe module GetNextFileNameToken()
function breaks a file path up into tokens, but it does not
handle the case where a FileName ends in a '\' character.
It returns an empty string instead of NULL.  The fix is
to set *FileName to NULL if the remaining file path is an
empty string.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
2017-01-10 12:35:39 -08:00
Dong, Eric 3643e8e70d Nt32Pkg WinNtSimpleFileSystemDxe: Correct file length.
In GetInfo interface, current code copy real file name buffer
with full path file length. It should use real file name
length. This patch fix this error.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
2016-10-11 10:17:25 +08:00
Ruiyu Ni 521465d218 Nt32Pkg/WinNtSimpleFileSystemDxe: Fix memory leak
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19513 6f19259b-4bc3-4df7-8a09-765794883524
2015-12-24 06:30:55 +00:00
Jiamin Ma f66a43b26e We enabled X64 native version NT32, and made it works on Windows 7 X64 OS.
Signed-off-by: Jiamin Ma <mjmthy@gmail.com>
Reviewed by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed by: Liming Gao <liming.gao@intel.com>
Reviewed by: Jiewen Yao <jiewen.yao@intel.com>


git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14766 6f19259b-4bc3-4df7-8a09-765794883524
2013-10-12 06:31:55 +00:00
niruiyu 82b760433d Correct the code to use SIZE_OF_EFI_FILE_INFO instead of sizeof (EFI_FILE_INFO) to fix a bug when creating a file/directory with single char as file name in root directory.
Signed-off-by: niruiyu
Reviewed-by: jcarsey

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12728 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-17 01:59:30 +00:00
jcarsey b80022da3b Correct incoming buffer size comparison to the incoming buffer, not the existing buffer.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11344 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-04 16:22:15 +00:00
ydong10 41e9426b3f Refile code to make code following the UEFI spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10942 6f19259b-4bc3-4df7-8a09-765794883524
2010-10-15 06:50:55 +00:00
ydong10 f515069c19 Fixed update file time error problem.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10913 6f19259b-4bc3-4df7-8a09-765794883524
2010-10-09 02:46:37 +00:00
hhtian 8f2a5f8012 Update the copyright notice format
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10436 6f19259b-4bc3-4df7-8a09-765794883524
2010-04-28 12:24:39 +00:00
mdkinney 5b368e7d6c Fix ICC build failures
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10324 6f19259b-4bc3-4df7-8a09-765794883524
2010-03-31 19:20:14 +00:00
qhuang8 49b3b3ab26 Don't calculate the directory size and the caller of EFI_FILE protocol can calculate that for better UI.
The enhancement algorithm to calculate directory size (Edk r2583) is incorrect because SetPosition() does not allow other arguments other than 0, causing current file cursor is lost. 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9713 6f19259b-4bc3-4df7-8a09-765794883524
2010-01-12 10:32:47 +00:00
qhuang8 c0cf06d6da Use UEFI EFI_FILE_PROTOCOL to replace EFI_FILE
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9300 6f19259b-4bc3-4df7-8a09-765794883524
2009-09-22 02:48:55 +00:00
gikidy 2bda59e494 Fix Winnt file system will fail to read() a root "\" after call open().
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8725 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-02 08:52:32 +00:00
vanjeff 9485089dd5 fixed one bug causing "sct -u" failure when running at twice or more times.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8622 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-22 07:55:37 +00:00
mdkinney a00ec39b52 Fix ICC compatibility issues
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8616 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-20 17:05:16 +00:00
gikidy 6a729dcaf4 Fix <.><..> can not work correctly on NT32 platform.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8449 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-03 03:11:36 +00:00
qwang12 6394182967 Fix some build error under ICC tool-chain.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6357 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-01 02:50:51 +00:00
jji4 78e570b6f9 Patch to remove STATIC modifier. This is on longer recommended by EFI Framework coding style. All duplicated symbols has been renamed accordingly.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6299 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-30 06:11:42 +00:00
qwang12 4d3840844d In this fix, WinNtSimpleFileSystemOpen only trims the leading and trailing blank space in the input FileName. The previous implementation before this fix trims all the trailing dots including the case for ".\..", which should move the directory up one level.
A new function IsFileNameValid is added to check if input FileName is valid. If the FileName meets the following scenirio, it will be considered to be invalid:
1) There is two "\" in the path. For example, ".\SomePath\\".
2) There is a least one "/" in the path. The reason is that UEFI 2.1 specifcation only mention that ".", ".." and "\" is valid path modifiers.
3) There is more than two continous dots in the path name token. For example, ".\SomePath\....\SomeName.txt".


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4973 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-01 12:35:56 +00:00
klu2 6ae8142848 Modify all file header to follow doxygen format
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4906 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-19 03:23:16 +00:00
qhuang8 6c28f1182f Update to support to produce Component Name and & Component Name 2 protocol based on Feature flag PcdComponentNameDisable & PcdComponentName2Disable.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3993 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-29 11:27:09 +00:00
klu2 068eac814d Add WinNtSimpleFileSystemDxe driver into Nt32Pkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@2782 6f19259b-4bc3-4df7-8a09-765794883524
2007-06-27 06:39:45 +00:00