Commit Graph

215 Commits

Author SHA1 Message Date
ywu21 fa6fb82a0b update file header
update the order of #include "IScsiMisc.h" and #include "IScsiConfig.h" due to one update in IScsiCommon.h

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6958 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:32:55 +00:00
ywu21 530e25f536 update file header
delete IN from 
IScsiPublishIbft (
  IN VOID  
  );

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6956 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:27:58 +00:00
ywu21 d8c0456428 update file header
update function header
deleter IN in parameter of IScsiPublishIbft (
  VOID  
  )

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6955 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:24:11 +00:00
ywu21 7a457422df update file header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6954 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:22:05 +00:00
ywu21 aeb49322e9 update file header
update function header according to <Protocol/ScsiPassThruExt.h>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6953 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:21:12 +00:00
ywu21 753f9e6948 update file header
update function header according to 
#include <Protocol/IScsiInitiatorName.h>
#include <Protocol/ComponentName.h>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6950 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:07:16 +00:00
ywu21 9ece9bd35a change to #include <PiDxe.h> #include <Uefi.h>
delete  unused #include <Protocol/Ip4Config.h>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6948 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:58:26 +00:00
ywu21 fd82de4e69 update file header
update function header according to <Protocol/DriverBinding.h>


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6947 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:34:43 +00:00
ywu21 7551539c88 update file header
update function header
update enum variable definition

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6946 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:30:31 +00:00
ywu21 8e29a12567 update file header
update function header
according coding style requirements:
The enum shall be declared as a typedef with the name 
so update FieldIndex related code for IScsiDhcpExtractRootPath()

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6945 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:21:50 +00:00
ywu21 a4e5d8adef update file header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6944 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:11:13 +00:00
ywu21 d272bf7d03 update file header
update function header
delete useless #include "IScsiConfigNVDataStruc.h"

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6943 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:10:34 +00:00
ywu21 669314e58e update file header
update function header 
correct parameter mistake in IScsiFormCallback(), change KeyValue to QuestionId

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6942 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:07:48 +00:00
ywu21 fab4bd0444 update file header
update function header
update comments for one macro

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6941 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:02:38 +00:00
ywu21 11e0ec6b3c update file header
add function header for IScsiCHAPCalculateResponse()
add function header IScsiCHAPAuthTarget()
update other functions' function headers

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6940 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:01:17 +00:00
ywu21 f69bf3f5bd update file header
update function header 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6939 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 01:57:01 +00:00
jgong5 c6d0ee4b41 Code scrubbing.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6916 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-08 05:09:57 +00:00
ywu21 e492d1bb20 git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6892 6f19259b-4bc3-4df7-8a09-765794883524 2008-12-07 04:45:45 +00:00
mdkinney 50d7ebad92 Change _CR() to BASE_CR() to follow naming convention
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6888 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-06 01:23:24 +00:00
niry 120db52c6d Add comments for functions and fix some coding style issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6885 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-05 23:47:55 +00:00
lgao4 9437f42c6f Add the missing internal header file to pass build
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6880 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-05 15:56:41 +00:00
ywu21 fb89ee51af for 202033
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6879 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-05 11:52:54 +00:00
ywu21 93173f0e3b for 202033
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6878 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-05 11:49:56 +00:00
ywu21 9445163445 change some comment and for 202033
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6877 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-05 11:49:26 +00:00
jji4 d354ab7ff9 1)Global variables have been moved backward ahead of functions.
2)INF comments have been reviewed.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6839 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-04 07:12:25 +00:00
vanjeff 1987397326 Changed the POLL&TIMEOUT timer values from 50ms to 10ms.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6837 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-04 07:00:57 +00:00
gikidy cfc8865f17 Remove some useless EDK_RELEASE_VERSION, EFI_SPECIFICATION_VERSION ,and review VALID_ARCHITECTURES in inf files with DSC file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6818 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-03 09:08:05 +00:00
lgao4 ac7e320cb8 Remove NibbleToHexChar() function from BaseLib
Move IsHexDigit, BufToHexString, HexStringToBuf from BaseLib to MdeModulePkg IfrSupportLib. The reason is:
1) IsHexDigit function provides the logic to check Hex Digit and convert it to Decimal value, which is required by IScsi LUN and HII user input. But this logic is not provided by any functions in MdeLib. So, it can't be deleted. It is moved to IfrSupportLib.
2) BufToHexString function converts a array of buffers to hex string. If the buffer length is less than sizeof (UINT64), it can be directly replaced by UnicodeValueToString(). But HII modules may use BufToHexString to convert the buffers whose length > sizeof (UINT64). For example:
.\MdeModulePkg\Universal\HiiDatabaseDxe\ConfigRouting.c line 201, 1148
.\Universal\SetupBrowserDxe\Setup.c line line 1457, 1503
Like this case, it is not easy to use UnicodeValueToString to replace BufToHexString. So, BufToHexString is still kept. Because such usages are in HII modules, this function is moved to IfrSupportLib. 
3) HexStringToBuf is moved to IfrSupportLib. The reason is similar to BufToHexString.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6782 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-01 02:32:12 +00:00
vanjeff 48bd50c5a1 1. Fixed issue when calculating timeout value in timeout function in MNP module.
2. Added and refine some comments.
3. Enable UefiPxeBc Module to accept all broadcast packets for UDP Read&Write interface.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6781 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-01 01:59:45 +00:00
niry 85511ddf72 Fix coding style issues for Tcp4Dxe driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6774 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-28 08:32:24 +00:00
vanjeff 0891b0a2cb Fixed one bug when calculating timeout value in timeout function for UDP protocol.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6763 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-27 09:46:01 +00:00
jgong5 ed729a0c3c synced function header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6615 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-18 14:30:46 +00:00
jgong5 ce904bae52 synced function header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6608 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-18 13:37:36 +00:00
jgong5 2ff2921247 synced function header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6595 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-18 09:29:44 +00:00
xli24 555e76f83f Refine MdeModulePkg to pass GCC build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6575 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-18 07:01:14 +00:00
niry b6c4ecad36 fix code style issue and add function header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6570 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-18 04:52:51 +00:00
jgong5 f92046412a Scrubbed part of the code.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6548 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-14 09:16:11 +00:00
jgong5 bab52709d8 Scrubbed some code for Udp4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6494 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-13 08:08:44 +00:00
niry 4cda7726e5 sync comments, fix function header, rename variable name to follow coding style.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6481 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-13 03:42:21 +00:00
qhuang8 c6bc765fca Fix ICC build break.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6464 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-12 01:14:36 +00:00
klu2 1232b21473 1, Add <Library/DevicePathLib.h> for all source that use device path utility macros
2, Add DevicePathLib library class to module's INF that use device path utility macros

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6456 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-11 15:42:40 +00:00
jgong5 96e1079fa4 Scrubbed more.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6454 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-11 09:23:25 +00:00
jgong5 5405e9a66b Scrubbed some files for IP4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6447 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-11 02:44:30 +00:00
klu2 5451bd96de 1, Add missing header file reference in source code section
2, Add missing header file for protocol
3, Remove over specific protocol guid reference in INF file.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6400 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-05 06:35:13 +00:00
qwang12 8d00a0f195 Sync in bug fix from EDK I:
1) issue with setup browser and IFR refresh opcode
2) [HII]HIIConfigRoutingExportConfig generate error format of <MultiConfigAltResp>
3) [HII] ConfigRouting->ExtractConfig() will cause overflow
4) [Hii Database] EFI_HII_DATABASE_NOTIFY should be invoked when a string package is created internally when a new String Token is created
5) [PT]HIIConfigAccessProtocolTest fail on NT32uefi
6) Incorrect HII package types in EDK

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6378 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-04 14:28:08 +00:00
qhuang8 30368135ac Update to use DOS format
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6340 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-31 04:40:51 +00:00
qwang12 19b15d6310 Change functional static variable to Global variable. No STATIC modifier is recommended though it is defined in Base.h.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6313 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-31 02:04:40 +00:00
jji4 fe1e36e550 Patch to remove STATIC modifier. This is on longer recommended by EFI Framework coding style. All duplicated symbols has been renamed accordingly.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6296 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-30 06:05:06 +00:00
qwang12 0e549d5be5 Make use of correct format String:
1) UINT64 should use %lx
2) POINTER type should use %p
3) EFI_STATUS should use %r


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6253 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-27 10:13:00 +00:00
qwang12 6c7a807a54 1) Update SetPeiServicesTablePointer's prototype add CONST modifier.
2) Move STRING_REF from MdePkg/Include/Uefi/UefiBaseType.h to IntelFramework/Include/Protocol/FrameworkHii.h.
3) Move RELOFST from MdePkg/Include/Uefi/UefiInternalFormRepresentation.h to IntelFramework/Include/Protocol/FrameworkHii.h.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6166 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-21 05:55:27 +00:00
qwang12 190344219a Remove the unnecessary include, such as PiDxe.h, PiPei.h, Base.h and Uefi.h in header file. The module should include these files before include the Protocol/Ppi/Guid/Library header files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6111 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-14 15:34:00 +00:00
vanjeff 05c0e3cb8a 1. Sync Bug:PXE Boot issue- UefiPxeBc driver currently does not follow PXE Spec
[Root Cause Analysis]
The PXE offer selection in the PXE driver is splitted into two passes and the two passes are required to follow the same flow. However, in current code, there is some difference between the two.
[Solution]
make the second offer selection pass exactly match the first one.

2. Fixed one bug when allocating pool for UDP transmit packet.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5932 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-19 07:12:23 +00:00
jljusten a04ad3f01f MdePkg/Include/Uefi/UefiTcgPlatform.h:
MdePkg/Include/Protocol/TcgService.h:
MdePkg/Include/IndustryStandard/Tpm12.h:
* Remove usage of '#pragma push' unsupported usage which is not
  supported by GCC.

MdeModulePkg/Universal/Network/PxeBcDxe/Pxe_bc_dhcp.c:
* Fix a warning encountered with GCC/IPF when Index2 (as a INT8) is
  used as an index to an array on lines 2020 & 2028.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5905 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 16:53:12 +00:00
vanjeff 2206d5185c remove duplicated code.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5888 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-12 06:05:39 +00:00
vanjeff 3ec64ac503 add param ImageHandle for MnpFlushServiceData().
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5887 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-12 05:36:21 +00:00
vanjeff e21ef3a227 move protocol close process from MnpDriverBindingStart() to MnpFlushServiceData().
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5885 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-12 02:45:02 +00:00
vanjeff ed66e1bc0d clean up the un-suitable ';' location when declaring the functions.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5820 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 09:37:28 +00:00
vanjeff e53a6ea90e remove EFI_EVENT_ alias, replace them with EVT_
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5813 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 07:42:38 +00:00
lgao4 e872988180 remove the unused msa files in MdeModulePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5726 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-25 05:03:29 +00:00
qhuang8 36a975ddbd Fix a minor GUID format issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5709 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-22 04:26:19 +00:00
qhuang8 d3f1611730 Update some module INF files in MdeModulePkg to "UEFI_DRIVER"
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5676 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-18 09:18:44 +00:00
vanjeff b58baf6bd4 In Supported(), try to test open SNP protocol BY_DRIVER instead of using TEST_PROTOCOL.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5601 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-01 08:16:40 +00:00
vanjeff 174f03d2a2 fixed one bug to catch the return status.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5582 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-28 09:33:02 +00:00
lgao4 2a86ff1cb0 Code Scrub for DxeCrc32GuidedSectionExtractLib library instance.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5455 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-11 08:18:17 +00:00
vanjeff 7bce0c5a0e Clean codes per ECC.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5384 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-30 07:20:33 +00:00
vanjeff e234f7c490 [Description]:
Misuse of retransmisson of DHCPDISCOVER in Dhcp4 drive, the root cause is that DHCP doesn't retransmit discover message when timeout.
[Solution]:
 Correct the mechanism for discover message.
[Impaction]:
 Dhcp4Dxe.
[Reference Info]:
 EDK tracker 1150 - Misuse of retransmisson of DHCPDISCOVER in Dhcp4 drive. 



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5366 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-24 08:36:11 +00:00
vanjeff 619eff3f29 clean EBC build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5342 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-12 06:51:09 +00:00
vanjeff a8fb9d68f1 Support EBC for UefiPxeBcDxe module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5330 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-05 02:45:24 +00:00
qwang12 1c574ee4dc Add a type cast of UINT32 to insure that EBC compiler does not report warning of "Integer conversion resulted in a change of sign" when building with -Za option (accept only ANSI/ISO standard C code). 1 << 31 is consider to be a sign change by compiler.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5325 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-04 10:03:44 +00:00
vanjeff 8792362f22 [Description]:
Problem with PXE boot to Windows Server 2008 install. The reason is that UdpRead and UdpWrite interfaces cannot work well with the same UDP instance.
[Solution]
 Use separate instances for UDP Read and UDP write in UefiPxeBC module.
[Impaction]:
 UefiPxeBcDxe and Udp4Dxe module.
[Reference Info]:
 EDK tracker 1133 - Problem with PXE boot to Windows Server 2008 install. 



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5303 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-27 03:34:39 +00:00
vanjeff 7659d0c92f [Description]:
Fixed one bug in PciBus. PciBus doesn't clear the bridges bus number for all the root bridges before scanning any of them.
[Description]:
 The static IP configuration no long works in the EDK 1.04 network package. The cause is that changing the type of EFI_IP4_IPCONFIG_DATA.RouteTable from a variable length array to a pointer is not clean. If the whole structure is read from variable, the pointer is invalid.
[Solution]
Fix the pointer before using it
[Impaction]:
 Ip4ConfigDxe module.
[Reference Info]:
 EDK tracker 1134 - Static IP configuration no long works. 



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5291 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-26 08:16:25 +00:00
qwang12 36fe40c2ea 1) Add BufToHexString, HexStringToBuf and IsHexDigit to BaseLib.
2) Remove the duplicated functions implementation  from the modules that reference these APIs 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5283 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-23 05:30:08 +00:00
eric_tian 356e635c15 [Description]
Memory may leak because the handles in IScsiUpdateDeviceList is not freed if the "iSCSIDeviceList" already exists
[Impaction]
add Free() func to free memory properly.
[Reference Info]
The Handles in IScsiUpdateDeviceList is not freed if the "iSCSIDeviceList" already exists

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5211 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-16 07:14:25 +00:00
eric_tian 12618416ec [Description]
change the old code style to comply with Doxgen format
[Impaction]
add comments for every function
[Reference Info]
add comments to achieve the highest standard of code quality matrix

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5079 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-17 08:28:51 +00:00
eric_tian 5c70cb3285 [Description]
solve the big file transfer issue using ISCSI
[Impaction]
change the control flow on IScsiExecuteScsiCommand  function
[Reference Info]
The original design incorrectly uses a timer (its span is usually 2 seconds) to ensure the timely execution of CMD PDU send by initiator. For example: When initiator delivers a CMD PDU(WRITE command) in which the ExpDataXferLength filed is larger than DataSegmentLength field, according to ISCSI protocol spec, the target will respond it with a R2T PDU which is followed by a sequential DATA-OUT PDUs. In this situation, the original code may loop to deal with the arrival packet until initiator receives a RESPONSE PDU or the timer is expired. This way may cause the bigger file is more likely to fail.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5044 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-11 07:20:05 +00:00
vanjeff fb0b259e4e apply for doxgen format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5038 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-10 08:49:28 +00:00
vanjeff 58bba9401d sync alignment issue on IPF.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4987 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-03 05:58:21 +00:00
vanjeff aa6c4e3c99 fixed bug in stop() function, that made stop() failure.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4986 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-03 05:51:57 +00:00
vanjeff 5c88defe6d remove debug code.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4982 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-02 09:00:43 +00:00
vanjeff 982a9eaea2 enhanced UefiPxeBcDxe to support
1. AutoArp. 2. SendGuid. 3 TftpError. 4. IcmpError. 5. RouteTable. 6. ArpCache.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4981 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-02 08:45:36 +00:00
jljusten b4df501105 edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDriver.c:
* Fix warning with gcc.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4943 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-21 17:45:46 +00:00
eric_tian f2a94e2558 [Description]
solve the x64 exception issue when unloading iSCSI driver
[Impaction]
add some handler for failure branch and prohibit the additional ISCSI INITIATOR NAME PROTOCOL from being installed. 
[Reference Info]
this bug is reported by DELL. it causes an exception in x64 on unloading iscsi driver.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4941 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-21 03:28:56 +00:00
eric_tian e92d66f280 [Description]
fix the wrote data corrupt bug about iscsi
[Impaction]
modify the IScsiGenerateDataOutPduSequence() function in MdeModulePkg.
[Reference Info]
when writing some data from local disk into remote iscsi disk, the data may be corrupt.The root cause is caused by the data out PDU's offset is not created correctly.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4843 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-13 08:35:18 +00:00
jljusten 9cb8724d68 edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiTcp4Io.h:
edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.h:
edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.h:
edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.h:
edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiIbft.h:
edk2/MdeModulePkg/Universal/Network/IScsiDxe/Md5.h:
edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDriver.h:
edk2/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h:
edk2/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h:
  Fix filename case(sensitivity) issues.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4840 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 19:38:08 +00:00
jljusten 7c3eaa27b6 edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c:
Resolve warning from gcc. ('Digit' variable may be uninitialized)


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4839 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 19:33:19 +00:00
jljusten 344177857f edk2/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.h
Fix filename case(sensitivity) issues. (Smbios.h -> SmBios.h)


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4836 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 19:06:05 +00:00
jljusten 12f3a14283 edk2/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c:
Add 'default' for 'switch' block to resolve warning of
  unhandled enum cases from gcc.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4835 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 18:55:40 +00:00
jljusten 9c87ebc0d1 edk2/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcMtftp.c:
Fixed discrepencies between CHAR8* and INT8* which generate
  a warning on gcc.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4834 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 18:48:39 +00:00
jljusten 19d5671c3b edk2/MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.h:
Remove l-value cast which generates warnings on gcc.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4833 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 18:47:09 +00:00
jljusten f71bb8f1e7 edk2/MdeModulePkg/Universal/Network/PxeBcDxe/Pxe_bc_mtftp.c:
edk2/MdeModulePkg/Universal/Network/PxeBcDxe/Ip.h:
edk2/MdeModulePkg/Universal/Network/PxeBcDxe/Bc.h:
  Fix filename case(sensitivity) issues.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4832 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 18:07:42 +00:00
jljusten bd889f3ce5 edk2/MdeModulePkg/Universal/Network/PxeDhcp4Dxe/PxeDhcp4.h:
Fix filename case(sensitivity) issues.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4831 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 17:59:31 +00:00
jljusten c28d408dd8 edk2/MdeModulePkg/Universal/Network/SnpDxe/Nvdata.c:
Fix filename case(sensitivity) issues.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4830 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 17:52:44 +00:00
jljusten eaf343fff2 edk2/MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h:
edk2/MdeModulePkg/Universal/Network/Tcp4Dxe/Udp4Impl.h:
  Fix filename case(sensitivity) issues.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4829 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 17:48:25 +00:00
jljusten cf26afe34c edk2/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c:
Comment out unused STATIC function. (TcpPutUint16)


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4828 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 17:47:00 +00:00
jljusten 24e58768a0 edk2/MdeModulePkg/Universal/Network/Ip4ConfigDxe/Ip4Config.h:
Fix filename case(sensitivity) issues.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4827 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 17:37:39 +00:00
jljusten 5f778b1f69 BaseTools/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Route.h:
BaseTools/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.h:
  Fix filename case(sensitivity) issues.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4826 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 17:33:53 +00:00
vanjeff 7d7a8ea24c fixed one bug in stop(), adding get NicHandle by gEfiArpProtocolGuid.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4815 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-10 08:34:54 +00:00
vanjeff 89e430b0d4 remove debug code.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4814 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-10 06:59:56 +00:00
vanjeff 8d285ec0ce 1. Enabled SetIpFilter() in UefiPxeBcDxe module.
2. Ported Arp() in UefiPxeBcDxe module.
3. Sync tracker: enabled unload() for PxeBcDxe module.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4813 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-10 06:55:15 +00:00
vanjeff ba39e316c9 1. Add EFI LOADED IMAGE DEVICE PATH Protocol in LoadImage() service, per UEFI 2.1b.
2. Update comments for DHCP.transmitreceive().
2. Update UefiPxeBcDxe.inf and PxeBcDxe.inf to assign correct protocol usages.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4758 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-26 08:38:29 +00:00