Commit Graph

205 Commits

Author SHA1 Message Date
jcarsey 0f87f732e9 ShellPkg: Add missing function descriptor comment.
Submitted-by: jcarsey


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12326 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-12 15:34:11 +00:00
jcarsey 6a5aa4d6dc ShellPkg: Add 3 missing function declaration comments and change a function static variable to a file global variable.
Submitted-by: jcarsey
Reviewed-by:  geekboy15a
Reviewed-by:  ydong10

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12317 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-09 16:57:26 +00:00
jcarsey a0cd353dd2 ShellPkg: allow for mm command to properly write PCIe in non-interactive mode.
Submitted-by: jcarsey
Reviewed-by: jljusten
Reviewed-by: marothma



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12299 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-08 16:50:17 +00:00
ydong10 4ff7e37b4f Refine comments and two code style.
Signed-off-by: ydong10

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12263 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-02 08:05:34 +00:00
jcarsey 5d46f17ba7 ShellPkg: fix ShellPrint-functions to allow for escape character to prevent attribute changes.
This allows for the editors to function easily.

signed-off-by: jcarsey
reviewed-by: kidzyoung

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12187 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-23 15:34:23 +00:00
jcarsey d159ab9538 ShellPkg: fix build error when converting INTN to INT32.
signed-off-by: jcarsey
Reviewed-by: lgao4

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12186 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-23 15:32:49 +00:00
jcarsey 382e78c09c ShellPkg: bug fix for edit search/replace function
* Fix the search bug: if word to be searched at the beginning of the line, it can not be found out.

Signed-off-by: kidzyoung
reviewed-by: jcarsey

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12116 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-10 14:48:14 +00:00
jcarsey 848997b59a This adds support for @ prefixed commands in script files.
signed-off-by: jcarsey
reviewed-by: geekboy15a

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12113 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-09 16:33:58 +00:00
jcarsey 573d7e468e remove CatSPrint from ShellPkg.
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12100 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-08 18:22:08 +00:00
jcarsey 1e2b43f1e2 ShellPkg: Added the Ctrl based hot key for hexedit
* Add Ctrl based hotkey alternatives to function hotkeys.
* Update help menu for hexedit.

Signed-off-by: kidzyoung
Reviewed-by: jljusten
Reviewed-by: jcarsey

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12082 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-03 17:28:04 +00:00
jcarsey feccc28a6f cleanup function and eliminate build error.
submitted-by:jcarsey
reviewed-by: lgao4

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12069 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-01 15:18:19 +00:00
jcarsey 5a2beb745f ShellPkg: Added the Ctrl based hot key and changed text editor's UI.
* Add Ctrl-E hotkey for help
* Add Ctrl based hotkey alternatives to function hotkeys
* Don't show hotkey help on the main screen
* Change the file buffer's row count for display to adjust the new screen format
* Change the edit status bar location, the new edit status bar is in the last line
* Change the location of the edit bar, the new edit input bar is in the last line

Signed-off-by: kidzyoung
reviewed-by: jcarsey
reviewed-by: jljusten
reviewed-by: jiang

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12036 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-20 20:10:45 +00:00
jcarsey 5ddca3b91b fix issue about slashes on end of comment line.
signed-off-by:jcarsey

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12003 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-11 14:32:34 +00:00
jcarsey 4d0a4fcefe Move the 2 functions associated with reading whole lines at a single time from the shell command (internal) library to the ShellLib (external) library.
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12000 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-06 22:28:36 +00:00
jcarsey ab94587a7d This refactors 3 functions out of ShellCommandLib and puts them into a new library (but as 2 functions instead of 3). This allows for users outside of the shell itself to have access to these functions.
1) Remove the 3 functions out of the shell's internal library (ShellCommandLib)
2) Add a new library class (PathLib)
3) Add an instance of this class (BasePathLib)
4) Change all internal shell callers to use this new library class.

signed-off-by: jcarsey
reviewed-by: jljusten

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11936 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-30 22:58:53 +00:00
jcarsey f1518f6970 add fixes for code verification happyness.
signed-off-by: jcarsey
reviewed-by: jljusten

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11935 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-30 22:25:46 +00:00
jcarsey 366f81a016 Clarify that the shared variables of the shell protocols are properly named.
This removes the non-shared gEfiShellProtocol and gEfiShellParametersProtocol and renames the shared version to those names.

This removes the m-versions of those protocol pointers.

signed-off-by: jcarsey
reviewed-by: darylm503

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11900 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 21:04:22 +00:00
jcarsey 92a5447eda replace protocol presence ASSERTs with error returns.
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11899 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 20:33:13 +00:00
jcarsey ad7782a47e maintain output attributes.
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11898 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 20:29:23 +00:00
jcarsey 35f26e73cc replace assert with error.
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11897 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 20:28:23 +00:00
jcarsey 03131de30e Make sure size is correct.
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11896 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 20:27:29 +00:00
jcarsey 8bd282bee9 allow for failure return when called without a shell present.
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11894 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 16:45:41 +00:00
ydong10 72c8a89a65 Add check code to avoid access violation.
Signed-off-by: ydong10
Reviewed-by: jcarsey


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11873 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-23 01:26:06 +00:00
jcarsey a9ca068447 restore original information when redirection fails inside a command using the split operator (|).
Signed-off-by: jcarsey
Reviewed-by: darylm503


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11831 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-15 22:25:14 +00:00
mdkinney e118a40b9d Add ABS() macro (Absolute Value) to Base.h in MdePkg
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11819 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-13 20:26:03 +00:00
ydong10 cd8462ea9d Check the buffer allocation result before using it.
Signed-off-by:ydong10
Reviewed-by:jljusten


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11811 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-13 01:44:03 +00:00
jcarsey 420462d0fb remove empty sections in INF files.
signed-off-by: jcarsey
reviewed-by: darylm503

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11769 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-08 18:28:03 +00:00
hhtian 6f18b50d02 update copyright line format
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11759 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-07 08:08:19 +00:00
jcarsey ae69c04736 Verify that Status variable is initialized.
submitted-by: jcarsey
reviewed-by: lgrosenb
reviewed-by: rhale

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11752 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-03 15:51:26 +00:00
andrewfish a7a394a483 Make shell not ASSERT on older versions of EFI. On a Mac if you soft load Hii, DevicePathToText, and ComponentName drivers from edk2, then with this patch the new Shell will run.
Reviewed by: jcarsey



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11719 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-01 02:27:02 +00:00
jcarsey 2e8e9ed5ed Remove ASSERT within Ls for RTC error and associated changes.
TimeDate.c: replace magic number with constant.
Ls.c: use new warning printout string and remove an ASSERT.  also replace magic number with constant.
The UNI file: add new warning printout string.

Signed-off-by: jcarsey
Reviewed-by: geekboy15a
Reviewed-by: lgrosenb


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11703 6f19259b-4bc3-4df7-8a09-765794883524
2011-05-25 22:29:40 +00:00
jcarsey 77dd0c814e Clarify an error in Map command.
Revert a change in Map command that affected some consistent map names being printed correctly.
Fix a library instance mapping in DSC.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11675 6f19259b-4bc3-4df7-8a09-765794883524
2011-05-17 20:32:47 +00:00
jcarsey 82571fb5d1 add support to easily remove profiles and shell levels. the libraries will not do anything (but no longer fail), if the PCDs are changed to remove their functionality.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11666 6f19259b-4bc3-4df7-8a09-765794883524
2011-05-16 22:12:20 +00:00
jcarsey 4880c2c94d added support for -i and -o for HII based configurations.
added support for all EFI_DRIVER_CONFIGURATION(2) based configurations.
added support for display of all configurable handles.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11665 6f19259b-4bc3-4df7-8a09-765794883524
2011-05-16 21:08:34 +00:00
mdkinney edd88d5a94 Clean up DEC files:
1) Remove section header comment blocks that do not provide any information
2) Combine PCDs listed in multiple sections into a single section that supports multiple PCD types to reduce maintenance overhead
3) Remove ModuleTypeList comments from [Includes], [Protocols], [Ppis], and [Guids] sections that do not properly describe the module type restrictions.
4) Clean up formatting of GUID structure declarations
5) Remove ".common" from section names if they are not required.
6) Order sections consistently as [Defines], [Includes], [LibraryClasses], [Guid], [Ppis], [Protocols], [PcdsFeatureFlag], [PcdsFixedAtBuild], [PcdsPatchableInModule], [PcdsDynamic], and [PcdsDynamicEx]


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11637 6f19259b-4bc3-4df7-8a09-765794883524
2011-05-09 17:51:58 +00:00
mdkinney 53b1c0c144 Fix DEC files so any PCD declared as Dynamic is also declared as DynamicEx
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11623 6f19259b-4bc3-4df7-8a09-765794883524
2011-05-04 21:43:25 +00:00
jcarsey c89ea31f52 fix printout from SmbiosView command.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11605 6f19259b-4bc3-4df7-8a09-765794883524
2011-05-02 16:43:15 +00:00
jcarsey f8d3e6898a check that memory allocation was successful.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11568 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-19 17:54:42 +00:00
jcarsey f20076daaf fix user input validation for time command.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11567 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-19 16:55:51 +00:00
jcarsey a49f6a2f7e fix for word wrapping.
fix for SimpleTextInEx callbacks.
remove an ASSERT.
fix for -noconsolein parameter.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11544 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-15 18:20:40 +00:00
jcarsey 89e8537acf change file global variable to function local.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11539 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-13 23:37:50 +00:00
jcarsey eef1ed4638 rm - refine user input validation to prevent removal of CWD.
change colors of "set" command output.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11538 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-13 23:37:21 +00:00
jcarsey a49016b117 move a function to the correct library.
added "ren" as an alias for "mv"

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11537 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-13 23:35:59 +00:00
jcarsey 10ad7974fe fix misspelling.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11536 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-13 23:35:16 +00:00
jcarsey 6878e7a7be update Bcfg to correctly remove by option index not variable name and add driver order items properly.
update connect and reconnect to account for ignoring the child handle in the connect operation.

update disconnect to output correctly.

hexedit corrected to properly display status bar and title bar and refresh when required.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11525 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-12 21:55:07 +00:00
jljusten 2b578de0b2 ShellPkg: Fix GCC 4.4 build issues
This change fixes various GCC 4.4 build issues
* EFIAPI usage inconsistencies
* multi-character literal warning ('eell')
* Filename case inconsistencies
* Use 'ULL' suffix for integers > 4GB

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11519 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-12 03:18:38 +00:00
jcarsey 411a3c3929 EditTitleBar - Remove ASSERT. Complete display output for Disk and Memory output.
HexEdit      - Add more user input verification.  Fix output display.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11517 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-11 22:00:31 +00:00
andrewfish e0c2cc6f89 Fix Xcode, clang, and ARM build and link issues.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11513 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-07 21:50:16 +00:00
jcarsey 392fa5a63b add user input verification.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11512 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-07 21:44:09 +00:00
jcarsey d8f8021cbe ShellParametersProtocol - remove parsing from within quoted parameters.
Pci - Add missing enumeration in switch statement.
For - Verify parameter before dereferencing.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11511 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-07 17:12:12 +00:00