ydong10
a7e57bd9e0
The format strings are using notations that require UINTNs (like "0x%02x") but a UINT64 type was being passed instead. This patch adds a typecast to UINTN so the print processing works correctly.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eugene Cohen eugene@hp.com
Reviewed-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13597 6f19259b-4bc3-4df7-8a09-765794883524
2012-08-07 00:54:29 +00:00
ydong10
cd0842dc82
Refine code to follow coding style.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13595 6f19259b-4bc3-4df7-8a09-765794883524
2012-08-07 00:44:28 +00:00
ydong10
c85c6de761
Fix build fail for GCC
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13559 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-26 07:44:26 +00:00
ydong10
73c82041dc
Fixed issues:
...
1.Refine the logic about show different attribute.
2.Refine the logic about allocate memory for variable name and data.
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13558 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-26 07:15:31 +00:00
jcarsey
2c46dd239b
ShellPkg: update pci enumeration routine for platforms with multiple pci segments.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eugene Cohen eugene@hp.com
reviewed-by: jaben carsey <jaben.carsey@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13524 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-11 19:08:40 +00:00
ydong10
9d8fa791f5
ShellPkg: Fix recursion when deleting all variables.
...
Signed-off-by: Dong Eric <eric.dong@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13484 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-04 01:14:07 +00:00
jcarsey
60448d9b8d
ShellPkg: Fix en-US characters that are outside the Basic Latin character set range
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud elhaj@hp.com
reviewed-by: Jaben Carsey jaben.carsey@intel.com
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13448 6f19259b-4bc3-4df7-8a09-765794883524
2012-06-12 17:22:19 +00:00
jcarsey
46cb4043a1
ShellPkg: Fix display of 64-bit BARs in PCI dump on 32-bit systems.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eugene Cohen eugene@hp.com
reviewed-by: jaben carsey jaben.carsey@intel.com
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13381 6f19259b-4bc3-4df7-8a09-765794883524
2012-05-30 17:38:23 +00:00
lzeng14
ea4fe84fe5
Update comments in DmpStore.c to be more suitable.
...
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13223 6f19259b-4bc3-4df7-8a09-765794883524
2012-04-27 01:18:41 +00:00
ydong10
8d3000031d
Enhance code to more safely and follow coding style.
...
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13221 6f19259b-4bc3-4df7-8a09-765794883524
2012-04-26 02:00:30 +00:00
lzeng14
187cb3dd8d
Add SMBIOS 2.7.1 support to SmbiosView command.
...
Signed-off-by: lzeng14
Reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13101 6f19259b-4bc3-4df7-8a09-765794883524
2012-03-15 08:29:49 +00:00
rsun3
94020bb40f
Improve robustness when scanning PCI Option ROM.
...
Signed-off-by: rsun3
Reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13095 6f19259b-4bc3-4df7-8a09-765794883524
2012-03-14 03:17:17 +00:00
jcarsey
50b43b1506
ShellPkg: Fix ICC11 build failure.
...
Eliminate SHELL_STATUS and EFI_STATUS mismatch.
Signed-off-by: jcarsey
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13075 6f19259b-4bc3-4df7-8a09-765794883524
2012-03-05 17:51:52 +00:00
andrewfish
4641e70095
Fix type 19 print to match SBMIOS 2.7.
...
Note: Some one should port smbiosview to use the edk2 MdePkg/Include/IndustryStandard/SmBios.h and not carry it's own definitions, that are now out of date.
signed-off-by:andrewfish
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12971 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-31 00:18:25 +00:00
andrewfish
94753eb940
Fix clang compiler warning.
...
signed-off-by:andewfish
reviewed-by:jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12968 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-30 19:06:17 +00:00
jcarsey
8bb7441edd
ShellPkg: Allow for format character strings to be typed in editor without having effect on editor screen.
...
signed-off-by: jcarsey
reviewed-by: leegrosenbaum
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12965 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-30 18:44:41 +00:00
jcarsey
479f85bb72
ShellPkg: add more parenthesis to bcfg command.
...
signed-off-by: jcarsey
reviewed-by: mlmitchel
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12963 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-30 17:31:23 +00:00
jcarsey
cff7bffbb5
ShellPkg: Add support for adding optional data to the bcfg command in debug profile.
...
signed-off-by: jcarsey
reviewed-by: leegrosenbaum
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12961 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-27 18:53:18 +00:00
jcarsey
2e5c97edcd
ShellPkg: Fix handling of empty files in Hexedit
...
Currently hexedit thinks all files that are non-existent (i.e. new) or empty must be a memory error since the pointer is checked, but the file size is not referenced.
Signed-off-by: jcarsey
Reviewed-by: jljusten
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12797 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-29 15:37:04 +00:00
jcarsey
d16efcae82
Shellpkg: Add support for filenames with spaces.
...
This patch changes the file redirection support to allow for quote delimited filenames that contain spaces and updates the edit command to allow spaces in the filename. This also properly fails for attempts to redirect to "" (empty quotes).
signed-off-by: jcarsey
reviewed-by: jliu66
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12685 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-11 16:45:19 +00:00
jcarsey
532691c8ba
ShellPkg: Add checking for memory allocation and pointer returns from functions.
...
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12540 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-14 19:21:13 +00:00
jcarsey
4d10ab79d7
ShellPkg: Add checks for NULL pointers.
...
This adds lots of pointer verification with ASSERTs only used when the condition should be impossible and never for memory allocation.
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12524 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-10 20:36:44 +00:00
jcarsey
ecae51177e
ShellPkg: Add checks for NULL pointers.
...
This adds lots of pointer verification with ASSERTs only used when the condition should be impossible and never for memory allocation.
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12523 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-10 20:32:17 +00:00
lgao4
bca163ff11
Clean up the private GUID definition in module Level.
...
Signed-off-by: lgao4
Reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12394 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-21 01:56:00 +00:00
jcarsey
a0cd353dd2
ShellPkg: allow for mm command to properly write PCIe in non-interactive mode.
...
Submitted-by: jcarsey
Reviewed-by: jljusten
Reviewed-by: marothma
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12299 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-08 16:50:17 +00:00
ydong10
4ff7e37b4f
Refine comments and two code style.
...
Signed-off-by: ydong10
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12263 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-02 08:05:34 +00:00
jcarsey
d159ab9538
ShellPkg: fix build error when converting INTN to INT32.
...
signed-off-by: jcarsey
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12186 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-23 15:32:49 +00:00
jcarsey
382e78c09c
ShellPkg: bug fix for edit search/replace function
...
* Fix the search bug: if word to be searched at the beginning of the line, it can not be found out.
Signed-off-by: kidzyoung
reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12116 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-10 14:48:14 +00:00
jcarsey
573d7e468e
remove CatSPrint from ShellPkg.
...
signed-off-by: jcarsey
reviewed-by: lgrosenb
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12100 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-08 18:22:08 +00:00
jcarsey
1e2b43f1e2
ShellPkg: Added the Ctrl based hot key for hexedit
...
* Add Ctrl based hotkey alternatives to function hotkeys.
* Update help menu for hexedit.
Signed-off-by: kidzyoung
Reviewed-by: jljusten
Reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12082 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-03 17:28:04 +00:00
jcarsey
feccc28a6f
cleanup function and eliminate build error.
...
submitted-by:jcarsey
reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12069 6f19259b-4bc3-4df7-8a09-765794883524
2011-08-01 15:18:19 +00:00
jcarsey
5a2beb745f
ShellPkg: Added the Ctrl based hot key and changed text editor's UI.
...
* Add Ctrl-E hotkey for help
* Add Ctrl based hotkey alternatives to function hotkeys
* Don't show hotkey help on the main screen
* Change the file buffer's row count for display to adjust the new screen format
* Change the edit status bar location, the new edit status bar is in the last line
* Change the location of the edit bar, the new edit input bar is in the last line
Signed-off-by: kidzyoung
reviewed-by: jcarsey
reviewed-by: jljusten
reviewed-by: jiang
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12036 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-20 20:10:45 +00:00
jcarsey
366f81a016
Clarify that the shared variables of the shell protocols are properly named.
...
This removes the non-shared gEfiShellProtocol and gEfiShellParametersProtocol and renames the shared version to those names.
This removes the m-versions of those protocol pointers.
signed-off-by: jcarsey
reviewed-by: darylm503
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11900 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 21:04:22 +00:00
jcarsey
03131de30e
Make sure size is correct.
...
signed-off-by: jcarsey
reviewed-by: lgrosenb
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11896 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-27 20:27:29 +00:00
hhtian
6f18b50d02
update copyright line format
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11759 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-07 08:08:19 +00:00
jcarsey
82571fb5d1
add support to easily remove profiles and shell levels. the libraries will not do anything (but no longer fail), if the PCDs are changed to remove their functionality.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11666 6f19259b-4bc3-4df7-8a09-765794883524
2011-05-16 22:12:20 +00:00
jcarsey
c89ea31f52
fix printout from SmbiosView command.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11605 6f19259b-4bc3-4df7-8a09-765794883524
2011-05-02 16:43:15 +00:00
jcarsey
6878e7a7be
update Bcfg to correctly remove by option index not variable name and add driver order items properly.
...
update connect and reconnect to account for ignoring the child handle in the connect operation.
update disconnect to output correctly.
hexedit corrected to properly display status bar and title bar and refresh when required.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11525 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-12 21:55:07 +00:00
jljusten
2b578de0b2
ShellPkg: Fix GCC 4.4 build issues
...
This change fixes various GCC 4.4 build issues
* EFIAPI usage inconsistencies
* multi-character literal warning ('eell')
* Filename case inconsistencies
* Use 'ULL' suffix for integers > 4GB
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11519 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-12 03:18:38 +00:00
jcarsey
411a3c3929
EditTitleBar - Remove ASSERT. Complete display output for Disk and Memory output.
...
HexEdit - Add more user input verification. Fix output display.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11517 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-11 22:00:31 +00:00
andrewfish
e0c2cc6f89
Fix Xcode, clang, and ARM build and link issues.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11513 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-07 21:50:16 +00:00
jcarsey
392fa5a63b
add user input verification.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11512 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-07 21:44:09 +00:00
jcarsey
d8f8021cbe
ShellParametersProtocol - remove parsing from within quoted parameters.
...
Pci - Add missing enumeration in switch statement.
For - Verify parameter before dereferencing.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11511 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-07 17:12:12 +00:00
jcarsey
f3c5971626
add some parens.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11506 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-05 21:19:39 +00:00
jcarsey
a1d4bfcc3f
add comments to function declarations and definitions and updated to match coding style document.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11505 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-05 20:55:45 +00:00
jcarsey
c5981e3c3d
rename a file.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11504 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-05 20:18:03 +00:00
jcarsey
cbdd109b43
check memory allocations for success.
...
check pointer before access.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11503 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-04 21:41:24 +00:00
jcarsey
4aa4377fda
correct last commit. fix build break for some compilers.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11502 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-04 16:11:07 +00:00
jcarsey
8a0b550b40
fix build break on some compilers.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11501 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-04 16:05:53 +00:00
jcarsey
f2ad804f8b
remove duplicate memory de-allocation.
...
Add function header comment.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11500 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-01 22:19:02 +00:00
jcarsey
ae724571be
Comment's added and fixed.
...
Pointer's checked for NULL before access and after memory allocations.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11499 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-01 22:16:01 +00:00
jcarsey
33c031ee20
pointer verification (not NULL) and buffer overrun fixes.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11459 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-30 19:33:03 +00:00
jcarsey
16751bb43d
remove unused variable.
...
add some parens.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11457 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-30 16:12:42 +00:00
ydong10
4bcb7fe768
Update inf file to follow spec.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11454 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-30 03:40:42 +00:00
jcarsey
980d554e3a
smbiosview - add user input verification.
...
HexEdit/Edit
- More user input verification for HexEdit.
- updated title bar refreshment.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11448 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-29 19:31:18 +00:00
jcarsey
3737ac2bc3
comp - add comments and add input verification
...
bcfg - updated for bugs.
compress - rename for coding standards. add comments.
dblk - add comments, input verification, and a header line
dmem - add comments, add input verification, add system table info
dmpstore - add comments
eficompress - add comments and add input verification
efidecompress - add comments and add input verification
loadpcirom - add comments and more output messages
memmap - add more output to exceed the spec.
mm - move functions, add comments, add input verification.
mode - add comment
pci - add input verification.
SerMode - add comments and add input verification
setsize - add comments and add input verification
setvar - add comments and add input verification
smbiosview - add input verification.
clarify error messages.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11438 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-25 21:22:20 +00:00
jcarsey
2442e62af7
add Edit and Hexedit shared features.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11437 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-25 21:15:26 +00:00
jcarsey
632820d1cf
add Edit and HexEdit commands.
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11436 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-25 21:15:07 +00:00
hhtian
d08fadb0e2
update copyright format
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11153 6f19259b-4bc3-4df7-8a09-765794883524
2010-12-10 15:19:03 +00:00
jcarsey
5d73d92f56
Add "Debug1" profile (all but Edit and HexEdit commands)
...
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11068 6f19259b-4bc3-4df7-8a09-765794883524
2010-11-16 22:36:37 +00:00