Commit Graph

181 Commits

Author SHA1 Message Date
niry dfc1f033ea Add comments for functions.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7039 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-16 02:57:53 +00:00
ywu21 f3e1569dbb it was root caused to be Spec issue instead of code issue. It should be Action instead of * Action.
So roll back formal  change  in IScsiFormCallback ()

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7023 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-15 02:32:28 +00:00
ywu21 c5de0d5599 1) delete unused parameter from IScsiCHAPOnRspReceived ()
2)Correct one parameter mistake in IScsiFormCallback ()
3)Add OPTIONAL  in IScsiDriverBindingStop ()
4)delete unused parameter from IScsiCheckOpParams ()
5) fix 30+ [in  out]  issues


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7021 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-14 12:25:48 +00:00
ywu21 963dbb3001 1)update function header coding style issue
change Some unexpected error happened.    to Other errors as indicated.
2) delete unused parameter in IScsiConfigFormInit()
3) correct IN OUT mistake in IScsiSessionInit ()
4)roll back one update for Piece of code in IScsiDhcp.c around line 99 on FieldIndex 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7013 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-12 07:03:44 +00:00
ywu21 fd6f5e52b1 correct /// usage mistake
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6979 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 09:29:47 +00:00
ywu21 036befaf11 delete redundant **/
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6972 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 06:31:56 +00:00
ywu21 57e6bb7c92 update function header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6971 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 06:29:55 +00:00
ywu21 4cf432deb6 delete #include <Uefi/UefiBaseType.h>
add #include <Uefi.h>
update file header 
update function header

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6970 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 06:21:28 +00:00
ywu21 242354a22e update file header
update function header
update a lot of variable naming
add some function header and adjust function layout


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6969 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 06:18:18 +00:00
ywu21 02aa4e52ed update file header
update function header

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6968 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 06:13:51 +00:00
ywu21 52ed4ff9f8 update file header
update function header 
delete extern CHAR16 NibbleToHexChar(UINT8 Nibble); and use #include <Library/BaseLib.h>
update struct definition format to pass ECC check

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6964 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 04:09:23 +00:00
ywu21 db3e605d07 update file header
update function header


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6963 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 04:04:45 +00:00
ywu21 2dce4b43f5 update file header
move typedef struct _ISCSI_SESSION_CONFIG_DATA ISCSI_SESSION_CONFIG_DATA;  to IScsiMisc.h

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6962 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 04:02:58 +00:00
ywu21 b604547572 update file header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6961 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 04:01:14 +00:00
ywu21 1055b68d04 1 update function header
2 update file header 
3 correct some expression: Non-Boolean comparisons must use a compare operator 
4 corrent some variable naming 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6960 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:58:26 +00:00
ywu21 9fd6fde8b2 update file header
correct one parameter IN Out mistake in IScsiSetInitiatorName ()

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6959 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:34:36 +00:00
ywu21 fa6fb82a0b update file header
update the order of #include "IScsiMisc.h" and #include "IScsiConfig.h" due to one update in IScsiCommon.h

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6958 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:32:55 +00:00
ywu21 530e25f536 update file header
delete IN from 
IScsiPublishIbft (
  IN VOID  
  );

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6956 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:27:58 +00:00
ywu21 d8c0456428 update file header
update function header
deleter IN in parameter of IScsiPublishIbft (
  VOID  
  )

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6955 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:24:11 +00:00
ywu21 7a457422df update file header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6954 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:22:05 +00:00
ywu21 aeb49322e9 update file header
update function header according to <Protocol/ScsiPassThruExt.h>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6953 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:21:12 +00:00
ywu21 753f9e6948 update file header
update function header according to 
#include <Protocol/IScsiInitiatorName.h>
#include <Protocol/ComponentName.h>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6950 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 03:07:16 +00:00
ywu21 9ece9bd35a change to #include <PiDxe.h> #include <Uefi.h>
delete  unused #include <Protocol/Ip4Config.h>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6948 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:58:26 +00:00
ywu21 fd82de4e69 update file header
update function header according to <Protocol/DriverBinding.h>


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6947 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:34:43 +00:00
ywu21 7551539c88 update file header
update function header
update enum variable definition

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6946 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:30:31 +00:00
ywu21 8e29a12567 update file header
update function header
according coding style requirements:
The enum shall be declared as a typedef with the name 
so update FieldIndex related code for IScsiDhcpExtractRootPath()

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6945 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:21:50 +00:00
ywu21 a4e5d8adef update file header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6944 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:11:13 +00:00
ywu21 d272bf7d03 update file header
update function header
delete useless #include "IScsiConfigNVDataStruc.h"

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6943 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:10:34 +00:00
ywu21 669314e58e update file header
update function header 
correct parameter mistake in IScsiFormCallback(), change KeyValue to QuestionId

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6942 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:07:48 +00:00
ywu21 fab4bd0444 update file header
update function header
update comments for one macro

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6941 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:02:38 +00:00
ywu21 11e0ec6b3c update file header
add function header for IScsiCHAPCalculateResponse()
add function header IScsiCHAPAuthTarget()
update other functions' function headers

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6940 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 02:01:17 +00:00
ywu21 f69bf3f5bd update file header
update function header 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6939 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 01:57:01 +00:00
jgong5 c6d0ee4b41 Code scrubbing.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6916 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-08 05:09:57 +00:00
ywu21 e492d1bb20 git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6892 6f19259b-4bc3-4df7-8a09-765794883524 2008-12-07 04:45:45 +00:00
mdkinney 50d7ebad92 Change _CR() to BASE_CR() to follow naming convention
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6888 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-06 01:23:24 +00:00
niry 120db52c6d Add comments for functions and fix some coding style issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6885 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-05 23:47:55 +00:00
lgao4 9437f42c6f Add the missing internal header file to pass build
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6880 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-05 15:56:41 +00:00
ywu21 fb89ee51af for 202033
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6879 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-05 11:52:54 +00:00
ywu21 93173f0e3b for 202033
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6878 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-05 11:49:56 +00:00
ywu21 9445163445 change some comment and for 202033
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6877 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-05 11:49:26 +00:00
jji4 d354ab7ff9 1)Global variables have been moved backward ahead of functions.
2)INF comments have been reviewed.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6839 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-04 07:12:25 +00:00
vanjeff 1987397326 Changed the POLL&TIMEOUT timer values from 50ms to 10ms.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6837 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-04 07:00:57 +00:00
gikidy cfc8865f17 Remove some useless EDK_RELEASE_VERSION, EFI_SPECIFICATION_VERSION ,and review VALID_ARCHITECTURES in inf files with DSC file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6818 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-03 09:08:05 +00:00
lgao4 ac7e320cb8 Remove NibbleToHexChar() function from BaseLib
Move IsHexDigit, BufToHexString, HexStringToBuf from BaseLib to MdeModulePkg IfrSupportLib. The reason is:
1) IsHexDigit function provides the logic to check Hex Digit and convert it to Decimal value, which is required by IScsi LUN and HII user input. But this logic is not provided by any functions in MdeLib. So, it can't be deleted. It is moved to IfrSupportLib.
2) BufToHexString function converts a array of buffers to hex string. If the buffer length is less than sizeof (UINT64), it can be directly replaced by UnicodeValueToString(). But HII modules may use BufToHexString to convert the buffers whose length > sizeof (UINT64). For example:
.\MdeModulePkg\Universal\HiiDatabaseDxe\ConfigRouting.c line 201, 1148
.\Universal\SetupBrowserDxe\Setup.c line line 1457, 1503
Like this case, it is not easy to use UnicodeValueToString to replace BufToHexString. So, BufToHexString is still kept. Because such usages are in HII modules, this function is moved to IfrSupportLib. 
3) HexStringToBuf is moved to IfrSupportLib. The reason is similar to BufToHexString.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6782 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-01 02:32:12 +00:00
vanjeff 48bd50c5a1 1. Fixed issue when calculating timeout value in timeout function in MNP module.
2. Added and refine some comments.
3. Enable UefiPxeBc Module to accept all broadcast packets for UDP Read&Write interface.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6781 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-01 01:59:45 +00:00
niry 85511ddf72 Fix coding style issues for Tcp4Dxe driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6774 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-28 08:32:24 +00:00
vanjeff 0891b0a2cb Fixed one bug when calculating timeout value in timeout function for UDP protocol.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6763 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-27 09:46:01 +00:00
jgong5 ed729a0c3c synced function header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6615 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-18 14:30:46 +00:00
jgong5 ce904bae52 synced function header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6608 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-18 13:37:36 +00:00
jgong5 2ff2921247 synced function header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6595 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-18 09:29:44 +00:00