Commit Graph

5449 Commits

Author SHA1 Message Date
qhuang8 d45fd26026 Fix several code review minor comments:
1.Line 1520, 1525, 1530:Use goto to save Release Lock
2.Line 224: Do not use DEBUG_ERROR, since it is not an error case
3.Scrub the DEBUG () print statement to add DEBUG_PAGE
4.Line 20: Typo of "help cooalese"


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5915 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:28:05 +00:00
vanjeff 04b9f76313 Fixed one bug in consplitter console input Start/Stop functions for those handlers only produce SimpleTextIn and not produce SimpleTextEx protocol.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5914 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 09:55:05 +00:00
jwang36 205564ad9b Fixed HSD201384 & HSD201375
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5913 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 09:42:38 +00:00
vanjeff 299d51fddc remove unnecessary comments introduced by tools.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5912 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 08:00:13 +00:00
vanjeff 1efcc4ae46 remove unnecessary comments introduced by tools from MdePkg. The regular express is "//^p//[ ]Include[ ]common[ ]header[ ]file[ ]for[ ]this[ ]module[.]^p//"
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5911 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 07:46:17 +00:00
qwang12 91496a547d Update the comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5910 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 03:02:04 +00:00
qwang12 6c8e1cee0e Update the comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5909 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 03:01:41 +00:00
qwang12 eb91f2f8a2 Update the comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5908 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 03:01:18 +00:00
qwang12 a70c0fd846 Add VA_END to end the VA_START.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5907 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 02:30:24 +00:00
qwang12 46fee0d7b6 Remove the unnecessary spin_lock protection around CoreUnloadImage. There is almost zero possibility for this reentrancy issue here. With this change, we also keep EDK 2 and EDK core's CoreUnloadImage consistent with each other.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5906 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 02:20:24 +00:00
jljusten a04ad3f01f MdePkg/Include/Uefi/UefiTcgPlatform.h:
MdePkg/Include/Protocol/TcgService.h:
MdePkg/Include/IndustryStandard/Tpm12.h:
* Remove usage of '#pragma push' unsupported usage which is not
  supported by GCC.

MdeModulePkg/Universal/Network/PxeBcDxe/Pxe_bc_dhcp.c:
* Fix a warning encountered with GCC/IPF when Index2 (as a INT8) is
  used as an index to an array on lines 2020 & 2028.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5905 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 16:53:12 +00:00
lgao4 bab3f2d3ac Fix build error
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5904 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 12:53:15 +00:00
eric_tian 11074aabe1 CoreHandleProtocol function description should be corrected.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5903 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 08:02:57 +00:00
qwang12 b436ed893b Only generate the random GUID if a package list already exist in the database.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5902 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 07:56:40 +00:00
eric_tian 1947c70c3e Merge the global data in ExecData.c to Event.c
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5901 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 07:53:15 +00:00
lgao4 14085cf071 Fix the build bugs for these three files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5900 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 07:37:57 +00:00
eric_tian c18f12d375 Comments for CoreInitializeMemoryServices should be updated
Comments for CoreInitializeGcdServices should be updated.
Comments for CoreInitializeEventServices should be updated.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5899 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 07:35:17 +00:00
eric_tian 5f3232d7e8 The file name Exec.h contains UEFI Event support functions and structure. But its file name is not very meaningful and we can consider renaming it.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5898 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 07:22:44 +00:00
eric_tian f6d7003d5f move BUGBUG comments and add some comments to comply with Spec
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5897 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 07:13:42 +00:00
qwang12 bc22641609 Framework code may call PreparePacckage with NULL GUID and both IFR and String Packages.
PackageList = PreparePackages (2, NULL, IfrPack, StringPack);

    mHii->NewPack( mHii, PackageList, &HiiHandle );

Framework HII database make use of the formset GUID as ID to retrieve String using 

EFI_STATUS
GetStringFromToken (
  IN  EFI_GUID                  *ProducerGuid,
  IN  STRING_REF                Token,
  OUT CHAR16                    **String
  )

Update the code to cache the Formset GUID too.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5896 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 06:47:08 +00:00
klu2 8335866b0b Correct module type for library UefiBootServicesTableLib and UefiRuntimeServicesTableLib.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5895 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 06:44:15 +00:00
eric_tian f944ec32e7 follow up code review
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5894 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 06:13:42 +00:00
eric_tian f73e0ad215 follow up code review
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5893 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 06:01:21 +00:00
eric_tian 55f298c3a3 follow up the comments from code review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5892 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 05:22:09 +00:00
eric_tian 1349236994 follow up the comments from code review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5891 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 05:19:25 +00:00
klu2 9edc73ada4 Code clean up.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5890 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 02:12:35 +00:00
qhuang8 33629bba69 Fix the bug in GlueLib that we should depend on the gRT revision to use the proper report status code function.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5889 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-12 07:54:40 +00:00
vanjeff 2206d5185c remove duplicated code.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5888 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-12 06:05:39 +00:00
vanjeff 3ec64ac503 add param ImageHandle for MnpFlushServiceData().
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5887 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-12 05:36:21 +00:00
qwang12 bc3fc71a37 Change the status code to EFI_NOT_FOUND for Framework Hii's GetGlyph if EFI_WARN_UNKNOWN_GLYPH is return from GetGlyph i.e. no matching font found and UNKNOWN glyph is returned.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5886 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-12 03:01:01 +00:00
vanjeff e21ef3a227 move protocol close process from MnpDriverBindingStart() to MnpFlushServiceData().
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5885 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-12 02:45:02 +00:00
qwang12 1e52ce5da8 Delete the unused PEIMs. EDK 2 PEI core now support this feature by gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkFvHobCompatibilitySupport.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5884 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-12 01:56:56 +00:00
qhuang8 7899b79715 Remove the internal CoreCreateProtocolNotifyEvent() in DxeCore, for UefiLib provide the similar function EfiCreateProtocolNotifyEvent(). DxeCore can use that library function.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5883 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-12 01:12:31 +00:00
qhuang8 a8aba574e7 Fix a typo in ReadMe.txt.
We should use -p EdkShellPkg\EdkShellPkg.dsc to specify the DSC file.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5882 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-12 01:05:42 +00:00
vanjeff 835849540d remove '../' from Base Library.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5878 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-11 09:12:14 +00:00
vanjeff 3ec9bc1557 move and rename it
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5877 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-11 09:08:12 +00:00
vanjeff 5dedabbb4e Clean up BaseIoLibIntrinsic according to review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5876 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-11 08:59:52 +00:00
qwang12 36e90351bd Pass GCC build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5875 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-11 06:54:24 +00:00
qwang12 2b589f71a7 // EFI_FORM_BROWSER_PROTOCOL_GUID has been changed from the one defined in Framework HII 0.92 as the
// Setup Browser protocol produced by HII Thunk Layer support the UEFI IFR and UEF String Package format.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5874 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-11 02:25:52 +00:00
qwang12 775bebc372 GCC clean.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5873 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-11 02:25:30 +00:00
qwang12 d4589db67b // EFI_HII_PROTOCOL_GUID has been changed from the one defined in Framework HII 0.92 as the
// Framework HII protocol produced by HII Thunk Layer support the UEF IFR and UEFI String Package
// format.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5872 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-11 02:23:31 +00:00
qhuang8 43d2502010 Append the change log for the non-backward compatibility change in Edk r5869.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5871 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 16:13:07 +00:00
qhuang8 f0d5cbb66a Update the usage of ALIGN_VARIABLE for the interface change.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5870 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 16:05:24 +00:00
qhuang8 3fef0f51d8 1. Add new macro: ALIGN_VALUE to round up a value to the next boundary of a given alignment.
2. Update ALIGN_POINTER to use the new macro
3. Drop the second parameter of ALIGN_VARIABLE for simplicity. It can also directly use the new macro ALIGN_VALUE. 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5869 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 16:00:20 +00:00
qhuang8 af1b10362d 1. Rename gRT in GlueLib to avoid collision with EfiDriverLib
2. Add the extra parameter of PciCfg in the new PeiLibPciCfgModify() to keep the parameter list the same as the PciCfg->Modify(). PciCfg is just a place holder.
3. Allow platform develop to set EDKII_GLUE_PciExpressBaseAddress value in build option.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5868 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 12:53:36 +00:00
lgao4 ffe084ee76 1. Add ASM source files directory into its Include path.
2. Change the output directory for ASL files to the subdirectory in order to avoid the same file names. 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5867 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 06:51:00 +00:00
qwang12 fa3c419fec Fix a bug by adding CoreReleaseProtocolLock.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5866 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 06:30:40 +00:00
qhuang8 3b6ffb6a13 Add EFIAPI modifier for all GCD services APIs
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5865 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 03:25:49 +00:00
eric_tian c57da111f7 cleanup some comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5864 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 07:11:51 +00:00
eric_tian e3a7917f2e fix build issue
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5863 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 06:45:35 +00:00