Commit Graph

370 Commits

Author SHA1 Message Date
xli24 7698f336b7 Refine include file for PCI Platform Protocol, and update C source code accordingly.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8614 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-19 09:35:07 +00:00
lgao4 8bcd1d7003 Retire FrameworkDevicePath header file. It is not defined in framework spec. And it is not used by EDKII modules.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8592 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-18 05:21:54 +00:00
lgao4 920d2c23a1 Update header file comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8583 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-17 08:46:49 +00:00
jcarsey f391357d3c git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8576 6f19259b-4bc3-4df7-8a09-765794883524 2009-06-16 13:16:06 +00:00
rsun3 79a0adf30a Update comments. Remove a definition not defined in the Framework SMM CIS spec 0.90.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8575 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-16 09:45:46 +00:00
rsun3 9f6f953491 Update comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8574 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-16 08:33:16 +00:00
rsun3 efccebcfe0 Update comment in SMM Library class include file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8573 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-16 06:00:41 +00:00
rsun3 b530f741ba Comment update.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8572 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-16 05:28:57 +00:00
rsun3 6f4d7557e4 Correct the GUID for EFI_FORM_BROWSER_COMPATIBILITY_PROTOCOL_GUID.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8571 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-16 03:24:26 +00:00
lgao4 d84d730a2c Retire DataHubProducer header file
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8541 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-12 09:16:31 +00:00
jcarsey fa62b7ce53 fix comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8524 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-10 18:59:22 +00:00
jcarsey 7781c1991b fix comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8523 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-10 18:57:33 +00:00
jcarsey ec87b52aaf updated comment
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8514 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-10 18:03:50 +00:00
jcarsey 05ef5a8821 updated comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8513 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-10 17:51:13 +00:00
jcarsey 689aa0d6b7 updated comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8512 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-10 17:46:17 +00:00
jcarsey 38db75072f git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8511 6f19259b-4bc3-4df7-8a09-765794883524 2009-06-10 17:41:25 +00:00
jcarsey f45527ebee git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8510 6f19259b-4bc3-4df7-8a09-765794883524 2009-06-10 17:18:09 +00:00
jcarsey b4124f44f7 git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8509 6f19259b-4bc3-4df7-8a09-765794883524 2009-06-10 17:07:59 +00:00
lgr a6981ffc67 editor was set for tabs instead of spaces on prev chkin
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8486 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-05 22:50:33 +00:00
lgr 2f09f4bd45 Per EdkII IntelFrameworkPkg code review instructions, add comments before each gui, ppi & protocol with path to the corresponding .h file
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8485 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-05 22:25:43 +00:00
mdkinney 9226e4ee0a Clean up CSM related include files to match specification
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8469 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-04 22:49:59 +00:00
jljusten 693c4e024f Fix minor typos in comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8454 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-03 05:59:40 +00:00
mdkinney 2c236ad7bc 1) Move gEfiStatusCodeDataTypeDebugGuid from the IntelFrameworkPkg to the IntelFrameworkModulePkg. This GUID is not defined in the Framework Specifications, so it is part of the implementation. This GUID is used to pass DEBUG() information to the Status Code Protocol and PPI. This GUID is now defined in IntelFrameworkModulePkg/Include/Guid/StatusCodeDataTypeDebug.h. The GUID definition was also moved from the DEC file in the IntelFrameworkPkg to the IntelFrameworkModulePkg.
2) Move data structure use to pass DEBUG() info to Status Code Protocol and Status Code PPI from IntelFrameworkModulePkg.Include/DebugInfo.h into the new GUID file IntelFrameworkModulePkg/Include/Guid/StatusCodeDataTypeDebug.h

3) Delete IntelFrameworkModulePkg/Include/DebugInfo.h because all the content is now in IntelFrameworkModulePkg/Include/Guid/StatusCodeDataTypeDebug.h

Module Impacts
==============
1) Modules that currently use #include <DebugInfo.h> must be updated to #include <Guid/StatusCodeDataTypeDebug.h>.  
2) Modules that currently use #include <Guid/StatusCodeDataTypeId.h> and don't #include <DebugInfo.h> will have to add #include <Guid/StatusCodeDataTypeDebug.h>.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8432 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-01 21:18:12 +00:00
mdkinney 0ca9ea41f9 Remove the GUID declared as gEfiStatusCodeDataTypeErrorGuid and EFI_STATUS_CODE_DATA_TYPE_ERROR_GUID because it is not present in the Intel Framework Specifications.
Remove the GUID declared as gEfiStatusCodeDataTypeProgressCodeGuid and EFI_STATUS_CODE_DATA_TYPE_PROGRESS_CODE_GUID because it is not present in the Intel Framework Specifications.




git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8428 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-01 19:59:53 +00:00
mdkinney 810881f08f Remove the GUID declared as gEfiStatusCodeDataTypeAssertGuid and EFI_STATUS_CODE_DATA_TYPE_ASSERT_GUID because it is not present in the Intel Framework Specifications.
Any usage of this GUID should be replaced with gEfiStatusCodeSpecificDataGuid or EFI_STATUS_CODE_SPECIFIC_DATA_GUID.  The Intel Framework Specification Status Codes 0.92 defines the method for producing a status code for an ASSERT() condition by using an error code of EFI_SW_EC_ILLEGAL_SOFTWARE_STATE.  Any consumer of produced status codes should evaluate the error code to determine if it is an ASSERT() type, and then know how to interpret the extended data as EFI_DEBUG_ASSERT_DATA.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8426 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-01 18:41:05 +00:00
mdkinney d4764d1f64 Remove the GUID declared as gEfiStatusCodeDataTypeExceptionHandlerGuid and EFI_STATUS_CODE_DATA_TYPE_EXCEPTION_HANDLER_GUID because it is not present in the Intel Framework Specifications.
Any usage of this GUID should be replaced with gEfiStatusCodeSpecificDataGuid or EFI_STATUS_CODE_SPECIFIC_DATA_GUID.  The Intel Framework Specification Status Codes 0.92 defines the method for producing a status code with a CPU exception record.  The subclass of the error code defines the type of processor exception.  Any consumer of produced status codes should evaluate the error code to determine if it is a CPU exception type, and then know how to interpret the extended data as a CPU exception record.




git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8425 6f19259b-4bc3-4df7-8a09-765794883524
2009-06-01 18:18:52 +00:00
eric_tian 57b201b843 update the file description of PrintXY and AsciiPrintXY. and also refine the implementation to return the number of actual printed characters.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8373 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 10:04:21 +00:00
eric_tian 619e4c06c3 update the implementation of InternalPrintGraphic to reflect the number of actual printed character
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8370 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 09:27:29 +00:00
gikidy 0f899407a3 Update revision reference tag.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8369 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 09:04:03 +00:00
gikidy 470d0b274c Synchronize code with specs.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8367 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 06:11:39 +00:00
gikidy 534b8251cc Synchronize code with specs.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8366 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-21 06:08:25 +00:00
mdkinney a5a3a29c4c Clarify BuildCvHob() API in HobLib to state that this function will ASSERT() if the platform does not support Capsule Volume HOBs. This allows PI implementations to ASSERT() and Framework implementations to provide a full implementation of this API.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8279 6f19259b-4bc3-4df7-8a09-765794883524
2009-05-09 01:48:15 +00:00
tding1 f55d5b188e update the spec file name in header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8201 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-29 03:27:06 +00:00
tding1 253f983a4b update the header to point to Smm Cis v1.1 to cover the definition of MP API
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8200 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-29 03:10:31 +00:00
lgao4 fcd1a8457c Retire framework IfrSupportLib and HiiLib, which will be replaced by new designed Hii library in MdeModulePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8150 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-22 07:50:41 +00:00
jchen20 8bd2aa7503 retire AcpiTableStorage.h and implement the gEfiAcpiTableStorageGuid with a fixed at build PCD
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8106 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-17 01:58:21 +00:00
eric_tian d46dfe99e5 remove the gEfiLoadPeImageProtocolGuid and replace all references for it with BasePeCoffLib.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8095 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-16 02:43:41 +00:00
qhuang8 e115460bd7 sync Print functions with MdePkg counterpart.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8093 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-15 14:32:10 +00:00
gikidy ef1ad620f0 Data field added for long physical blocks.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8003 6f19259b-4bc3-4df7-8a09-765794883524
2009-04-02 01:47:26 +00:00
rsun3 36fd07d3c5 Retire FrameworkHiiLib library class. Remove FrameworkHiiLib library instance now and will be added later if necessary.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7989 6f19259b-4bc3-4df7-8a09-765794883524
2009-03-31 02:42:08 +00:00
gdong1 4af947e5ca Add PCD to save size.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7932 6f19259b-4bc3-4df7-8a09-765794883524
2009-03-24 08:43:54 +00:00
gdong1 5547062df5 Fixed two K8 report issue
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7929 6f19259b-4bc3-4df7-8a09-765794883524
2009-03-24 06:53:26 +00:00
gdong1 9205b2d766 Update the header file coding style (alignment, comment, etc.)
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7893 6f19259b-4bc3-4df7-8a09-765794883524
2009-03-16 10:29:27 +00:00
xli24 6bfc419e70 Fix incorrect function headers of I/O Lib.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7806 6f19259b-4bc3-4df7-8a09-765794883524
2009-03-05 07:22:26 +00:00
qhuang8 2f78ec7a7a Add PeiHobLibFramework instance to provide a real implementation for BuildCvHob()
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7785 6f19259b-4bc3-4df7-8a09-765794883524
2009-03-03 14:21:58 +00:00
qhuang8 1088908eb2 Sync with MdePkg counterpart
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7665 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-25 03:00:11 +00:00
lgao4 d71479ca16 Add the missing definitions in framework Pci Host bridge specification.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7543 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-19 08:36:23 +00:00
xli24 dcbb35eb6c Add comments in DSC files to explain the function and design of components section.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7490 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 08:58:47 +00:00
tding1 700a786952 update comments to allign with spec
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7436 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-05 08:42:01 +00:00
gdong1 1b74e1c7ff Fix FreePoll() bugs in some places.
Removed the dependency to MdeModulePkg in the HiiLibFramework
Removed EDK_RELEASE_VERSION and EFI_SPECIFICATION_VERSION in the Framework inf file.
other coding style changes


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7218 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-08 09:37:30 +00:00
lgao4 779808545d Fix VS2005 build error
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7181 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-05 02:20:16 +00:00
qwang12 3c49d30629 Add a comment to describe the reason why the GUID for HII protocol is not matched between code and HII spec 0.92 .
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7177 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-04 08:41:24 +00:00
gdong1 409f118c84 Replace some CopyMem() for GUID copy with CopyGuid().
Replace some gBS->FreePool() with FreePool().
Add EFIAPI modifier.
Removed inconsistent OPTIONAL modifier.
Coding style issue fix.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7176 6f19259b-4bc3-4df7-8a09-765794883524
2009-01-04 08:06:07 +00:00
gdong1 49a049e6d2 correct some coding style issues.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7112 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-24 02:42:57 +00:00
gdong1 a45eb10f26 make the comment parameter be consistent with the function parameter.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7109 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-24 01:33:25 +00:00
gdong1 a387653db2 correct some code style issue
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7104 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 10:25:33 +00:00
gdong1 f7cf806ee9 Remove the BUGBUG modifier in the comment
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7103 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 09:47:58 +00:00
gdong1 e681318906 In Comment, the parameter name does NOT consistent with function parameter name
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7102 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 09:45:45 +00:00
gdong1 dddb694d3e correct the comments style.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7092 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-23 03:12:54 +00:00
gdong1 cd15d4715c git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7064 6f19259b-4bc3-4df7-8a09-765794883524 2008-12-17 09:05:42 +00:00
qhuang8 e89ec8f685 Clean up to update the reference of the these macros:
EFI_SIGNATURE_16 -> SIGNATURE_16
  EFI_SIGNATURE_32 -> SIGNATURE_32
  EFI_SIGNATURE_64 -> SIGNATURE_64
  EFI_FIELD_OFFSET -> OFFSET_OF
  EFI_MAX_BIT      -> MAX_BIT
  EFI_MAX_ADDRESS  -> MAX_ADDRESS
These macros are not defined in UEFI spec. It makes more sense to use the equivalent macros in Base.h to avoid alias.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7051 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-16 15:31:58 +00:00
tding1 6c23910cde clean coding style issue
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7032 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-15 09:16:03 +00:00
tding1 0ade0d28c1 remove EDK_RELEASE_VERSION in inf file
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7026 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-15 06:01:48 +00:00
tding1 38e7a3f00a update [Depex] section
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6999 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-11 09:36:02 +00:00
tding1 3abd5df7d9 update code comment
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6981 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-10 10:14:18 +00:00
tding1 596cecff81 update function comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6922 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-08 09:47:28 +00:00
gikidy 3c39934be2 Change comment "bitwise inclusive OR" to "bitwise OR".
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6875 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-05 09:42:55 +00:00
tding1 d85067fdf9 update INF [LibraryClasses] section to match include libs in module master header file
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6846 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-04 09:36:31 +00:00
tding1 4ebb0d9eb1 fix ecc report-out issues
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6831 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-04 06:12:44 +00:00
qhuang8 bf428cb388 Sync UefiLib instance in IntelFrameworkPkg with the one in MdePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6797 6f19259b-4bc3-4df7-8a09-765794883524
2008-12-01 14:42:26 +00:00
eric_tian 334983fa98 change DxeSmmDriverEntryPoint library class name to UefiEntryPoint
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6657 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-21 04:30:05 +00:00
qwang12 00a1f55295 Update doxygen comment for VarArg list.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6621 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-19 03:24:44 +00:00
qhuang8 6abba83241 Add dependency of MdeModulePkg since HiiLib has been moved to MdeModulePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6533 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-13 10:10:16 +00:00
klu2 a6d5e5f7f3 1, Add <Library/DevicePathLib.h> for all source that use device path utility macros
2, Add DevicePathLib library class to module's INF that use device path utility macros

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6458 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-11 15:44:41 +00:00
eric_tian 2563c29363 +++++ mdkinney 11/5/2008 11:08:13 PM
The library class DxeSmmDriverEntryPoint is no longer required.  It is identical to UefiDriverEntryPoint, so that library class should be used.  We can still have a different library instance for UEFI and DXE SMM drivers, but they can share the same lib class defintion.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6432 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-07 10:00:54 +00:00
qhuang8 263480c62c Add gEfiDriverConfiguration2ProtocolGuid GUID C Name in INF.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6424 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-07 06:31:56 +00:00
qhuang8 ed916b22cb Sync the UefiDriverModule.c with counter part in MdePkg
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6420 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-07 06:24:34 +00:00
jji4 df1f748c87 Patch to remove STATIC modifier. This is on longer recommended by EFI Framework coding style. All duplicated symbols has been renamed accordingly.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6297 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-30 06:06:07 +00:00
qwang12 efe08f48c5 Remove the duplicated definitins.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6239 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-27 00:48:36 +00:00
qwang12 7344986268 Move STRING_REF and RELOFST to FrameworkHii.h.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6182 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-22 05:20:31 +00:00
qhuang8 8bc7aa6aa6 Add missing Framework HII definitions to pass build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6172 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-21 13:36:05 +00:00
qhuang8 c6ad4aa601 Add back PeiServicesTablePointerLib library class since GetPeiServicesPointer() API is directly used in PeiSmbusLibSmbusPpi.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6160 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-21 01:14:18 +00:00
qwang12 0c39efcc51 Base on PI spec, GetPeiServicesTablePointer is updated to return CONST EFI_PEI_SERVICES**. This is a incompatible changes. All file that reference this must be updated.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6128 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-17 08:43:22 +00:00
klu2 575bc2b257 Remove over specify library class for IntelFrameworkPkg and IntelFrameworkModulePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6120 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-16 02:38:49 +00:00
klu2 66eebcf94f Remove Smbus related macro, which are defined in MdePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6106 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-13 02:29:00 +00:00
qwang12 834a2e41fb Replace mBS with gBS from UefiBootServicesTablePointer Lib to avoid library instance to cache too many copies of Boot Service Pointer.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5943 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-22 09:41:40 +00:00
lgao4 7338117bbf remove the unused msa/npsd files
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5936 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-20 06:18:16 +00:00
yshang1 156eb6bbf7 Bug Fix in DxeSmmDriverEntryLib.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5928 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-19 03:42:07 +00:00
vanjeff 299d51fddc remove unnecessary comments introduced by tools.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5912 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 08:00:13 +00:00
eric_tian c57da111f7 cleanup some comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5864 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 07:11:51 +00:00
vanjeff ed66e1bc0d clean up the un-suitable ';' location when declaring the functions.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5820 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 09:37:28 +00:00
vanjeff 39e0ae3bee revert it for error checking-in.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5816 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 08:18:08 +00:00
vanjeff e53a6ea90e remove EFI_EVENT_ alias, replace them with EVT_
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5813 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 07:42:38 +00:00
qwang12 c39940b534 Update FrameworkHiiToUefiHiiThunk to produce Framework HII Protocol and Framework Setup Browser in new GUIDs. This is because the interfaces produced only handle IFR and String packages in UEFI format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5802 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-03 10:49:30 +00:00
lgao4 f829715058 remove the unused msa files in FatBinPkg, IntelFrameworkPkg, IntelFrameworkModulePkg, Nt32Pkg, OptionRomPkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5727 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-25 05:08:13 +00:00
klu2 bd33fcfbb9 Misuse protocol and guid
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5691 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-20 04:20:26 +00:00
klu2 eabbb93bfe Remove blank for function typedef, it break generating doxygen document
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5595 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-31 08:24:25 +00:00
klu2 5593fdd822 Remove blank for function typdef, it will break generating doxygen document.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5592 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-31 07:50:47 +00:00
klu2 69686d5669 Remove blank for function typedef, it will break generating doxygen document.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5591 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-31 07:44:54 +00:00
qwang12 2498053442 get the definition for EFI_PEI_PCI_CFG_PPI_WIDTH from PciCfg2.h
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5357 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-20 06:26:02 +00:00
qwang12 661e7afdfd Remove the tailing ',' to ensure the code pass EBC's -Za option (Enforces strict conformance to the ANSI standard for C).
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5327 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-04 10:49:37 +00:00
qhuang8 ac64461468 De-unicode in comment for all source files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5302 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-27 03:24:01 +00:00
qwang12 6ee6927825 Update ChangeLog.txt
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5217 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-16 09:51:06 +00:00
qwang12 3d02e416fd git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5216 6f19259b-4bc3-4df7-8a09-765794883524 2008-05-16 09:45:51 +00:00
klu2 7459094d5f Fix typo in comment.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5109 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-22 05:52:01 +00:00
qwang12 102e727273 rename EFI_HII_UPDATE_DATA in FrameworkHii.h to FRAMEWORK_EFI_HII_UPDATE_DATA as it is a duplicated definition with IfrSupportLib.h
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5097 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-18 09:22:58 +00:00
lgao4 c2c8503b37 Correct EFI_COMPATIBILITY16_TABLE_SIGNATURE definition to "IFE$"
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5094 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-18 04:56:52 +00:00
klu2 6cd4aed829 Remove unused function.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5093 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-18 04:22:14 +00:00
qwang12 68fc9ba486 define #define EFI_HII_UPDATE_DATA FRAMEWORK_EFI_HII_UPDATE_DATA to avoid duplicated definition between Framework and IfrSuportLib.h. This duplicated definition only occurs for EdkCompatibilityPkg's FrameworkHiiToUefiHiiThunk module as it needs to include header file from both sides.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5085 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-17 13:44:16 +00:00
klu2 b2cefd7c90 Fix function comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5031 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 09:07:37 +00:00
klu2 2ec4d26975 Fix coding style issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5029 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 07:15:51 +00:00
klu2 65c2940a1c Remove IfrLibConstruct, because it do nothing.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5016 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 05:20:48 +00:00
klu2 bb55784566 Add comments for library function interface.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5015 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 03:25:42 +00:00
klu2 0b34b86929 Fix unknown character in header comments which break build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5014 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 02:42:40 +00:00
klu2 3471dae2a9 Fix unknown character in header comments which break build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5013 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 02:15:58 +00:00
klu2 f1df9cf4fa Fix build error.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5010 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 02:04:47 +00:00
klu2 c4fa3eacb3 Add comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5005 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-08 07:57:02 +00:00
klu2 8411f1c002 Add more comments for IntelFramework's header files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5004 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-08 07:40:30 +00:00
klu2 4a71b21a63 Add more comments for IntelFramework's header files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5003 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-08 06:29:25 +00:00
qwang12 c1adc63d02 Both FrameworkHii and UefiHii declare some macros and structure with the same name. To make a Framework Hii to Uefi HII thunk layer to be able to be built. We need to define the Framework Hii names with a prefix "FRAMEWORK_".
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4992 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-03 10:02:13 +00:00
qhuang8 f100bb0983 Fix a GUID value typo for Legacy BIOS protocol
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4972 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-01 07:31:30 +00:00
lgao4 19dd2b33d3 Correct gEfiLegacyBiosPlatformProtocolGuid value same to the definition in header file
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4920 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-19 09:55:32 +00:00
klu2 cf7e50f8f9 Modify all file header to follow doxygen format
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4907 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-19 03:26:51 +00:00
eric_tian 9d19852267 [Description]
ICH9x supports a new SMI type-IchnGpioUnlock. Then IchnGpioUnlock should be added to the enum definition EFI_SMM_ICHN_SMI_TYPE  
[Impaction]
modify the SmmIchnDispatch.h file
[Reference Info]
ICH9x supports a new SMI type-IchnGpioUnlock.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4862 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-17 09:30:26 +00:00
qwang12 a2b58cf3d2 [Description]:
1) Remove HiiLibAddFontPackageToHiiDatabase as it is not properly defined API. It only cover Simplified Font. User is recomended to use Hii Font Protocol API to add various font into HII database.

[Impaction]:
All modules that may reference HiiLibAddFontPackageToHiiDatabase function.
[Reference Info]:
No.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4858 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-15 05:08:37 +00:00
qwang12 dce23de2f1 update ChangeLog.txt
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4854 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-15 04:15:03 +00:00
qwang12 11219cc655 [Description]:
1) Remove the definition of EFI_DISPATCH_OPROM_TABLE from IntelFrameworkPkg\Include\Framework\Legacy16.h to TianoModulePkg\Include\LegacyBios.h as it is not defined in any Intel Framework spec.

[Impaction]:
Build break for Modules that reference this undocuments structure.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4853 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-15 04:11:35 +00:00
klu2 765e516c7f Modify the structure name to follows spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4848 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-14 01:46:44 +00:00
xli24 ab654bfd6e Add definition for EfiCacheAssociativity24Way.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4846 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-13 17:49:14 +00:00
klu2 91399a51e7 Add more smbios record support.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4824 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 05:58:06 +00:00
qwang12 7adf5fa455 remove the duplicate guid.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4671 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-04 06:56:50 +00:00
qwang12 568f78ab31 1) Cleanup HiiLib, IfrSupportLib.
2) Add ExtendedHiiLib and ExtendedIfrSupportLib which implement APIs that require the OPcode and Device Path which is specific to Intel's implementation.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4663 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-02 13:25:58 +00:00
qwang12 6178919748 UEFI HII: Merge UEFI HII support changes from branch.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4603 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-22 01:27:53 +00:00
qwang12 dc7b4a5c43 UEFI HII: Merge UEFI HII support changes from branch.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4597 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-21 14:33:26 +00:00
klu2 373572ca87 Fix build break issue
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4381 6f19259b-4bc3-4df7-8a09-765794883524
2007-12-10 15:08:34 +00:00
qhuang8 8a7d75b062 Clean up: update "EFI" to "UEFI" if applicable.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4317 6f19259b-4bc3-4df7-8a09-765794883524
2007-11-22 06:00:39 +00:00
klu2 8e5b17b25e Update following library class/Protocol for puting 'Framework' as prefix
FrameworkHii
FrameworkFormBrowser
FrameworkFormCallback
FrameworkIfrSupportLib

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4196 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-22 09:36:00 +00:00
klu2 f1f289a36d Move the EFI_PEI_STARTUP_DESCRIPTOR into IntelFrameworkPkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4119 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-16 02:46:31 +00:00
qhuang8 3d6f81d7b4 Use Device Path Macros to get Device Path Type/SubType. (Some extensions might use high-bit-set device path type to specify "unpacked" device path.)
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3880 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-18 02:41:33 +00:00
qhuang8 c18099186c Make IntelFrameworkPkg pass package build
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3872 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-17 04:13:54 +00:00
klu2 bba9ad98f1 FixedPcd macro should *not* be used in Library's inf file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3868 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-17 03:57:13 +00:00
qhuang8 4aad654298 Update the local header file name.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3864 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-17 03:47:54 +00:00
qhuang8 6313f115aa 1. Add Missing UefiDrvierModel APIs in UefiLibFramework instances.
2. Fix the bug to judge Media Device Path.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3863 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-17 03:41:47 +00:00
zliu3 1b7f7985bd Add the "ChangeLog.txt" to record packages' all non-compatible changes and important compatible changes.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3830 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-13 06:38:20 +00:00
qwang12 22936e958f Merge the PI enabling works from the branch
First round of PI enabling work:
1) PiPeiCis changes (CONST, EFI_PEI_FILE_HANDLE.. etc)
2) Make use of FirmwareVolume 2 protocol.
3) Verified for Nt32Pkg and real platform for S3.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3770 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-04 06:09:39 +00:00
qhuang8 f4a9471d55 Add a new library class of SmmLib
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3764 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-03 03:23:24 +00:00
vanjeff 8fb6b714d3 Add missing packages dependency.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3760 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-31 07:38:59 +00:00
qhuang8 b3af5df67b Update all INF, DEC and DSC file to confirm to newest INF spec 0.44, DEC spec 0.41, DSC spec 0.40.
Mainly PCD syntax update.
Check in new build.exe and GenFds.exe
Check in PcdSyntaxUpdate.exe tool. 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3744 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-30 09:11:54 +00:00
lgao4 80c76d516e Remove the duplicated Hii header file FrameworkHii.h
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3723 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-28 06:16:27 +00:00
qwang12 2d0beb94f8 Make IntelFrameworkPkg GCC+IA32 clean.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3712 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-27 03:34:28 +00:00