Commit Graph

5440 Commits

Author SHA1 Message Date
vanjeff 5385a57969 clean up baselib according to review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5958 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-24 05:30:40 +00:00
eric_tian dfb8993c3c fix a issue caused by code review follow up
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5957 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-24 05:01:24 +00:00
xli24 24dcb5e50a Update BaseLib according to code review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5956 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-24 04:17:16 +00:00
qwang12 9d5eaca403 Add an ASSERT to make sure this thunk module can only be used together with a PI PEI core, as we
assume PeiServices Pointer Table can be located in a standard way defined in PI spec.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5955 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-24 02:54:40 +00:00
eric_tian dc8d93ca0c add detail comments on the complicated code segment.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5954 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-23 14:49:45 +00:00
jlin16 6fa28b758b GenFds fix two UI sections error.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5953 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-23 09:28:11 +00:00
lgao4 28127cc762 Add assert check to make sure new stack size larger than old stack size.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5952 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-23 09:11:12 +00:00
xli24 13c3803149 Refine code for MdePkg/Include/Ppi according to code review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5951 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-23 07:55:57 +00:00
xli24 c7c308ad48 Refine code for PiPeiCis.h according to code review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5950 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-23 07:52:06 +00:00
eric_tian ec90508b3d move header files in MdeModulePkg\Core\Dxe except DxeMain.h into their corresponding sub-module directories. It is used to provide good modularity.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5949 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-23 07:35:34 +00:00
lgao4 1046284db9 Don't align image address for TeImage, because TeImage section alignment is undefined.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5948 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-23 07:16:46 +00:00
lgao4 bdabfae78d Update EfiLibReportStatusCode in ECP EfiDriverLib and EfiRuntimeLib libraries to check uefi version in runtime not in build time.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5947 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-23 07:16:03 +00:00
qwang12 90d6d599d9 Add gEfiHiiFontProtocolGuid AND gEfiFormBrowser2ProtocolGuid into depex as they are quired for this module to work.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5945 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-22 10:37:05 +00:00
qwang12 9556741cbf 1) Replace mBS with gBS from UefiBootServicesTablePointer Lib to avoid library instance to cache too many copies of Boot Service Pointer.
2) Check gBS before make call using it.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5944 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-22 10:20:41 +00:00
qwang12 834a2e41fb Replace mBS with gBS from UefiBootServicesTablePointer Lib to avoid library instance to cache too many copies of Boot Service Pointer.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5943 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-22 09:41:40 +00:00
klu2 7f1eba7b99 Cleanup "Tiano" word.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5942 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-22 05:22:41 +00:00
klu2 e20a8c69b1 Code clean up
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5941 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-22 02:48:13 +00:00
qwang12 36c9465c6d updated the incompatible list.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5940 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-21 08:59:01 +00:00
qwang12 c27eb35861 HiiLibGetCurrentLanguage returns the current UEFI variable "PlatformLang" (if this variable does not exist, a default value is returned). This function is called by HiiDatabase itself. Now, HiiLibGetCurrentLanguage is in HiiLib. Because of this, we can't add location of Hii protoocol in the library constructor of HiiLib. This cause Hii Database driver never get loaded (circular dependency).
By moving HiiLibGetCurrentLanguage to UefiLib, library constructor (depex) can be added back to HiiLib to make sure the execution order is correct.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5939 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-21 08:51:15 +00:00
qwang12 f8d18bada5 HiiLibGetCurrentLanguage returns the current UEFI variable "PlatformLang" (if this variable does not exist, a default value is returned). This function is called by HiiDatabase itself. Now, HiiLibGetCurrentLanguage is in HiiLib. Because of this, we can't add location of Hii protoocol in the library constructor of HiiLib. This cause Hii Database driver never get loaded (circular dependency).
By moving HiiLibGetCurrentLanguage to UefiLib, library constructor (depex) can be added back to HiiLib to make sure the execution order is correct.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5938 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-21 08:50:52 +00:00
qwang12 c0522bd7df CloseEvent in ReportStatusCodeLibDestruct can only be called when the library instance is not linked with a SMM driver (for example a boot dirver or EFI Runtime capable driver).
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5937 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-21 08:18:48 +00:00
lgao4 7338117bbf remove the unused msa/npsd files
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5936 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-20 06:18:16 +00:00
jljusten 84c3b71b18 edk2/EdkCompatibilityPkg/EdkCompatibilityPkg.dsc:
* Based on the Sept 11th (r5884) removal of
  EdkCompatibilityPkg/Compatibility/FvInfoToFvHobThunk, it no longer
  makes sense for this .inf to be referenced in this .dsc file.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5935 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-19 22:34:57 +00:00
lgao4 5a58200d19 Correct CompareGuid function
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5933 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-19 09:26:18 +00:00
vanjeff 05c0e3cb8a 1. Sync Bug:PXE Boot issue- UefiPxeBc driver currently does not follow PXE Spec
[Root Cause Analysis]
The PXE offer selection in the PXE driver is splitted into two passes and the two passes are required to follow the same flow. However, in current code, there is some difference between the two.
[Solution]
make the second offer selection pass exactly match the first one.

2. Fixed one bug when allocating pool for UDP transmit packet.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5932 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-19 07:12:23 +00:00
lgao4 2a5f2a5036 Update these library instances module type to UEFI_DIRVER, because they only depends on UEFI spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5931 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-19 06:22:44 +00:00
lgao4 223c22d8ea 1. Add three sample PCD in HelloWorld application for user reference of PCD usage.
2. PeiCore will always build FvHob for the extracted FvImage once it decompresses the new FvImage. 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5930 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-19 05:05:40 +00:00
lgao4 c481196831 Update Library description for BaseMemoryLibOptDxe and BaseMemoryLibOptPei.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5929 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-19 04:38:53 +00:00
yshang1 156eb6bbf7 Bug Fix in DxeSmmDriverEntryLib.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5928 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-19 03:42:07 +00:00
lgao4 2bfb60098f 1. Change 0 == Length style to Length == 0
2. Clean BasePeCoff library instance, only keep one copy PeCoffLoaderEx.c file for IA32, X64 and IPF arch
3. Clean the confused comments

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5927 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-18 14:27:39 +00:00
lgao4 66df253186 1. Correct CopyMem and CompareMem to CopyGuid and CompareGuid for GUID data
2. Add the missing processor type in DataHubRecords/DataHubSubClassProcessor.h file.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5926 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-18 09:14:00 +00:00
qwang12 4792a1a65b Rollback change done in 5919: "Remove the status code EFI_ALREADY_STARTED to avoid confusion since it is not a possible return status from LoadFile() interface." It is accidentally overwritten in last check-in.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5925 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-18 09:03:36 +00:00
qwang12 61ad8a41e7 Remove the GrowBuffer function. Just use the simple way to get the buffer size and then read the buffer. This change improve the readability and save 0x60 byte of data for release build according to MAP file generated for X64 arch.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5924 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-18 08:42:11 +00:00
jwang36 c8b671eea5 Fixed HSD201555
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5923 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-18 05:59:18 +00:00
eric_tian be5d189fd1 modify an issue about data off.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5922 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-18 01:49:46 +00:00
qhuang8 d9177625f6 Adjust the function layout to remove the prototype of internal functions to reduce sync efforts.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5921 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 14:20:29 +00:00
qhuang8 e676c4d0c6 Apply HighBitSet() in MDE baseLib to retire the internal function CoreHighestSetBit().
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5920 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:35:14 +00:00
qhuang8 2ce854f515 Remove the status code EFI_ALREADY_STARTED to avoid confusion since it is not a possible return status from LoadFile() interface.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5919 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:34:18 +00:00
qhuang8 f94b9be34f Adjust the function layout of Timer.c to remove the prototype to reduce sync efforts.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5918 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:32:52 +00:00
qhuang8 3f1435782f Refine code to remove the last entry of mArchProtocol.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5917 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:31:43 +00:00
qhuang8 57b4ecb94b Fix several code review minor comments:
1. Line 79:Use the pre-initialized global variable mPoolHeadList = INITIALIZE_LIST_HEAD_VARIABLE (mPoolHeadList) to remove the statement in line 102
2. Line 337: The debug print statement: “Addr = %x” should change to “Addr = %p” since the expected Buffer is VOID *; How about “(len %x) %,d” ? The Size & Pool->Used belong to type UINTN? Cast it to UINT64 and use %lx 
3.Line 413, 418, 425, 477: Use “Buffer != NULL” instead of “NULL != Buffer”  
4. Line 451: The debug print statement: “FreePool = %x” should change to FreePool = %p” since Head->Data is pointer; How about “(len %x) %,d” ? The Head->Size& Pool->Used belong to type UINTN? Cast it to UINT64 and use %lx 


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5916 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:29:44 +00:00
qhuang8 d45fd26026 Fix several code review minor comments:
1.Line 1520, 1525, 1530:Use goto to save Release Lock
2.Line 224: Do not use DEBUG_ERROR, since it is not an error case
3.Scrub the DEBUG () print statement to add DEBUG_PAGE
4.Line 20: Typo of "help cooalese"


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5915 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:28:05 +00:00
vanjeff 04b9f76313 Fixed one bug in consplitter console input Start/Stop functions for those handlers only produce SimpleTextIn and not produce SimpleTextEx protocol.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5914 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 09:55:05 +00:00
jwang36 205564ad9b Fixed HSD201384 & HSD201375
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5913 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 09:42:38 +00:00
vanjeff 299d51fddc remove unnecessary comments introduced by tools.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5912 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 08:00:13 +00:00
vanjeff 1efcc4ae46 remove unnecessary comments introduced by tools from MdePkg. The regular express is "//^p//[ ]Include[ ]common[ ]header[ ]file[ ]for[ ]this[ ]module[.]^p//"
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5911 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 07:46:17 +00:00
qwang12 91496a547d Update the comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5910 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 03:02:04 +00:00
qwang12 6c8e1cee0e Update the comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5909 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 03:01:41 +00:00
qwang12 eb91f2f8a2 Update the comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5908 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 03:01:18 +00:00
qwang12 a70c0fd846 Add VA_END to end the VA_START.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5907 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 02:30:24 +00:00