Commit Graph

6972 Commits

Author SHA1 Message Date
jcarsey b518ea4e87 fixed typo
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7515 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 22:45:34 +00:00
jljusten 4ad9d87d7a * MdeModulePkg/Core/Pei/Dependency/Dependency.h
Decrease MAX_GRAMMAR_SIZE from 256 to 64.

In Dependency.c => PeimDispatchReadiness, a local variable 'EvalStack'
makes an array of EVAL_STACK_ENTRY structures to store a stack for
processing the dependency expression.

Due to alignment considerations, sizeof (EVAL_STACK_ENTRY) is 16 bytes 
on 64 bit architectures.  This means the size of the EvalStack local
variable in PeimDispatchReadiness grows to 4kb.

In the PEI phase, the stack area may be very small, and therefore 4kb is 
much to large.  Reducing MAX_GRAMMAR_SIZE to 64 will lower the size
of EvalStack to 1kb.

While reducing this to 1kb solves an issue seen with GCC on X64, it is
still a large usage of stack for the PEI phase, and future improvements
may still need to be made.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7514 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 17:15:08 +00:00
eric_tian cb0b858d6e add assert logic to avoid Klocwork fake report
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7513 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 08:41:34 +00:00
eric_tian 525aded947 add assert logic to avoid Klocwork fake report
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7512 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:39:01 +00:00
eric_tian a1b749d074 add assert logic to avoid Klocwork fake report
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7511 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:23:15 +00:00
vanjeff c55426ab64 fixed comments missing.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7510 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:06:23 +00:00
vanjeff df80a83c8a enhanced security check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7509 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:05:08 +00:00
vanjeff 7c1bc8d656 Enhanced status return check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7508 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 03:03:47 +00:00
vanjeff e618d0cb67 add return value check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7507 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 02:33:23 +00:00
vanjeff 892b7f90c5 add NULL pointer check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7506 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 01:55:32 +00:00
qhuang8 68443c61b4 Fix entry point prototype error.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7505 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 07:42:24 +00:00
qhuang8 d84dbca50e Use apply PeiServicesLib to locate PPI
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7504 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 07:41:02 +00:00
qhuang8 4cfc3293c7 Fix the typo in comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7503 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 07:09:19 +00:00
qhuang8 96a5ac5b0d Adjust code to fix potential array out-bound issues.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7502 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 07:05:43 +00:00
qhuang8 51195fbe8c Remove several unicode in comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7501 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 06:02:54 +00:00
qhuang8 ead7e7dc74 Fix the potential illegal EBC opcode issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7500 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 06:01:07 +00:00
qwang12 4798ea5b2a 1) Replace IA32API with EFIAPI to standardise the calling convention.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7499 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 05:50:37 +00:00
lgao4 98b15cf156 Include the missing Guid header file to refer the global Guid
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7498 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 04:57:42 +00:00
mdkinney 2e121e9aaa Add #defines for commonly used Base Address and Sizes.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7497 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 19:31:53 +00:00
lgao4 8a3f79bf36 Add the missing Guid header file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7496 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 14:33:55 +00:00
lgao4 1e42ac79f2 Add MdePkgTokenSpace Guid header file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7495 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 14:31:57 +00:00
lgao4 b998288321 Correct typo in comments, clean IfrSupportLib.h
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7494 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 13:32:19 +00:00
lgao4 9e5acfd583 Change style 0 == Index to Index == 0
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7493 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 13:17:51 +00:00
eric_tian fbbb42115c clean K8.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7492 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 09:56:23 +00:00
qwang12 a935a0d8b7 Add in ASSERT to avoid NULL point dereference.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7491 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 09:40:27 +00:00
xli24 dcbb35eb6c Add comments in DSC files to explain the function and design of components section.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7490 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 08:58:47 +00:00
xli24 80ed2093c9 Add comments in DSC files to explain the function and design of components section.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7489 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 08:56:24 +00:00
xli24 b2ba1c1e2b Add comments in DSC files to explain the function and design of components section.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7488 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 08:55:56 +00:00
xli24 6074a6fb4b Add comments in DSC files to explain the function and design of components section.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7487 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 08:55:43 +00:00
qhuang8 f8d8f5473e Remove the workaround in DxeHobLib.inf that it over-specify UefiBootServicesTableLib to generate the correct sequence for library constructor for DuetPkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7485 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 10:05:54 +00:00
qhuang8 8e0e028a28 Update ReportStatusCodeLib mapping: Use DxeCoreReportStatusLibFromHob DXE_CORE and DxeReportStatusCodeLib in IntelFrameworkModulePkg for all other modules.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7484 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 10:04:00 +00:00
qhuang8 6dacb8cda9 Add DxeCoreReportStatusCodeLibFromHob library instance. For now, it is dedicated to DxeCore for DuetPkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7483 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 10:02:28 +00:00
vanjeff 05b1c4143c update meta.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7482 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 06:11:51 +00:00
qwang12 d1a54e2c3e ECC cleanup: Non-Boolean comparisons should use a compare operator (==, !=, >, < >=, <=)
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7481 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 05:29:17 +00:00
jji4 f0a8eeb2c5 Comments synchronized
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7480 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 03:28:44 +00:00
lgao4 2517435c8d Clean Network Driver to include Uefi.h, not PiDxe.h.
Network driver don't depend on PI definition.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7479 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 02:59:07 +00:00
lgao4 1f25dacf8b Clean IpfMacro.i to remove unused Macro.
Sync ReportDebugCodeLib function description to new MdeLib spec.
Update PlatformDriverOverride protocol function description according to UEFI spec.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7478 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 02:08:57 +00:00
niry 9cff2f8d36 Roll back the DEBUG mask change which cause SerialIo read_conf test item failure.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7477 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 01:22:19 +00:00
mdkinney 6c6004f491 Fix build break for missing PeCoffLib mapping
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7476 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 20:41:49 +00:00
mdkinney ba5e88f965 Add parenthesis to expression to make order of operations clear
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7475 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 20:40:48 +00:00
mdkinney 9bb407c643 Fix IN OUT specifiers
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7474 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 18:34:23 +00:00
qhuang8 1bfc7438ab Fix ICC build break
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7473 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 09:34:51 +00:00
qhuang8 5fc5555520 Fix ICC build break
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7472 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 09:31:40 +00:00
lgao4 276a49b699 Clean up FaultTolerantWriteDxe to remove the duplicated definition.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7471 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 09:03:12 +00:00
niry 2374b9734b fix the operator priority bug.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7470 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 08:56:45 +00:00
jwang36 d5469f43e3 Corrected the case of file name
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7469 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 08:54:41 +00:00
qhuang8 56c0008b78 Add change log for the non-backward compatibility change in EDK_7467
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7468 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 08:32:12 +00:00
qhuang8 6544297832 Retired macro value TIME_OUT in UefiUsbLib and introduce a new PCD entry PcdUsbTransferTimeoutValue for it.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7467 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 08:30:34 +00:00
qhuang8 2f5c655aae De-unicode to pass VS2005 build
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7466 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 07:56:53 +00:00
qhuang8 8ed62a3035 Fix minor build issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7465 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 07:42:00 +00:00