Commit Graph

149 Commits

Author SHA1 Message Date
czhang46 f9b843ec49 In PcdBootlogoOnlyEnable case, Clear cursor & screen when key rather than Hotkey or
Enter is pressed to goto front page 

Signed-off-by: czhang46
Reviewed-by: li-elvin

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13480 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-02 05:17:16 +00:00
niruiyu 2d1f3dd497 Fix memory leak issues.
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13428 6f19259b-4bc3-4df7-8a09-765794883524
2012-06-06 08:41:58 +00:00
niruiyu 16e5944abd Refine BdsDxe driver and GenericBdsLib library so that the GenericBdsLib doesn't depend on the BdsDxe implementation.
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13418 6f19259b-4bc3-4df7-8a09-765794883524
2012-06-01 03:39:39 +00:00
ydong10 f01b91ae42 Fixed build failed.
Signed-off-by: Eric Dong <eric.dong@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13406 6f19259b-4bc3-4df7-8a09-765794883524
2012-05-31 08:35:48 +00:00
ydong10 bf4a3dbd47 Add new interface GetVariable2 and GetEfiGlobalVariable2 to return more info. Also replace old interface with new one.
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13375 6f19259b-4bc3-4df7-8a09-765794883524
2012-05-30 07:36:00 +00:00
ydong10 8b4d274cb1 Refine the code to follow coding style.
Signed-off-by: Eric Dong <eric.dong@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13366 6f19259b-4bc3-4df7-8a09-765794883524
2012-05-28 07:03:26 +00:00
ydong10 7ea2285209 Add logic to validate console variables when enter BDS.
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13322 6f19259b-4bc3-4df7-8a09-765794883524
2012-05-18 02:13:29 +00:00
czhang46 47bd1c9462 update code to follow coding style.
Signed-off-by: czhang46
Reviewed-by: ydong10


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13154 6f19259b-4bc3-4df7-8a09-765794883524
2012-03-30 01:27:14 +00:00
czhang46 2df686c67c Add BootlogoOnly feature in BDS for BGRT
Signed-off-by: czhang46
Reviewed-by: li-elvin, hhtian


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13116 6f19259b-4bc3-4df7-8a09-765794883524
2012-03-23 04:27:19 +00:00
ydong10 98ba35a40c Patch includes:
1.Update question value after BDS change code to avoid save invalid data.
2.Fix a corner case bug that may cause unexpected popup when changing the legacy device order.
Signed-off-by: ydong10
Reviewed-by: lgao4

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12892 6f19259b-4bc3-4df7-8a09-765794883524
2011-12-22 06:31:40 +00:00
ydong10 8472407740 Update for IntelFrameworkModulePkg.
Per UEFI spec, on CallBack action EFI_BROWSER_ACTION_CHANGING, the return value of ActionRequest will be ignored, but on CallBack action EFI_BROWSER_ACTION_CHANGED, the return value of ActionRequest will be used. 
But, EDKII browser still processes the got ActionRequest. And, all HII drivers in EDKII project also returns their expected ActionRequest value on action EFI_BROWSER_ACTION_CHANGING. 
Now update the browser to follow the spec, and update all core Hii drivers to keep old working modal.

Signed-off-by: ydong10
Reviewed-by: lgao4

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12866 6f19259b-4bc3-4df7-8a09-765794883524
2011-12-15 02:56:46 +00:00
li-elvin 32bc1227a5 Update console mode setup to use PcdSetupConOutColumn and PcdSetupConOutRow which are specially for BIOS setup.
Signed-off-by: li-elvin
Reviewed-by: lgao4


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12770 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-24 01:01:48 +00:00
lzeng14 49975acb39 According to PI errata 0000654 and 000811, we need use 0xFFFE to instead of 0 for EFI_SMBIOS_PROTOCOL.Add() SmbiosHandle parameter to assign a unique handle to the SMBIOS record, and for EFI_SMBIOS_PROTOCOL.GetNext() SmbiosHandle parameter to get the first matched SMBIOS handle or indicate no more SMBIOS record.
Signed-off-by: lzeng14
Reviewed-by: li-elvin

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12750 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-21 08:53:54 +00:00
li-elvin 801401877e Fix incorrect pointer check.
Signed-off-by: li-elvin
Reviewed-by: ydong10

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12694 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-15 01:14:44 +00:00
li-elvin 72861c22e5 Introduce video resolution and text mode PCDs for BIOS setup in BDS module. User can use these PCDs to customize video resolution and text mode for setup when launching BIOS setup.
Signed-off-by: li-elvin
Reviewed-by: niruiyu


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12671 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-08 07:34:56 +00:00
niruiyu 59b9d73e5f Check the return status of booting against EFI_SUCCESS instead of using EFI_ERROR() macro to catch the warning status.
Signed-off-by: niruiyu
Reviewed-by: li-elvin

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12668 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-08 03:10:36 +00:00
xdu2 a637802c2f IntelFrameworkModulePkg: Update GenericBdsLib to use BootLogo protocol to report logo information after logo is drawn to screen; update BdsDxe to notify logo is corrupted when user is going to enter setup.
Signed-off-by: xdu2
Reviewed-by: mdkinney
Reviewed-by: lgao4

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12664 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-04 08:28:09 +00:00
jljusten 310580cf8a IntelFrameworkModulePkg: Remove variables that are set, but not used
GCC 4.6 generates a warning when a variable is set,
but never used.

Signed-off-by: jljusten
Reviewed-by: lgao4

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12616 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-31 15:57:25 +00:00
ydong10 0e9b25c23b Add pointer check for NULL before dereference it.
Signed-off-by: ydong10
Reviewed-by: vanjeff

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12474 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-29 06:38:55 +00:00
lgao4 e24fc1032d Clean up the private GUID definition in module Level.
0. Remove the unused private GUID from module source files.
1. Use gEfiCallerIdGuid replace of the private module GUID.
2. Add the public header files to define HII FormSet and PackageList GUID used in every HII driver.
3. Publish EFI_LEGACY_DEV_ORDER_VARIABLE_GUID from BdsDxe driver and EFI_UPDATE_DATA_FILE_GUID from UpdateDriverDxe to IntelFrameworkModulePkg Include directory.

Signed-off-by: lgao4
Reviewed-by: ydong10 gdong1 tye jfan12 wli12 rsun3 jyao1 ftian



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12374 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-18 12:23:27 +00:00
ydong10 a1cfbf8c30 Update the BDS UI to keep the old behaviors after add exit action when Config_Access_Protocol.CallBack function returns Submit or Reset which is follow UEFI spec 2.3.1.
Signed-off-by: ydong10
Reviewed-by: lgao4


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12362 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-16 06:01:11 +00:00
li-elvin 5025be3fc1 Add error debug information for capsule processing in Bds.
Signed-off-by: li-elvin
Reviewed-by: lgao4, jyao1


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12271 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-02 14:45:30 +00:00
ydong10 f6bd06633d Refine code to follow coding style.
Signed-off-by: ydong10



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11875 6f19259b-4bc3-4df7-8a09-765794883524
2011-06-23 01:33:03 +00:00
ydong10 d88f86f154 Refine all R9 call back function to return EFI_UNSUPPORTED for all unsupported call back type.
Signed-off-by:  ydong10
Reviewed-by: lgao4


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11681 6f19259b-4bc3-4df7-8a09-765794883524
2011-05-20 01:33:42 +00:00
niruiyu d394581d11 The hotkey callback in BDS module should defer loading the boot option until the TPL drops to TPL_APPLICATION after the keyboard driver is enhanced to call hotkey callback in timer handler whose TPL is higher than TPL_APPLICATION.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11573 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-20 08:51:18 +00:00
niruiyu b70a580bad Add assertion check for TmpString against NULL.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11509 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-07 02:02:21 +00:00
niruiyu 2fde83b14c > When GetHealthStatus() returns NULL FormHiiHandle, DeviceManager shouldn't call SendForm to show the configuration form.
> Combine the multiple reset request returned by GetHealthStatus() when repairing all the controllers.
> Fix the bug that source code and VFR code use different value for DRIVER_HEALTH_FORM_ID.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11494 6f19259b-4bc3-4df7-8a09-765794883524
2011-04-01 05:22:18 +00:00
ydong10 be1b161278 Update inf file to follow spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11451 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-30 03:36:54 +00:00
ydong10 d9a743c696 Enhance inf to follow spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11390 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-14 08:40:20 +00:00
ydong10 c1e2b15289 1.Refine all the goto and action opcode. When the menu link to the sub form, use the goto opcode and show the arrow. Others use the action opcode.
2.update the front page info. move down one line.



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11335 6f19259b-4bc3-4df7-8a09-765794883524
2011-02-23 05:08:04 +00:00
ydong10 8e491a81e0 Enhance BMM to support changing FlowControl setting in Front Page.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11317 6f19259b-4bc3-4df7-8a09-765794883524
2011-02-16 05:31:39 +00:00
lgao4 7373d15a98 Add the missing up/down arrow in UNI string.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11292 6f19259b-4bc3-4df7-8a09-765794883524
2011-02-01 06:23:21 +00:00
niruiyu d6bf79a7f5 Add assertion after memory allocation.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11288 6f19259b-4bc3-4df7-8a09-765794883524
2011-01-31 04:15:27 +00:00
niruiyu be88744770 Add back the BdsDeleteBootOption to pass build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11283 6f19259b-4bc3-4df7-8a09-765794883524
2011-01-28 09:21:43 +00:00
niruiyu 22d1f97835 BDS enhancement: enumerate & show all legacy boot options in Boot Manager so that user is able to boot any devices in the same type in Boot Manager without changing the legacy dev order.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11279 6f19259b-4bc3-4df7-8a09-765794883524
2011-01-28 02:36:26 +00:00
niruiyu b452ca8992 Enhance BDS to support Boot/Driver option whose option number >= 0xFF.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11242 6f19259b-4bc3-4df7-8a09-765794883524
2011-01-10 05:56:55 +00:00
niruiyu 2183cf2353 Fix ICC9 compiler failure
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11236 6f19259b-4bc3-4df7-8a09-765794883524
2011-01-07 10:11:46 +00:00
niruiyu b1620d0bee Fix the bug that duplicate HDD is shown in the BMM.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11233 6f19259b-4bc3-4df7-8a09-765794883524
2011-01-06 09:45:03 +00:00
ydong10 20e7314028 Update inappropriate comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11172 6f19259b-4bc3-4df7-8a09-765794883524
2010-12-15 07:39:28 +00:00
ydong10 d04608758d fix potential memory access violation
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11152 6f19259b-4bc3-4df7-8a09-765794883524
2010-12-10 11:16:24 +00:00
ydong10 d3b4af2bca fix build error on ICC compile.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11150 6f19259b-4bc3-4df7-8a09-765794883524
2010-12-10 08:42:36 +00:00
ydong10 3c4b1122e0 [BDS] Device Manager was requested to add more sub-level menu about network device.
Now show menu like:
Network Device List -> Mac:XX:XX:XX... -> IPv4 Network Config
                       Mac:XX:XX:XX...    VLAN Configuration



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11137 6f19259b-4bc3-4df7-8a09-765794883524
2010-12-09 01:44:07 +00:00
niruiyu d860010877 Fix the bug that <continue> may not boot the first boot option but return back to front page.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11109 6f19259b-4bc3-4df7-8a09-765794883524
2010-12-01 05:57:13 +00:00
niruiyu fefefa4cb1 Remove unnecessary mBdsImageHandle.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11012 6f19259b-4bc3-4df7-8a09-765794883524
2010-11-08 06:56:57 +00:00
niruiyu d69bf66dc1 Fix the corner case when there is only "\0\0" appended and the Index is 1. Return missing string instead of empty string.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10914 6f19259b-4bc3-4df7-8a09-765794883524
2010-10-11 04:37:28 +00:00
niruiyu 2ca7eca448 Fix a bug in GetOptionalStringByIndex() that doesn't handle the case when Index == 0.
Code is re-organized to be more readable and simpler.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10823 6f19259b-4bc3-4df7-8a09-765794883524
2010-08-26 03:15:23 +00:00
xdu2 7119d96a6f Fix bug that cursor position will change when enter newly registered HII Form after ConnectAll() in DeviceManager.
Root cause is that in old code, reinstall of HII handle for DeviceManager will cause inconsistent HII handle index for newly installed HII packages by ConnectAll(), thus cause inconsistent QuestionId. FormBrowser will record QuestionId of a Form ever visited, so the cursor position is changed.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10682 6f19259b-4bc3-4df7-8a09-765794883524
2010-07-22 09:46:41 +00:00
lgao4 7f97c9bb52 Use ASSERT to check the expression.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10618 6f19259b-4bc3-4df7-8a09-765794883524
2010-07-01 03:21:55 +00:00
xli24 c6498c1d45 Fix the issue that ASSERT() at line 1391 incorrectly asserts when order list variable is empty.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10564 6f19259b-4bc3-4df7-8a09-765794883524
2010-06-03 08:49:46 +00:00
lgao4 4548fc2aaa Per UEFI spec, FORM_OPEN/FORM_CLOSE Callback function should be called for each question in the form when this form opens or closes.
Update all EDKII HII drivers to correctly handle FORM_OPEN and FORM_CLOSE call back. 


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10561 6f19259b-4bc3-4df7-8a09-765794883524
2010-06-02 02:06:01 +00:00