Commit Graph

343 Commits

Author SHA1 Message Date
qwang12 a78b08d13b Update the code to following EDK coding style document.
1) Pointer value should compare with NULL.
2) Integer should compare with 0.
3) BOOLEAN should not compare with TRUE or FALSE.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5413 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-07 09:17:56 +00:00
vanjeff 24248368f7 1. added functions header for GraphicsConsoleDxe module.
2. correct some funtions header for ConPlatformDxe module.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5411 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-07 05:23:31 +00:00
qwang12 b30312ba29 Update the function headers to Doxygen format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5410 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-04 08:04:10 +00:00
vanjeff 9359e53fcb Added some functions header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5409 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-04 07:58:57 +00:00
vanjeff 8fd9831511 Added some functions header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5406 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-03 05:17:49 +00:00
vanjeff a4d608d1f7 Clean codes per ECC for ConSplitterDxe module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5391 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-01 06:56:37 +00:00
vanjeff 6dcf9abc6a Clean codes per ECC for GraphicsConsoleDxe module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5390 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-01 06:43:10 +00:00
vanjeff e49ef4337f Clean codes per ECC for TerminalDxe module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5389 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-01 06:34:04 +00:00
vanjeff 2b023999fe rename files name to match the actual ones.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5387 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-30 09:04:31 +00:00
vanjeff e47f2cedc3 rename it.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5386 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-30 08:59:07 +00:00
vanjeff 1b641ec087 rename it
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5385 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-30 08:58:28 +00:00
vanjeff 7bce0c5a0e Clean codes per ECC.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5384 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-30 07:20:33 +00:00
qwang12 bd1d34eecf Change the ASSERT condition from “ASSERT (RowInfoArraySize == 1);” to “ASSERT (RowInfoArraySize <= 1);”.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5374 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-27 07:45:01 +00:00
qhuang8 abda9e12b1 Fix an issue in the implementation of GetDriverName() in Con splitter driver. We need to compare "This" paramter with all 5 protocol instances to decide whether it stands for CN or CN2.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5368 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-25 02:52:43 +00:00
vanjeff e234f7c490 [Description]:
Misuse of retransmisson of DHCPDISCOVER in Dhcp4 drive, the root cause is that DHCP doesn't retransmit discover message when timeout.
[Solution]:
 Correct the mechanism for discover message.
[Impaction]:
 Dhcp4Dxe.
[Reference Info]:
 EDK tracker 1150 - Misuse of retransmisson of DHCPDISCOVER in Dhcp4 drive. 



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5366 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-24 08:36:11 +00:00
qwang12 813acf3a9a Merged in the following trackers from EDK:
EDK1145 Cursor mising in shell in some case 
EDK1099: Dell - [HII] HiiGetFontInfo() not retrieve the system font by FoFontInfoMask
EDK1127: [UEFI 2.10] Keyboard layout support 
EDK1129: [UEFI HII] GUID is represented wrongly in Config String
And some other fixes such as
*[UEFI HII] HiiGetAltCfg is generating "Name=" sub string in the wrong format 
*UEFI HII: GetUnicodeStringTextOrSize() doesn't handle NULL StringDest properly
*GetFontInfo() need be updated to avoid iteration 
*HIIStringProtocolTest failed on multiple platform
*[Uefi 2.1] Comply with latest Hii ECR 
* GetFontInfo() need be updated to avoid iteration


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5361 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-23 09:41:33 +00:00
qwang12 35ae460227 Updated copyright.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5352 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-19 02:37:22 +00:00
qwang12 50b399856d Update call-by-value to call-by-reference for EFI_HII_GLYPH_INFO type.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5351 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-19 02:35:35 +00:00
vanjeff 619eff3f29 clean EBC build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5342 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-12 06:51:09 +00:00
vanjeff a8fb9d68f1 Support EBC for UefiPxeBcDxe module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5330 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-05 02:45:24 +00:00
qwang12 1c574ee4dc Add a type cast of UINT32 to insure that EBC compiler does not report warning of "Integer conversion resulted in a change of sign" when building with -Za option (accept only ANSI/ISO standard C code). 1 << 31 is consider to be a sign change by compiler.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5325 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-04 10:03:44 +00:00
mdkinney a163442495 Add call to CreateEvent() for SetVirtualAddressMap()
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5311 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-29 23:07:46 +00:00
htao f26b92e423 Correct data print format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5304 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-27 05:13:10 +00:00
vanjeff 8792362f22 [Description]:
Problem with PXE boot to Windows Server 2008 install. The reason is that UdpRead and UdpWrite interfaces cannot work well with the same UDP instance.
[Solution]
 Use separate instances for UDP Read and UDP write in UefiPxeBC module.
[Impaction]:
 UefiPxeBcDxe and Udp4Dxe module.
[Reference Info]:
 EDK tracker 1133 - Problem with PXE boot to Windows Server 2008 install. 



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5303 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-27 03:34:39 +00:00
qhuang8 ac64461468 De-unicode in comment for all source files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5302 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-27 03:24:01 +00:00
vanjeff 7659d0c92f [Description]:
Fixed one bug in PciBus. PciBus doesn't clear the bridges bus number for all the root bridges before scanning any of them.
[Description]:
 The static IP configuration no long works in the EDK 1.04 network package. The cause is that changing the type of EFI_IP4_IPCONFIG_DATA.RouteTable from a variable length array to a pointer is not clean. If the whole structure is read from variable, the pointer is invalid.
[Solution]
Fix the pointer before using it
[Impaction]:
 Ip4ConfigDxe module.
[Reference Info]:
 EDK tracker 1134 - Static IP configuration no long works. 



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5291 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-26 08:16:25 +00:00
qwang12 30d27d1542 Pass GCC build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5287 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-23 06:26:23 +00:00
qwang12 7fd213953e Pass GCC build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5286 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-23 06:24:50 +00:00
qwang12 36fe40c2ea 1) Add BufToHexString, HexStringToBuf and IsHexDigit to BaseLib.
2) Remove the duplicated functions implementation  from the modules that reference these APIs 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5283 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-23 05:30:08 +00:00
xli24 254ba2477f Add logic to check uninitialized RTC value in PcRtc driver in MdeModulePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5281 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-23 02:29:11 +00:00
qwang12 03836d005d Add a reference of 2nd buffer storage in a formset.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5271 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-22 09:30:18 +00:00
qwang12 d6c0ec55e8 Use Feature Flag PCD to PcdUefiVariableDefaultLangDepricate to replace LANG_SUPPORT.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5269 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-22 08:37:25 +00:00
jwang36 b44bf165f3 Changed the default value for the same var to be the same.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5263 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 07:28:53 +00:00
qhuang8 bf6d2af434 Use "X64" for directory name to follow directory name convention.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5259 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 04:08:35 +00:00
qhuang8 955723bd63 Use "X64" for directory name to follow directory name convention.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5258 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 04:07:30 +00:00
qhuang8 f45af90b01 Update to fix minor coding style issues.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5257 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 04:03:40 +00:00
eric_tian 356e635c15 [Description]
Memory may leak because the handles in IScsiUpdateDeviceList is not freed if the "iSCSIDeviceList" already exists
[Impaction]
add Free() func to free memory properly.
[Reference Info]
The Handles in IScsiUpdateDeviceList is not freed if the "iSCSIDeviceList" already exists

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5211 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-16 07:14:25 +00:00
qhuang8 ea7cb08c0a Minor coding style adjustment for DiskIo, Partition, English and Ebc modules.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5200 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-14 06:07:07 +00:00
qwang12 d29270810c Add in example on
1) how to add SAFE_DEFAULT and MFG_DEFAULT in a formset.
2) how to specify a MFG_DEFAULT for a checkbox.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5199 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-14 02:20:02 +00:00
qhuang8 366219abde Fix the prediction warnings in EBC.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5195 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-13 09:07:59 +00:00
qhuang8 8e3bc754c5 Add doxygen style comments for functions in EBC module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5194 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-13 08:46:12 +00:00
jljusten f703388007 edk2/MdeModulePkg/Universal/PcatRealTimeClockRuntimeDxe/PcRtc.c:
Add type casting to fix warning generated by the Intel compiler.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5187 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-08 16:53:42 +00:00
qhuang8 a8d0c20e7a Add doxygen style comments for functions in Partition & Disk IO modules.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5182 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-08 04:17:44 +00:00
qhuang8 61e334303b Add doxygen style comments for functions in English module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5179 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-08 03:10:39 +00:00
lgao4 ec35e997ad Enable storage of daylight saving and time zone data of SetTime() service, and fix bug of SetWakeupTime() service.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5168 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-06 05:38:06 +00:00
qwang12 391cdf43a2 Remove the non-standard definition: GLYPH_WIDTH and GLYPH_HEIGHT. All reference to these name should use the standard name defined in UEFI 2.1 specification which are EFI_GLYPH_WIDTH and EFI_GLYPH_HEIGHT
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5138 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-28 07:39:24 +00:00
qwang12 0898c57ce7 Remove the non-standard definition: GLYPH_WIDTH and GLYPH_HEIGHT. All reference to these name should use the standard name defined in UEFI 2.1 specification which are EFI_GLYPH_WIDTH and EFI_GLYPH_HEIGHT
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5137 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-28 07:38:25 +00:00
eric_tian 0ce1dd70a9 [Description]
add a judgement of whether the control command is equal with previous one or not.
[Impaction]
Judge if the control command is equaled with previous one. This handler can improve performance.
[Reference Info]
Currently the terminal driver outputs control commands upon user's request regardless of whether the new attribute is the same as previous one or not.
Actually, it could be implemented as only outputting control command when the new Attribute is different than previous one

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5113 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-22 09:11:43 +00:00
klu2 9ef1a3ca7d Use const qualify for Src pointer.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5092 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-18 04:21:49 +00:00
eric_tian 12618416ec [Description]
change the old code style to comply with Doxgen format
[Impaction]
add comments for every function
[Reference Info]
add comments to achieve the highest standard of code quality matrix

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5079 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-17 08:28:51 +00:00