Commit Graph

1439 Commits

Author SHA1 Message Date
klu2 acd3b0e62d Fix EBC build broken.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7533 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-17 05:36:10 +00:00
qhuang8 20bcdbcb69 Add assertion to ensure pointer dereference has been checked against NULL pointer.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7528 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-16 02:07:32 +00:00
gikidy 055f28d0fb Meta-data reviewed.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7523 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-13 08:38:34 +00:00
vanjeff 7174e04c2b 1.enhanced security check.
2.remove un-necessary ASSERT.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7522 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-13 06:39:44 +00:00
vanjeff 89c18a1e9e enhanced security check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7520 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-13 06:07:36 +00:00
lgao4 1fef733cc7 Fix security check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7519 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-13 05:20:55 +00:00
jji4 2fead09fae Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7518 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-13 05:16:31 +00:00
jji4 e67ca95c86 Source level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7517 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-13 03:57:46 +00:00
vanjeff db0bd81c85 enhanced security check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7516 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-13 03:36:02 +00:00
jljusten 4ad9d87d7a * MdeModulePkg/Core/Pei/Dependency/Dependency.h
Decrease MAX_GRAMMAR_SIZE from 256 to 64.

In Dependency.c => PeimDispatchReadiness, a local variable 'EvalStack'
makes an array of EVAL_STACK_ENTRY structures to store a stack for
processing the dependency expression.

Due to alignment considerations, sizeof (EVAL_STACK_ENTRY) is 16 bytes 
on 64 bit architectures.  This means the size of the EvalStack local
variable in PeimDispatchReadiness grows to 4kb.

In the PEI phase, the stack area may be very small, and therefore 4kb is 
much to large.  Reducing MAX_GRAMMAR_SIZE to 64 will lower the size
of EvalStack to 1kb.

While reducing this to 1kb solves an issue seen with GCC on X64, it is
still a large usage of stack for the PEI phase, and future improvements
may still need to be made.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7514 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 17:15:08 +00:00
eric_tian cb0b858d6e add assert logic to avoid Klocwork fake report
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7513 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 08:41:34 +00:00
eric_tian 525aded947 add assert logic to avoid Klocwork fake report
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7512 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:39:01 +00:00
eric_tian a1b749d074 add assert logic to avoid Klocwork fake report
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7511 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:23:15 +00:00
vanjeff c55426ab64 fixed comments missing.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7510 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:06:23 +00:00
vanjeff df80a83c8a enhanced security check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7509 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:05:08 +00:00
vanjeff 7c1bc8d656 Enhanced status return check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7508 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 03:03:47 +00:00
vanjeff e618d0cb67 add return value check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7507 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 02:33:23 +00:00
vanjeff 892b7f90c5 add NULL pointer check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7506 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 01:55:32 +00:00
qhuang8 4cfc3293c7 Fix the typo in comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7503 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 07:09:19 +00:00
qhuang8 96a5ac5b0d Adjust code to fix potential array out-bound issues.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7502 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 07:05:43 +00:00
qhuang8 51195fbe8c Remove several unicode in comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7501 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 06:02:54 +00:00
qhuang8 ead7e7dc74 Fix the potential illegal EBC opcode issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7500 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 06:01:07 +00:00
lgao4 98b15cf156 Include the missing Guid header file to refer the global Guid
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7498 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 04:57:42 +00:00
lgao4 8a3f79bf36 Add the missing Guid header file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7496 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 14:33:55 +00:00
lgao4 b998288321 Correct typo in comments, clean IfrSupportLib.h
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7494 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 13:32:19 +00:00
eric_tian fbbb42115c clean K8.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7492 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 09:56:23 +00:00
qwang12 a935a0d8b7 Add in ASSERT to avoid NULL point dereference.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7491 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 09:40:27 +00:00
xli24 dcbb35eb6c Add comments in DSC files to explain the function and design of components section.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7490 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 08:58:47 +00:00
vanjeff 05b1c4143c update meta.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7482 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 06:11:51 +00:00
qwang12 d1a54e2c3e ECC cleanup: Non-Boolean comparisons should use a compare operator (==, !=, >, < >=, <=)
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7481 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 05:29:17 +00:00
lgao4 2517435c8d Clean Network Driver to include Uefi.h, not PiDxe.h.
Network driver don't depend on PI definition.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7479 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 02:59:07 +00:00
niry 9cff2f8d36 Roll back the DEBUG mask change which cause SerialIo read_conf test item failure.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7477 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 01:22:19 +00:00
mdkinney ba5e88f965 Add parenthesis to expression to make order of operations clear
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7475 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 20:40:48 +00:00
lgao4 276a49b699 Clean up FaultTolerantWriteDxe to remove the duplicated definition.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7471 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 09:03:12 +00:00
niry 2374b9734b fix the operator priority bug.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7470 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 08:56:45 +00:00
qhuang8 8ed62a3035 Fix minor build issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7465 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 07:42:00 +00:00
qwang12 c410589ef1 K8: Add in ASSERT to detect possible NULL pointer dereference.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7462 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 06:34:43 +00:00
eric_tian fd0d484170 clean ecc
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7461 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 06:17:01 +00:00
jgong5 b2c0a17556 Pass ECC
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7460 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 06:08:46 +00:00
jji4 7b2207f058 Coding style checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7459 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:52:20 +00:00
jji4 7ae9c1ce8f Coding style checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7458 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:48:16 +00:00
jgong5 d59b8b55d7 fixed more issues by scrubbing.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7457 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:47:32 +00:00
eric_tian c24b392c30 fix ecc warning
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7456 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:37:46 +00:00
xli24 ed3a31b518 Pass ECC check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7455 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:34:53 +00:00
jji4 a676b86b67 Coding style checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7454 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:12:48 +00:00
jgong5 81b0761486 Synced function header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7453 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:11:15 +00:00
jgong5 f737cfb953 code scrub for UefiPxeBcDxe.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7452 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:07:34 +00:00
eric_tian 4de1f28761 fix ecc
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7451 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:00:13 +00:00
vanjeff 9006e2bbe7 update format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7450 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 04:38:53 +00:00
jji4 9e1f123a3a Code level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7449 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 04:08:16 +00:00