Commit Graph

1430 Commits

Author SHA1 Message Date
jljusten 4ad9d87d7a * MdeModulePkg/Core/Pei/Dependency/Dependency.h
Decrease MAX_GRAMMAR_SIZE from 256 to 64.

In Dependency.c => PeimDispatchReadiness, a local variable 'EvalStack'
makes an array of EVAL_STACK_ENTRY structures to store a stack for
processing the dependency expression.

Due to alignment considerations, sizeof (EVAL_STACK_ENTRY) is 16 bytes 
on 64 bit architectures.  This means the size of the EvalStack local
variable in PeimDispatchReadiness grows to 4kb.

In the PEI phase, the stack area may be very small, and therefore 4kb is 
much to large.  Reducing MAX_GRAMMAR_SIZE to 64 will lower the size
of EvalStack to 1kb.

While reducing this to 1kb solves an issue seen with GCC on X64, it is
still a large usage of stack for the PEI phase, and future improvements
may still need to be made.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7514 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 17:15:08 +00:00
eric_tian cb0b858d6e add assert logic to avoid Klocwork fake report
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7513 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 08:41:34 +00:00
eric_tian 525aded947 add assert logic to avoid Klocwork fake report
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7512 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:39:01 +00:00
eric_tian a1b749d074 add assert logic to avoid Klocwork fake report
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7511 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:23:15 +00:00
vanjeff c55426ab64 fixed comments missing.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7510 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:06:23 +00:00
vanjeff df80a83c8a enhanced security check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7509 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 06:05:08 +00:00
vanjeff 7c1bc8d656 Enhanced status return check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7508 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 03:03:47 +00:00
vanjeff e618d0cb67 add return value check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7507 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 02:33:23 +00:00
vanjeff 892b7f90c5 add NULL pointer check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7506 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-12 01:55:32 +00:00
qhuang8 4cfc3293c7 Fix the typo in comments
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7503 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 07:09:19 +00:00
qhuang8 96a5ac5b0d Adjust code to fix potential array out-bound issues.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7502 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 07:05:43 +00:00
qhuang8 51195fbe8c Remove several unicode in comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7501 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 06:02:54 +00:00
qhuang8 ead7e7dc74 Fix the potential illegal EBC opcode issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7500 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 06:01:07 +00:00
lgao4 98b15cf156 Include the missing Guid header file to refer the global Guid
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7498 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-11 04:57:42 +00:00
lgao4 8a3f79bf36 Add the missing Guid header file.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7496 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 14:33:55 +00:00
lgao4 b998288321 Correct typo in comments, clean IfrSupportLib.h
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7494 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 13:32:19 +00:00
eric_tian fbbb42115c clean K8.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7492 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 09:56:23 +00:00
qwang12 a935a0d8b7 Add in ASSERT to avoid NULL point dereference.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7491 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 09:40:27 +00:00
xli24 dcbb35eb6c Add comments in DSC files to explain the function and design of components section.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7490 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-10 08:58:47 +00:00
vanjeff 05b1c4143c update meta.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7482 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 06:11:51 +00:00
qwang12 d1a54e2c3e ECC cleanup: Non-Boolean comparisons should use a compare operator (==, !=, >, < >=, <=)
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7481 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 05:29:17 +00:00
lgao4 2517435c8d Clean Network Driver to include Uefi.h, not PiDxe.h.
Network driver don't depend on PI definition.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7479 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 02:59:07 +00:00
niry 9cff2f8d36 Roll back the DEBUG mask change which cause SerialIo read_conf test item failure.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7477 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-09 01:22:19 +00:00
mdkinney ba5e88f965 Add parenthesis to expression to make order of operations clear
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7475 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 20:40:48 +00:00
lgao4 276a49b699 Clean up FaultTolerantWriteDxe to remove the duplicated definition.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7471 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 09:03:12 +00:00
niry 2374b9734b fix the operator priority bug.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7470 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 08:56:45 +00:00
qhuang8 8ed62a3035 Fix minor build issue.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7465 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 07:42:00 +00:00
qwang12 c410589ef1 K8: Add in ASSERT to detect possible NULL pointer dereference.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7462 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 06:34:43 +00:00
eric_tian fd0d484170 clean ecc
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7461 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 06:17:01 +00:00
jgong5 b2c0a17556 Pass ECC
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7460 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 06:08:46 +00:00
jji4 7b2207f058 Coding style checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7459 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:52:20 +00:00
jji4 7ae9c1ce8f Coding style checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7458 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:48:16 +00:00
jgong5 d59b8b55d7 fixed more issues by scrubbing.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7457 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:47:32 +00:00
eric_tian c24b392c30 fix ecc warning
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7456 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:37:46 +00:00
xli24 ed3a31b518 Pass ECC check.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7455 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:34:53 +00:00
jji4 a676b86b67 Coding style checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7454 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:12:48 +00:00
jgong5 81b0761486 Synced function header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7453 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:11:15 +00:00
jgong5 f737cfb953 code scrub for UefiPxeBcDxe.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7452 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:07:34 +00:00
eric_tian 4de1f28761 fix ecc
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7451 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 05:00:13 +00:00
vanjeff 9006e2bbe7 update format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7450 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 04:38:53 +00:00
jji4 9e1f123a3a Code level security checked
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7449 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 04:08:16 +00:00
eric_tian 311a71b299 Cleanup K8 warning.
We need judge return status of CoreGetMemorySpaceMap() to avoid the generation of NULL pointer of MemorySpaceMap.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7448 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-06 03:58:04 +00:00
mdkinney 7cf027141f Use UEFI macros for PE/COFF image types
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7441 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-05 19:34:49 +00:00
lgao4 19f1707078 Remove FlashMap Ppi that has been replaced by Flash related PCDs.
Remove OperatorPresence Ppi that is only related to TCG driver, which should be not in this package.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7435 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-05 03:15:10 +00:00
qwang12 7b728d6273 Use TO_START and BY_START for UEFI driver model driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7431 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-04 07:59:50 +00:00
qwang12 17d6c2e782 3) Doxygen comment cleanup.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7430 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-04 07:02:05 +00:00
qwang12 e08d88c59e 3) Doxygen comment cleanup.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7429 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-04 06:59:23 +00:00
qwang12 597f4ee21c 1) Fix a typo in EhcMoniteAsyncRequests.
2) Code cleanup.
3) Doxygen comment cleanup.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7428 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-04 06:56:31 +00:00
lgao4 657abcff30 Enhance DxeCore to handle the all block sized allowed by the PI Specification and remove the assumption that the FV block size is always larger than the size of an FV Header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7426 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-04 03:37:14 +00:00
klu2 7459a41ec0 Fix typo in meta data.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7423 6f19259b-4bc3-4df7-8a09-765794883524
2009-02-03 13:34:10 +00:00