Commit Graph

635 Commits

Author SHA1 Message Date
eric_tian 356e635c15 [Description]
Memory may leak because the handles in IScsiUpdateDeviceList is not freed if the "iSCSIDeviceList" already exists
[Impaction]
add Free() func to free memory properly.
[Reference Info]
The Handles in IScsiUpdateDeviceList is not freed if the "iSCSIDeviceList" already exists

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5211 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-16 07:14:25 +00:00
qhuang8 ea7cb08c0a Minor coding style adjustment for DiskIo, Partition, English and Ebc modules.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5200 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-14 06:07:07 +00:00
qwang12 d29270810c Add in example on
1) how to add SAFE_DEFAULT and MFG_DEFAULT in a formset.
2) how to specify a MFG_DEFAULT for a checkbox.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5199 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-14 02:20:02 +00:00
qhuang8 708919bef7 Minor coding style adjustment for DxeIpl.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5197 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-13 09:09:41 +00:00
qhuang8 db405d1b89 Minor coding style adjustment for DxeCore.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5196 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-13 09:09:11 +00:00
qhuang8 366219abde Fix the prediction warnings in EBC.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5195 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-13 09:07:59 +00:00
qhuang8 8e3bc754c5 Add doxygen style comments for functions in EBC module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5194 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-13 08:46:12 +00:00
qhuang8 71f68914fa Fix the prediction warnings in DxeMain.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5190 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-09 07:52:58 +00:00
qhuang8 162ed59443 Add doxygen style comments for functions in DxeMain.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5189 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-09 07:08:30 +00:00
jljusten f703388007 edk2/MdeModulePkg/Universal/PcatRealTimeClockRuntimeDxe/PcRtc.c:
Add type casting to fix warning generated by the Intel compiler.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5187 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-08 16:53:42 +00:00
qhuang8 a8d0c20e7a Add doxygen style comments for functions in Partition & Disk IO modules.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5182 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-08 04:17:44 +00:00
qhuang8 61e334303b Add doxygen style comments for functions in English module.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5179 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-08 03:10:39 +00:00
qhuang8 91d92e2564 Add doxygen style comments for functions in DxeIpl.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5174 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-07 06:58:06 +00:00
qhuang8 cc582cffd1 Rename the confusing PCD.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5169 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-06 09:34:46 +00:00
lgao4 ec35e997ad Enable storage of daylight saving and time zone data of SetTime() service, and fix bug of SetWakeupTime() service.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5168 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-06 05:38:06 +00:00
qwang12 391cdf43a2 Remove the non-standard definition: GLYPH_WIDTH and GLYPH_HEIGHT. All reference to these name should use the standard name defined in UEFI 2.1 specification which are EFI_GLYPH_WIDTH and EFI_GLYPH_HEIGHT
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5138 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-28 07:39:24 +00:00
qwang12 0898c57ce7 Remove the non-standard definition: GLYPH_WIDTH and GLYPH_HEIGHT. All reference to these name should use the standard name defined in UEFI 2.1 specification which are EFI_GLYPH_WIDTH and EFI_GLYPH_HEIGHT
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5137 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-28 07:38:25 +00:00
qwang12 a0b629b12e Remove the non-standard definition: GLYPH_WIDTH and GLYPH_HEIGHT. All reference to these name should use the standard name defined in UEFI 2.1 specification which are EFI_GLYPH_WIDTH and EFI_GLYPH_HEIGHT
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5136 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-28 07:37:37 +00:00
eric_tian 0ce1dd70a9 [Description]
add a judgement of whether the control command is equal with previous one or not.
[Impaction]
Judge if the control command is equaled with previous one. This handler can improve performance.
[Reference Info]
Currently the terminal driver outputs control commands upon user's request regardless of whether the new attribute is the same as previous one or not.
Actually, it could be implemented as only outputting control command when the new Attribute is different than previous one

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5113 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-22 09:11:43 +00:00
eric_tian 152af594cc [Description]
modify the value pointed by NumberOfPages to accordance with IN&OUT modifier's syntax.
[Impaction]
add comments for NumberOfPages parameter and assign a correct value to it.
[Reference Info]
NumberOfPages is only updated inside the if statement on line 725. If buffer is big enough the actual number of pages occupied by the image is not returned

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5112 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-22 08:38:30 +00:00
klu2 30d3be341b Add missing library class declaration.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5100 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-21 03:42:38 +00:00
klu2 9ef1a3ca7d Use const qualify for Src pointer.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5092 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-18 04:21:49 +00:00
qhuang8 dd4047a51c [Description]:
Add a feature flag in Uhci & Ehci to disable legacy USB SMI.
[Impaction]:
  Platform integrator can choose to legacy USB SMI or not.
[Reference Info]
  EDK Tracker 1082

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5081 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-17 11:02:59 +00:00
eric_tian 12618416ec [Description]
change the old code style to comply with Doxgen format
[Impaction]
add comments for every function
[Reference Info]
add comments to achieve the highest standard of code quality matrix

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5079 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-17 08:28:51 +00:00
lgao4 eaf539d00f Change MAX_PPI_DESCRIPTORS to FixedPcd PcdPeiCoreMaxPpiSupported, the default value is 64. Maybe other platform requires more than 64 Ppi and set this Pcd value.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5061 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-14 05:39:13 +00:00
eric_tian 5c70cb3285 [Description]
solve the big file transfer issue using ISCSI
[Impaction]
change the control flow on IScsiExecuteScsiCommand  function
[Reference Info]
The original design incorrectly uses a timer (its span is usually 2 seconds) to ensure the timely execution of CMD PDU send by initiator. For example: When initiator delivers a CMD PDU(WRITE command) in which the ExpDataXferLength filed is larger than DataSegmentLength field, according to ISCSI protocol spec, the target will respond it with a R2T PDU which is followed by a sequential DATA-OUT PDUs. In this situation, the original code may loop to deal with the arrival packet until initiator receives a RESPONSE PDU or the timer is expired. This way may cause the bigger file is more likely to fail.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5044 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-11 07:20:05 +00:00
vanjeff 7b414b4ed6 1. add public functions header.
2. apply for doxgen format for file header.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5043 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-11 03:36:07 +00:00
vanjeff 987da59835 Move Undi driver to common section.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5042 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-11 03:15:32 +00:00
lgao4 bfaa7cd7fb Add comments for Tcg Platform protocol.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5040 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-11 02:03:41 +00:00
vanjeff fb0b259e4e apply for doxgen format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5038 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-10 08:49:28 +00:00
jljusten 1ecca4a5e1 MdeModulePkg/Universal/PlatformDriverOverride/PlatOverMngr/PlatOverMngr.c:
Apply r5008 to this code at its new location.

r5008 messsage:
  Fix warning on gcc by removing un-referenced static global variables.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5034 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 16:29:07 +00:00
jljusten 74345f685c MdeModulePkg/Library/PlatformBdsLibNull/PlatformBdsLibNull.inf:
Revert r4975.  A fix in the BaseTools code made this change
  unnecessary.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5033 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 16:26:37 +00:00
vanjeff ffa5008abb apply for doxgen format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5030 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 08:33:17 +00:00
lgao4 504214c487 Add comments and DoxyGen format for these files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5028 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 07:07:50 +00:00
lgao4 6cc9ca322c Add comments and DoxyGen format for these files.
Remove the unused module Crc32SectionExtractDxe, which is replaced by Crc32SectionExtract library instance.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5027 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 07:00:57 +00:00
qhuang8 13d40eddeb Update all files to follow doxygen style file header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5025 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 05:50:10 +00:00
qhuang8 d393bdda06 Update to follow doxygen style file header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5024 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 05:46:57 +00:00
qhuang8 1e354c0372 Add function headers & file header for public header files
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5023 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 05:44:04 +00:00
qhuang8 e2270e40a4 Add function headers & file header for PlatformBdsLib
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5022 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 05:41:16 +00:00
qhuang8 83d26a8193 Add function headers & file header for GenericBdsLib
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5021 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 05:40:48 +00:00
qhuang8 897f0eee20 Clean up BDS lib to remove assembly files, remove R8Lib.h & R8Lib.c by applying Mde Lib.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5020 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 05:39:18 +00:00
qhuang8 fd6a62f3bf Update all files to follow doxygen style file header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5019 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 05:38:12 +00:00
qhuang8 8dbae30dd7 Update all files to follow doxygen style file header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5018 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 05:36:17 +00:00
qhuang8 3b2dbece7c Update all files to follow doxygen style file header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5017 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 05:34:50 +00:00
vanjeff 234a9da3d5 git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5012 6f19259b-4bc3-4df7-8a09-765794883524 2008-04-09 02:15:41 +00:00
vanjeff a6f164a7e6 1. Create PlatformDriverOverride in Universal directory.
2. Move PlatformDriOverrideDxe and PlatOverMngr to this directory.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5011 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 02:09:51 +00:00
jljusten 1be0dda62d Fix warnings generated by gcc for ia32 builds:
'cast from pointer to integer of different size'
when casting from a pointer directly to a
64 bit number.  Added an intermediate cast to
UINTN.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5009 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-08 20:59:38 +00:00
jljusten b12b28ec75 edk2/MdeModulePkg/Application/PlatOverMngr/PlatOverMngr.c:
Fix warning on gcc by removing un-referenced
  static global variables.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5008 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-08 16:15:16 +00:00
vanjeff 20107d9067 remove commented code.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5007 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-08 09:40:14 +00:00
vanjeff 23d64dda6b 1.Port Platform driver override protocol utility application in MdeModulePkg.dsc.
2.Update PlatDriOverLib library to use EFI Loaded Image Device Path Protocol to avoid "reconnect -r" issue for Platform driver override utility application.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5006 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-08 09:34:21 +00:00