Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							91fa33eeca 
							
						 
					 
					
						
						
							
							BaseTools: Replace Binary File type strings with predefined constant  
						
						... 
						
						
						
						BINARY_FILE_TYPE_FW was 'FW'
BINARY_FILE_TYPE_GUID was 'GUID'
BINARY_FILE_TYPE_PREEFORM was 'PREEFORM'
BINARY_FILE_TYPE_UEFI_APP was 'UEFI_APP'
BINARY_FILE_TYPE_UNI_UI was 'UNI_UI'
BINARY_FILE_TYPE_UNI_VER was 'UNI_VER'
BINARY_FILE_TYPE_LIB was 'LIB'
BINARY_FILE_TYPE_PE32 was 'PE32'
BINARY_FILE_TYPE_PIC was 'PIC'
BINARY_FILE_TYPE_PEI_DEPEX was 'PEI_DEPEX'
BINARY_FILE_TYPE_DXE_DEPEX was 'DXE_DEPEX'
BINARY_FILE_TYPE_SMM_DEPEX was 'SMM_DEPEX'
BINARY_FILE_TYPE_TE was 'TE'
BINARY_FILE_TYPE_VER was 'VER'
BINARY_FILE_TYPE_UI was 'UI'
BINARY_FILE_TYPE_BIN was 'BIN'
BINARY_FILE_TYPE_FV was 'FV'
v2 - split apart FV and GUID types with different meanings.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-05-02 15:01:43 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							be409b6756 
							
						 
					 
					
						
						
							
							BaseTools: Replace PCD type strings with predefined constant  
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-05-02 14:59:25 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							eece4292ac 
							
						 
					 
					
						
						
							
							BaseTools: DataType - cleanup list constants  
						
						... 
						
						
						
						remove unused ones
convert lists used for membership testing to sets
use shared ones not local ones
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-05-02 14:59:20 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							0c60e60b18 
							
						 
					 
					
						
						
							
							BaseTools: Replace EDK Component strings with predefined constant  
						
						... 
						
						
						
						EDK_COMPONENT_TYPE_LIBRARY was 'LIBRARY'
EDK_COMPONENT_TYPE_SECURITY_CORE was 'SECURITY_CORE'
EDK_COMPONENT_TYPE_COMBINED_PEIM_DRIVER was 'COMBINED_PEIM_DRIVER'
EDK_COMPONENT_TYPE_PIC_PEIM was 'PIC_PEIM'
EDK_COMPONENT_TYPE_RELOCATABLE_PEIM was 'RELOCATABLE_PEIM'
EDK_COMPONENT_TYPE_BS_DRIVER was 'BS_DRIVER'
EDK_COMPONENT_TYPE_RT_DRIVER was 'RT_DRIVER'
EDK_COMPONENT_TYPE_SAL_RT_DRIVER was 'SAL_RT_DRIVER'
EDK_COMPONENT_TYPE_APPLICATION was 'APPLICATION'
v2 - revert 2 files.  will update later in own patches.
v3 - fix v2
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-05-02 14:56:44 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							ee1ca53df6 
							
						 
					 
					
						
						
							
							BaseTools: Share a dictionary instead of keeping multiples  
						
						... 
						
						
						
						Move a dictionary to a shared location and use from there
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-05-02 14:56:34 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							88c6c1b64c 
							
						 
					 
					
						
						
							
							BaseTools: Define and use a set for common list  
						
						... 
						
						
						
						share a set for both PEI module types
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-05-02 14:56:33 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							8bb63e377b 
							
						 
					 
					
						
						
							
							BaseTools: replace string constants used for module types  
						
						... 
						
						
						
						replace raw strings in the code (note: except UPT) with constants.
SUP_MODULE_BASE was 'BASE'
SUP_MODULE_SEC was 'SEC'
SUP_MODULE_PEI_CORE was 'PEI_CORE'
SUP_MODULE_PEIM was 'PEIM'
SUP_MODULE_DXE_CORE was 'DXE_CORE'
SUP_MODULE_DXE_DRIVER was 'DXE_DRIVER'
SUP_MODULE_DXE_RUNTIME_DRIVER was 'DXE_RUNTIME_DRIVER'
SUP_MODULE_DXE_SAL_DRIVER was 'DXE_SAL_DRIVER'
SUP_MODULE_DXE_SMM_DRIVER was 'DXE_SMM_DRIVER'
SUP_MODULE_UEFI_DRIVER was 'UEFI_DRIVER'
SUP_MODULE_UEFI_APPLICATION was 'UEFI_APPLICATION'
SUP_MODULE_USER_DEFINED was 'USER_DEFINED'
SUP_MODULE_SMM_CORE was 'SMM_CORE'
SUP_MODULE_MM_STANDALONE was 'MM_STANDALONE'
SUP_MODULE_MM_CORE_STANDALONE was 'MM_CORE_STANDALONE'
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-05-02 14:56:31 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							6553c61724 
							
						 
					 
					
						
						
							
							BaseTools: GenFds - simplify testing for Hex number  
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-26 14:44:35 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							dc2c30ef92 
							
						 
					 
					
						
						
							
							BaseTools: remove duplicate variable  
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-26 14:44:34 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							b813843cca 
							
						 
					 
					
						
						
							
							BaseTools: simplify if call  
						
						... 
						
						
						
						the variable is a string type since we just used .strip() on it.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-26 14:36:05 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							1eb72acddd 
							
						 
					 
					
						
						
							
							BaseTools: Share RegEx between files  
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-26 14:27:59 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							6686d9a125 
							
						 
					 
					
						
						
							
							BaseTools: Misc - refactor RegEx to minimize multiple compiling  
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-26 14:27:58 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							656d2539be 
							
						 
					 
					
						
						
							
							BaseTools: replace 'UINT8','UINT16','UINT32','UINT64','VOID*' with shared constants.  
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-23 11:11:20 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							66d04638e5 
							
						 
					 
					
						
						
							
							BaseTools: remove EdkIIWorkspace as its not used.  
						
						... 
						
						
						
						v2 - update makefile too.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-23 11:08:24 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							25598f8bdb 
							
						 
					 
					
						
						
							
							BaseTools: merge towards minimum PCD MAX <something> methods  
						
						... 
						
						
						
						we have 5 different max val or max byte for PCDs.
refactor and remove 2 methods.
we need 3, as one computes for VOID* PCDs.
Cc: Bob Feng <bob.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-18 22:15:36 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							9eb87141ec 
							
						 
					 
					
						
						
							
							BaseTools: refactor and remove un-needed use of .keys() on dictionaries  
						
						... 
						
						
						
						sometimes just delete it.
sometimes the loop needed .values() instead
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-18 22:15:36 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							55c84777ee 
							
						 
					 
					
						
						
							
							BaseTools: use predefined constants instead of local strings  
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-18 22:15:35 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							5f446994a2 
							
						 
					 
					
						
						
							
							BaseTools: Remove un-needed list comprehension  
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-18 22:15:34 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							4d3b9389e7 
							
						 
					 
					
						
						
							
							BaseTools: use existing shared variable  
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-17 20:48:51 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							13d909f89a 
							
						 
					 
					
						
						
							
							BaseTools: Remove unneeded files  
						
						... 
						
						
						
						These files are not used by any tool:
BaseTools/Source/Python/Common/DecClassObject.py
BaseTools/Source/Python/Common/DscClassObject.py
BaseTools/Source/Python/Common/FdfClassObject.py
BaseTools/Source/Python/Common/InfClassObject.py
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-10 14:28:45 +08:00 
						 
				 
			
				
					
						
							
							
								Feng, YunhuaX 
							
						 
					 
					
						
						
						
						
							
						
						
							e96995a134 
							
						 
					 
					
						
						
							
							BaseTools: Remove EdkIIWorkspaceBuild.py from source code  
						
						... 
						
						
						
						Remove EdkIIWorkspaceBuild.py from source code
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-10 14:28:17 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							eb2c0b2c80 
							
						 
					 
					
						
						
							
							BaseTools: remove uncalled functions  
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-10 10:00:00 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							ce3082a6e7 
							
						 
					 
					
						
						
							
							BaseTools: remove unused file  
						
						... 
						
						
						
						ToolsDefClassObject didnt need Dictionary, it needed an import from there.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-10 09:58:08 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							175a4b5db3 
							
						 
					 
					
						
						
							
							BaseTools: dont make temporary dict  
						
						... 
						
						
						
						just make the key list directly
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-09 14:02:57 +08:00 
						 
				 
			
				
					
						
							
							
								Feng, YunhuaX 
							
						 
					 
					
						
						
						
						
							
						
						
							95cc496216 
							
						 
					 
					
						
						
							
							BaseTools: Remove FdfParserLite.py from source since it is not used  
						
						... 
						
						
						
						Remove FdfParserLite.py from source code since it is not used.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-09 11:10:51 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							e6c2468a9e 
							
						 
					 
					
						
						
							
							BaseTools: move RegEx to root of file and share it  
						
						... 
						
						
						
						make it easy to import and use by others
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-08 16:33:03 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							7da06eeede 
							
						 
					 
					
						
						
							
							BaseTools: Add new RegEx pattern to GlobalData  
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-08 15:34:11 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							ab0ff0b0a6 
							
						 
					 
					
						
						
							
							BaseTools: Remove unused code from Misc  
						
						... 
						
						
						
						remove the functions and classes
remove any imports of these
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-08 14:50:18 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							6e6d767edf 
							
						 
					 
					
						
						
							
							BaseTools: use built in OrderedDict instead of custom version.  
						
						... 
						
						
						
						We dont use any feature added by custom dictionary class.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-08 14:50:17 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							5bcf1d5671 
							
						 
					 
					
						
						
							
							BaseTools: make static functions when self is not needed  
						
						... 
						
						
						
						remove self, and add @staticmethod to functions
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-03 17:38:42 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							231fdbb210 
							
						 
					 
					
						
						
							
							BaseTools: remove uncalled function  
						
						... 
						
						
						
						no one calls __IsWhiteSpace() (none of the 4 copies)
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-03 17:38:10 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							cfbe3c3500 
							
						 
					 
					
						
						
							
							BaseTools: change hex parsing to use built in  
						
						... 
						
						
						
						use <char> in string.hexdigits instead of custom functions.
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-03 17:37:33 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							4f9e71e1f7 
							
						 
					 
					
						
						
							
							BaseTools: use single RegExp for token matching  
						
						... 
						
						
						
						same pattern was compiled 3 places in the file.  just compile once and share.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-04-03 17:35:31 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							0b560b980c 
							
						 
					 
					
						
						
							
							BaseTools: cleanup class heirarchy  
						
						... 
						
						
						
						remove totally empty classes from class heirarchy
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-30 09:17:30 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							5fbb0f9908 
							
						 
					 
					
						
						
							
							BaseTools: remove loop and variables.  
						
						... 
						
						
						
						this loop does nothing. none of Key, Item, nor DevicePathList
are ever used.
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-30 09:17:09 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							0a014fba41 
							
						 
					 
					
						
						
							
							BaseTools: use in to compare single chars  
						
						... 
						
						
						
						instead if 3 Startswith for single chars, just use in with a list of chars
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-30 09:16:27 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							0944818a19 
							
						 
					 
					
						
						
							
							BaseTools: no need to do int() API work for it  
						
						... 
						
						
						
						int() with base=0 will already auto determine base from preceeding 0x/0X
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-30 09:16:01 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							4231a8193e 
							
						 
					 
					
						
						
							
							BaseTools: Remove equality operator with None  
						
						... 
						
						
						
						replace "== None" with "is None" and "!= None" with "is not None"
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-30 08:25:13 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							cc0321f22a 
							
						 
					 
					
						
						
							
							BaseTools: refactor repeated RegExp when no special searching is needed.  
						
						... 
						
						
						
						use str.replace and try/except.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-29 16:33:55 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							e52aed0d85 
							
						 
					 
					
						
						
							
							BaseTools: dont use enumerate when un-needed  
						
						... 
						
						
						
						Since we only use the item from the list and not the numeric value,
dont bother with enumerate()
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-29 16:31:24 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							38504ad3e3 
							
						 
					 
					
						
						
							
							BaseTools: move regular expression compile out of function call.  
						
						... 
						
						
						
						move to the root of the file and dont recompile.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-29 16:28:43 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							663b9e061e 
							
						 
					 
					
						
						
							
							BaseTools: expression can use single in instead of 3 API calls.  
						
						... 
						
						
						
						change 3 StartsWith() calls to a single 'in' operation.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-29 16:28:11 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							56326323e6 
							
						 
					 
					
						
						
							
							BaseTools: remove local hex number regular expression  
						
						... 
						
						
						
						Change to using the new shared hex number regular expression
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-29 16:26:38 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							b1a9e404d4 
							
						 
					 
					
						
						
							
							BaseTools: use new shared GUID regular expressions  
						
						... 
						
						
						
						remove local variables that are GUID matching and replace with shared
expression.
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-29 16:18:29 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							0760ed06a1 
							
						 
					 
					
						
						
							
							BaseTools: GlobalData Add a regular expression for a hex number  
						
						... 
						
						
						
						add a shared precompiled regular expression
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-29 10:17:46 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							9e7790a352 
							
						 
					 
					
						
						
							
							BaseTools: Add new RegExp for future use  
						
						... 
						
						
						
						Add a precompiled RegExp for 4 hex chars.
v2: fixed incorrect numbers of {}
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-29 08:55:09 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							256e2d885b 
							
						 
					 
					
						
						
							
							BaseTools: Regular Expressions refactor out the hex char for later reuse  
						
						... 
						
						
						
						move hex character info from GUID expressions into seperate variable to
facilitate reuse.
I had a type with insufficient {} in the first version.
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-29 08:54:35 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							cd67d66484 
							
						 
					 
					
						
						
							
							BaseTools: add GUID pattern to global data  
						
						... 
						
						
						
						add a shared global regular expression for GUID matching
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-29 08:36:06 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							0f17c9fef1 
							
						 
					 
					
						
						
							
							BaseTools: GlobalData share same MACRO name definition  
						
						... 
						
						
						
						use the same MACRO name definition across shared regular expression patterns.
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-29 08:35:17 +08:00 
						 
				 
			
				
					
						
							
							
								Carsey, Jaben 
							
						 
					 
					
						
						
						
						
							
						
						
							4d603daa3a 
							
						 
					 
					
						
						
							
							BaseTools: FdfParser and FdfParserLite share reg exp  
						
						... 
						
						
						
						FdfParser can share regular expression from FdfParserLite.
reduce overlap and reduce recompile of the same expression.
v2: fix missed replacement of Pattern with shared variable
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 
						
						
					 
					
						2018-03-29 08:34:09 +08:00