Commit Graph

228 Commits

Author SHA1 Message Date
xli24 d405baa0b6 Refine comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8858 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-10 03:53:02 +00:00
xli24 3ae0837720 Refine comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8857 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-10 03:41:20 +00:00
xli24 a5baf84537 Keep inconsistency in code and add additional comments for that.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8856 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-10 03:28:16 +00:00
mdkinney 2997220ab7 Remove structure declaration for EFI_UGA_PIXEL.
This structure is already defined in MdePkg/Include/Protocol/UgaDraw.h and this extra declaration is generating build breaks for a redefinition


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8847 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 23:26:39 +00:00
jchen20 6d1824fc6e Add comments to describe the difference between code and spec to fix the bug #202430
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8839 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 10:27:43 +00:00
jchen20 e89985504d Add comments to describe the difference between code and spec to fix the bug #202409
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8838 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 09:56:42 +00:00
jchen20 18d7ae2ee6 describe the difference with Spec to fix the bug #202465
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8837 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 09:41:35 +00:00
jchen20 b59768ca63 Add definition on SmmStatusCodeProtocol to comply the SMMCIS spec to fix the bug #202466
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8834 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 09:17:18 +00:00
jchen20 da879e3f7d Add comments to describe the difference with Spec to fix the bug #202466
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8833 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 09:13:30 +00:00
jchen20 220c61c1ee Add the FRAMEWORK_EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL definition to comply with Framework spec
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8831 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 07:43:00 +00:00
xli24 56fd2fa44c Refine the comments to describe inconsistency between code and spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8830 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 07:22:06 +00:00
vanjeff 2a924b007f updated comments per review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8827 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 03:03:32 +00:00
jchen20 a69dbb0e9e the Comment the gap between Framework spec and code in the definition of FRAMEWORK_EFI_PEI_SERVICES
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8826 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-09 02:19:02 +00:00
eric_tian 13b3137440 according to DataHubSubclass spec, all fields of data record should be naturally alignment.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8821 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 09:56:07 +00:00
jchen20 66ea28dffd to describe the gap between Framework spec and code to fix the bug #202434
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8820 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 09:49:07 +00:00
jchen20 40038403ea to fill the gap between Framework and code to fix the bug #202405, #202419, #202418, #202435,#202437, #202439, #202440
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8817 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 09:38:08 +00:00
eric_tian 631344e6d3 refine the DataHubRecords.h to comply with DataHubSubclass/MemSubclass/ProcSubclass/CacheSubclass spec.
add comments to notify there are gaps between code and specs.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8808 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 07:17:48 +00:00
jchen20 fdf3ad8135 Add comments to indicate the gap with Framework Spec
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8807 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 07:08:53 +00:00
eric_tian 1dae824768 refine the file header comment on FrameworkDxe.h
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8805 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 04:40:59 +00:00
eric_tian 4c617fa92b 1. add comments for those fields not defined by MemorySubclass spec.
2. change name MemorySpeed to MemoryTypeSpeed, which follows spec.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8804 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 04:32:40 +00:00
eric_tian 6b7058c4df Inconsistent with specification here:
It's a typo of MiscSubclass 0.9 spec. It should be a variable name "ChassisType" rather than a type "EFI_MISC_CHASSIS_TYPE".

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8803 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:59:53 +00:00
eric_tian eeff6bb017 1. EFI_MAXIMUM_CACHE_SIZE_DATA has changed to EFI_CACHE_MAXIMUM_SIZE_DATA, which follows spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8802 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:52:36 +00:00
eric_tian dcd8fb0c2b add comments to note it's the spec typo issue for EFI_CACHE_CONFIGURATION_DATA filed type. it should be UINT32 rather than UINT16
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8801 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:47:10 +00:00
eric_tian 2cbfdae36e add comment on EFI_PROCESSOR_CORE_FREQUENCY_LIST_DATA to note there is gap between code and spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8800 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:44:09 +00:00
lgao4 3f17e6d73e Add comments for the inconsistent definition with framework specification.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8798 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:41:46 +00:00
eric_tian 2b47aaa69c add comments to note why EFI_MISC_PORT_DEVICE_PATH and etc exists here , which is not defined in MiscSubclass spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8797 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:38:23 +00:00
eric_tian 905574d8a0 update the file header comment
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8796 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:26:32 +00:00
eric_tian 500764753c Inconsistent with specification here:
This field in StatusCodes spec0.9 is defined as UINT32, keep code unchanged.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8795 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:20:57 +00:00
eric_tian b66be4ca3e 1. change the value of EFI_PROCESSOR_SUBCLASS_VERSION to follow spec.
2. remove EFI_STRING_TOKEN, which doesn't be defined by any spec. replace it with STRING_REF.
3. change the fields of EFI_EXP_BASE10_DATA to INT16 to follow spec.
4. change the field name of EFI_PROCESSOR_MISC_INFO to follow spec.
5. note that field which are introduced to reflect the SMBIOS2.6
6. change name EFI_PROCESSOR_HEALTH_STATUS to EFI_PROCESSOR_HEALTH_STATUS_DATA
7. EFI_CACHE_ASSOCIATION_DATA to  EFI_PROCESSOR_CACHE_ASSOCIATION_DATA

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8793 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:10:27 +00:00
xli24 99caac3b19 Add [in], [out] tag for function description.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8792 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 03:05:55 +00:00
xli24 ee896758cc Add comments to describe inconsistency between code and Framework spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8791 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 02:44:46 +00:00
xli24 50877421ea Add comments to describe inconsistency between code and Framework spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8790 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-08 02:39:04 +00:00
eric_tian ee09c93f45 change comment style from 3 line to 1 line
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8784 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-07 07:49:14 +00:00
vanjeff 574bb8b749 Add IncompatiblePciDeviceSupportDxe module in IntelFrameworkModulePkg.
This module provided one typical incompatible PCI device list to be one template and install EFI incompatible PCI device support protocol.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8783 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-07 07:09:31 +00:00
eric_tian 7c6b044003 1. cleanup to refine the doxgen comment.
2. remove unused macro EFI_VARIABLE_READ_ONLY, which is not define by PeiCIS spec.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8782 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-07 07:04:59 +00:00
eric_tian cb8df8c596 supply comments on data structure to follow spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8779 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-07 06:36:42 +00:00
eric_tian 7bfed576b0 Due to SmBios2.6 spec section 3.3.8.5 doesn't enumerate 24-way set-associative for cache info, so remove this value to follow spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8772 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-07 03:35:59 +00:00
klu2 ef1ac01521 Refine comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8765 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-07 02:15:40 +00:00
xli24 444bf90deb Refine include file of GUID HOB for SMRAM memory reserve, according to review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8763 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-06 15:09:45 +00:00
xli24 918294597a Refine include file for Device Recovery Module PPI.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8758 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-06 06:06:15 +00:00
xli24 ebcfa88032 Refine include file for SMM Base Protocol.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8756 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-06 04:02:37 +00:00
jchen20 18998e40a5 Fixed bug 202575. mainly follow Doxygen rule
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8755 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-06 03:33:08 +00:00
xli24 c7d5f35f1f Add space for alignment.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8754 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-06 03:27:59 +00:00
vanjeff 516e9f2863 updated function headers.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8753 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-06 03:15:53 +00:00
xli24 e5fe626f52 Add tag of in/out for @param comments in function header.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8751 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-06 03:00:59 +00:00
vanjeff 8ba0729797 add detailed description for functions.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8748 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-06 02:22:21 +00:00
darylm503 fab84ef535 Clean up formatting and some Doxygen comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8746 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 23:40:55 +00:00
darylm503 dbb698cbb5 Clean up Doxygen group comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8745 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 23:20:37 +00:00
darylm503 03df16089f Clean up Doxygen commenting.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8743 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 21:59:06 +00:00
mdkinney 2cec3ea527 Change FRAMEWORK_EFI_HII_CALLBACK_PACKET back to EFI_HII_CALLBACK_PACKET to match Framework HII 0.92 Specification
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8741 6f19259b-4bc3-4df7-8a09-765794883524
2009-07-03 20:14:12 +00:00