Commit Graph

242 Commits

Author SHA1 Message Date
mdkinney 7b3381a232 Clean up
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6676 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-22 00:51:51 +00:00
klu2 1232b21473 1, Add <Library/DevicePathLib.h> for all source that use device path utility macros
2, Add DevicePathLib library class to module's INF that use device path utility macros

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6456 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-11 15:42:40 +00:00
klu2 0ddec2cfde Remove over specific Guid
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6384 6f19259b-4bc3-4df7-8a09-765794883524
2008-11-05 02:25:26 +00:00
qhuang8 da06ac1c70 Add missing TimerLib class since DxeMain directly use TimerLib API.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6345 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-31 04:53:07 +00:00
mdkinney 7cff25d649 Measure time spent in Driver Binding Supported() calls
Update time measurement of StartImage() calls to properly record the handle of the started Image


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6292 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-30 04:03:59 +00:00
eric_tian e34ecc8a1e Remove unnessary UEFI_SPECIFICATION_VERSION and PI_SPECIFICATION_VERSION in INF file
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6281 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-29 03:17:21 +00:00
xli24 405b567555 Refine file header for INF files of DXE and PEI core modules.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6276 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-28 13:16:21 +00:00
vanjeff 078bee4ebf clean up EBC in inf files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6267 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-28 07:17:17 +00:00
qwang12 44cfd8a827 Move global variable to the top of C file for consistent coding style.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6255 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-27 11:40:49 +00:00
qwang12 0e549d5be5 Make use of correct format String:
1) UINT64 should use %lx
2) POINTER type should use %p
3) EFI_STATUS should use %r


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6253 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-27 10:13:00 +00:00
vanjeff 43025b293f ECC Clean up.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6205 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-24 02:55:01 +00:00
qhuang8 6e53646837 Fix several coding style violations
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6163 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-21 03:11:47 +00:00
klu2 e97835ba3f Change PeiMain/DxeMain's base name to PeiCore/DxeCore.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6073 6f19259b-4bc3-4df7-8a09-765794883524
2008-10-05 13:32:39 +00:00
qhuang8 2f2a277df4 1. Set the EFI_DEBUG_IMAGE_INFO_TABLE_MODIFIED bit on insertion/deletion of entries in DebugImageInfo Table.
2. Change field EFI_DEBUG_IMAGE_INFO_TABLE_HEADER.TableSize to be the number of valid entries. Apply another global variable mMaxTableEntries to track the maximum of the allocated entires.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6051 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-27 08:02:57 +00:00
eric_tian dc8d93ca0c add detail comments on the complicated code segment.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5954 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-23 14:49:45 +00:00
eric_tian ec90508b3d move header files in MdeModulePkg\Core\Dxe except DxeMain.h into their corresponding sub-module directories. It is used to provide good modularity.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5949 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-23 07:35:34 +00:00
lgao4 1046284db9 Don't align image address for TeImage, because TeImage section alignment is undefined.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5948 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-23 07:16:46 +00:00
qwang12 4792a1a65b Rollback change done in 5919: "Remove the status code EFI_ALREADY_STARTED to avoid confusion since it is not a possible return status from LoadFile() interface." It is accidentally overwritten in last check-in.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5925 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-18 09:03:36 +00:00
qwang12 61ad8a41e7 Remove the GrowBuffer function. Just use the simple way to get the buffer size and then read the buffer. This change improve the readability and save 0x60 byte of data for release build according to MAP file generated for X64 arch.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5924 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-18 08:42:11 +00:00
qhuang8 d9177625f6 Adjust the function layout to remove the prototype of internal functions to reduce sync efforts.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5921 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 14:20:29 +00:00
qhuang8 e676c4d0c6 Apply HighBitSet() in MDE baseLib to retire the internal function CoreHighestSetBit().
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5920 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:35:14 +00:00
qhuang8 2ce854f515 Remove the status code EFI_ALREADY_STARTED to avoid confusion since it is not a possible return status from LoadFile() interface.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5919 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:34:18 +00:00
qhuang8 f94b9be34f Adjust the function layout of Timer.c to remove the prototype to reduce sync efforts.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5918 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:32:52 +00:00
qhuang8 3f1435782f Refine code to remove the last entry of mArchProtocol.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5917 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:31:43 +00:00
qhuang8 57b4ecb94b Fix several code review minor comments:
1. Line 79:Use the pre-initialized global variable mPoolHeadList = INITIALIZE_LIST_HEAD_VARIABLE (mPoolHeadList) to remove the statement in line 102
2. Line 337: The debug print statement: “Addr = %x” should change to “Addr = %p” since the expected Buffer is VOID *; How about “(len %x) %,d” ? The Size & Pool->Used belong to type UINTN? Cast it to UINT64 and use %lx 
3.Line 413, 418, 425, 477: Use “Buffer != NULL” instead of “NULL != Buffer”  
4. Line 451: The debug print statement: “FreePool = %x” should change to FreePool = %p” since Head->Data is pointer; How about “(len %x) %,d” ? The Head->Size& Pool->Used belong to type UINTN? Cast it to UINT64 and use %lx 


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5916 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:29:44 +00:00
qhuang8 d45fd26026 Fix several code review minor comments:
1.Line 1520, 1525, 1530:Use goto to save Release Lock
2.Line 224: Do not use DEBUG_ERROR, since it is not an error case
3.Scrub the DEBUG () print statement to add DEBUG_PAGE
4.Line 20: Typo of "help cooalese"


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5915 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 13:28:05 +00:00
qwang12 a70c0fd846 Add VA_END to end the VA_START.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5907 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 02:30:24 +00:00
qwang12 46fee0d7b6 Remove the unnecessary spin_lock protection around CoreUnloadImage. There is almost zero possibility for this reentrancy issue here. With this change, we also keep EDK 2 and EDK core's CoreUnloadImage consistent with each other.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5906 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-17 02:20:24 +00:00
eric_tian 11074aabe1 CoreHandleProtocol function description should be corrected.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5903 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 08:02:57 +00:00
eric_tian 1947c70c3e Merge the global data in ExecData.c to Event.c
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5901 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 07:53:15 +00:00
eric_tian c18f12d375 Comments for CoreInitializeMemoryServices should be updated
Comments for CoreInitializeGcdServices should be updated.
Comments for CoreInitializeEventServices should be updated.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5899 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 07:35:17 +00:00
eric_tian 5f3232d7e8 The file name Exec.h contains UEFI Event support functions and structure. But its file name is not very meaningful and we can consider renaming it.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5898 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 07:22:44 +00:00
eric_tian 1349236994 follow up the comments from code review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5891 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 05:19:25 +00:00
qhuang8 7899b79715 Remove the internal CoreCreateProtocolNotifyEvent() in DxeCore, for UefiLib provide the similar function EfiCreateProtocolNotifyEvent(). DxeCore can use that library function.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5883 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-12 01:12:31 +00:00
qhuang8 f0d5cbb66a Update the usage of ALIGN_VARIABLE for the interface change.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5870 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 16:05:24 +00:00
qwang12 fa3c419fec Fix a bug by adding CoreReleaseProtocolLock.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5866 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 06:30:40 +00:00
qhuang8 3b6ffb6a13 Add EFIAPI modifier for all GCD services APIs
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5865 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 03:25:49 +00:00
qhuang8 c0a23f8c37 Remove the prototype of internal functions to avoid the sync efforts.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5861 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 05:36:40 +00:00
qwang12 130f16022c Rename Hand.h to Handle.h.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5860 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 05:29:23 +00:00
qwang12 c79be85e9d Adjust the field position of PROTOCOL_NOTIFY.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5858 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 05:19:46 +00:00
qwang12 6c857d668c 1) Update some comment.
2) Add in handle for the out_of_resource cases
3) Add in Done label to clean up the code.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5853 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 02:39:44 +00:00
qhuang8 599979d4ce Remove unused global variable.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5852 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 01:50:38 +00:00
qhuang8 dbfb4b229c Remove two obsolete function prototypes.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5851 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 01:47:33 +00:00
qwang12 b9066aae25 Change field Handle to type IHANDLE to remove the type casting.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5846 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 12:50:40 +00:00
qwang12 4008328a99 Remove NULL_HANDLE. NULL_HANDLE should be replaced with NULL as consistency. For now, only DXE core is using this macro.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5836 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 05:02:38 +00:00
qwang12 7f932291b5 Add more comment for EFI_DEP_REPLACE_TRUE
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5833 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 02:00:38 +00:00
qwang12 7ffbd6182d Remove a dead macro EFI_DXESERVICE
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5832 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 01:55:51 +00:00
vanjeff 8ee3a19908 Updated EFI_FVB_ATTRIBUTES to EFI_FVB_ATTRIBUTES_2.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5800 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-03 08:55:55 +00:00
qhuang8 19e14fc9d9 1. Use AllocateAlignedPages() to remove tricky logic in DebugImageInfo.c
2. Add ReportStatusCodeLib instance in MdeModulePkg.dsc for DxeCore.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5774 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-02 05:51:05 +00:00
qhuang8 ceb9059cda clean up DxeCore to remove some dead code.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5764 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-01 11:32:49 +00:00
qhuang8 2680a30801 Clean up DxeCore to use report status code macros in ReportStatusCode to retire CoreReportProgressCode() & CoreReportProgressCodeSpecific() in Library.c in DxeCore.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5761 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-01 08:27:31 +00:00
qhuang8 de4e6bf963 Fix several approved code review comments:
1. Remove internal function prototypes to avoid sync efforts. The layout of them have been adjusted
2. Apply macro ALIGN_POINTER to get next section stream
3. Fix a potential memory leak issue.
4. Make the comparison between type UINTN and 0 consistent between one function.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5747 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-28 02:53:16 +00:00
qhuang8 9c4ac31cca Clean up DxeCore to remove duplicate memory allocation & device path utility services in Library.c.DxeCore should use MemoryAllocationLib & DevicePathLib for these API.
Minor cleanup the coding style: #include <DxeMain.h> should be changed to #include "DxeMain.h" since "DxeMain.h" is not pubic header fie.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5742 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-27 14:29:23 +00:00
qhuang8 070f0cf7f2 Add dependency of DevicePathLib to DxeCore so that the internal device path related APIs can be retired to avoid code duplication.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5738 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-27 13:48:11 +00:00
lgao4 e872988180 remove the unused msa files in MdeModulePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5726 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-25 05:03:29 +00:00
qhuang8 0e9b156ddc Remove the global variable of gDxeCoreBS and uses the gBS in UefiBootServicesTableLib for DXE Core.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5697 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-20 09:41:53 +00:00
qhuang8 4fdc91291e Add GLOBAL_REMOVE_IF_UNREFERENCED modifier in the array and change the protocol UI strings to ASCII string since they are only for debug purpose.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5672 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-18 08:40:52 +00:00
qhuang8 4e498a0f27 Remove an unreferenced field in PROTOCOL_INTERFACE data structure.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5670 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-18 08:39:05 +00:00
qwang12 1439777e96 1) Change DEBUG_ERROR TO DEBUG_LOAD as InstallProtocolInterface information is not an error.
2) Revert binary comparison for consistency.
3) Minor updates for comments.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5621 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-08 03:49:09 +00:00
mdkinney 51b02d81f0 Fix UEFI Boot Service CreateEvent() to follow UEFI Specification with respect to the use of TPL_APPLICATION
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5606 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-01 23:54:52 +00:00
mdkinney 911361242b Increase size of function addresses printed in DEBUG messages from 10 to 11 characters
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5602 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-01 22:41:20 +00:00
vanjeff 75b046c3d4 Using Spin lock instead of using RaiseTpl() to prevent UnloadImage() re-entrance.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5600 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-01 08:10:49 +00:00
qhuang8 443109389d Minor clean up.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5572 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-26 07:46:04 +00:00
qhuang8 022c6d45ef Code Scrub for Dxe Core.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5560 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-24 02:54:45 +00:00
qhuang8 e94a9ff727 Code scrub for DxeCore
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5520 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-18 09:50:09 +00:00
lgao4 5f597758e2 Code scrube for MdeModule Definitions.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5428 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-08 13:29:42 +00:00
qhuang8 6960e9ae7a Remove minor defects in Doxygen header
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5270 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-22 09:00:12 +00:00
vanjeff 57d6f36db6 add debug information.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5266 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 08:32:06 +00:00
qhuang8 23c98c9417 Update to fix minor coding style issues.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5256 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 01:40:12 +00:00
qhuang8 3b1d9fd579 Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5255 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 01:10:16 +00:00
qhuang8 b21f513659 Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5254 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 01:06:28 +00:00
qhuang8 1424518bd2 Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5253 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 01:05:39 +00:00
qhuang8 ae91108427 Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5252 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 01:05:17 +00:00
qhuang8 cc907d1264 Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5251 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 01:04:53 +00:00
qhuang8 ecc7f77e91 Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5250 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 01:04:28 +00:00
qhuang8 924c766d6f Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5249 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 01:03:34 +00:00
qhuang8 d614b00ae0 Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5248 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 01:02:35 +00:00
qhuang8 7ad23c3cea Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5247 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 01:02:02 +00:00
qhuang8 6cea0db87c Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5246 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 01:00:57 +00:00
qhuang8 3a610a1877 Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5245 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 01:00:25 +00:00
qhuang8 91ee5ef167 Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5244 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 00:59:13 +00:00
qhuang8 d4a9eca19a Change the file name case to follow coding style: The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5243 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 00:58:42 +00:00
qhuang8 4f1faae809 Change file name case to follow coding style:The first character should be capital.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5242 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-21 00:56:56 +00:00
qhuang8 db405d1b89 Minor coding style adjustment for DxeCore.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5196 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-13 09:09:11 +00:00
qhuang8 71f68914fa Fix the prediction warnings in DxeMain.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5190 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-09 07:52:58 +00:00
qhuang8 162ed59443 Add doxygen style comments for functions in DxeMain.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5189 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-09 07:08:30 +00:00
eric_tian 152af594cc [Description]
modify the value pointed by NumberOfPages to accordance with IN&OUT modifier's syntax.
[Impaction]
add comments for NumberOfPages parameter and assign a correct value to it.
[Reference Info]
NumberOfPages is only updated inside the if statement on line 725. If buffer is big enough the actual number of pages occupied by the image is not returned

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5112 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-22 08:38:30 +00:00
lgao4 504214c487 Add comments and DoxyGen format for these files.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5028 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-09 07:07:50 +00:00
jljusten 1be0dda62d Fix warnings generated by gcc for ia32 builds:
'cast from pointer to integer of different size'
when casting from a pointer directly to a
64 bit number.  Added an intermediate cast to
UINTN.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5009 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-08 20:59:38 +00:00
qhuang8 5fed8e341a Update DxeCore to load image wit supported machine types:
DXE Core          Supported Machine Types
=======          ===================
IA32                IA32, EBC, X64
X64                 X64, EBC, IA32
IPF                 IPF, EBC
EBC                 EBC



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4977 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-02 06:56:35 +00:00
eric_tian 88c8f7fbfd [Description]
spelling mistake
[Impaction]
modify the mistake
[Reference Info]
Found the spelling mistake in pool.c

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4949 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-24 07:11:37 +00:00
eric_tian 1564e9ac2c [Description]
Duplicate the device path prior to the access to it 
[Impaction]
directly access the device path may cause an exception when the device path includes some unaligned device path nodes
[Reference Info]
In the case of ISCSI, there is a situation that the device path may consists of some unaligned device path node. it causes the unaligned exception when we access the node.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4905 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-19 02:05:57 +00:00
lgao4 e10293550f A leaf section type may contains an array of zero or more bytes. Support the section with the zero data.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4852 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-14 10:12:17 +00:00
qhuang8 383c303c49 Fix two minor defects:
1. CoreGetMemoryMap() returns unclean data
2. Zero length memory descriptor might be added to the memory map

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4790 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-04 11:33:13 +00:00
lgao4 6cd7b51e48 Correct the PeImage Source file to be measured by TCG.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4787 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-04 09:32:41 +00:00
vanjeff ba39e316c9 1. Add EFI LOADED IMAGE DEVICE PATH Protocol in LoadImage() service, per UEFI 2.1b.
2. Update comments for DHCP.transmitreceive().
2. Update UefiPxeBcDxe.inf and PxeBcDxe.inf to assign correct protocol usages.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4758 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-26 08:38:29 +00:00
qhuang8 bb8ffffd1c Fix a conformance issue in gBS->CreateEvent() & gBS->CreateEventEx():
1. gBS->CreateEventEx() with EventGroup = NULL should behavior like gBS->CreateEvent()
2. EVT_SIGNAL_EXIT_BOOT_SERVICES & EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE are invalid parameters for gBS->CreateEventEx() if the EventGroup is not NULL.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4692 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-14 02:47:49 +00:00
jljusten d1f076304d MdeModulePkg/Core/Dxe/SectionExtraction/CoreSectionExtraction.c:
Surrounded unreferenced STATIC functions by '#if 0', '#endif' to
  prevent a compiler warning:
    NotifyGuidedExtraction, CreateGuidedExtractionRpnEvent


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4688 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-13 00:22:19 +00:00
qwang12 9226efe5eb 1) Cleanup HiiLib, IfrSupportLib.
2) Add ExtendedHiiLib and ExtendedIfrSupportLib which implement APIs that require the OPcode and Device Path which is specific to Intel's implementation.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4662 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-02 13:15:44 +00:00
qwang12 93e3992d1e UEFI HII: Merge UEFI HII support changes from branch.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4599 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-21 14:39:56 +00:00
lgao4 822360ee34 Measure PEimage and ActionString data according to TPM requirement.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4494 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-04 02:11:51 +00:00
lgao4 b2c5e194a8 Use AllocatePage for FvImage.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4385 6f19259b-4bc3-4df7-8a09-765794883524
2007-12-11 05:14:16 +00:00
lgao4 38837959db Move sure FvImage buffer at its alignment when install FVB protocol on it.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4380 6f19259b-4bc3-4df7-8a09-765794883524
2007-12-10 08:50:24 +00:00
klu2 797a9d6791 MdeModule cleanup for PI:
1) PeiMain:
   - Use PCD for bundle of status code which definitions are put into MdePkg.dec file.
2) DxeMain:
   - Use PCD for bundle of status code which definitions are put into MdePkg.dec file.
   - Do not produce SectionExtraction protocol which is belong to IntelFramework specification.
   - Update many macro for PI specifications.
3) DxeIpl
   - Use PCD for bundle of status code which definitions are put into MdePkg.dec file.
4) Add SectionExtractionDxe module (IntelFrameworkModulePkg)
   - This module will produce EFI_SECTION_EXTRACTION_PROTOCOL defined in framework specification. If a old platform want to use this protocol, then this platform need dispatch this DXE driver.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4376 6f19259b-4bc3-4df7-8a09-765794883524
2007-12-10 03:47:56 +00:00
mdkinney 70279390ba Remove logic to repair image handles
Fix bug when new image handles are generated by Platform Driver Override or Bus Specific Driver Override


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4374 6f19259b-4bc3-4df7-8a09-765794883524
2007-12-10 00:43:22 +00:00
mdkinney f58f873c3b roll back change
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4373 6f19259b-4bc3-4df7-8a09-765794883524
2007-12-10 00:18:28 +00:00
lgao4 c4869732ec Cache FvImage at buffer with its required alignment.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4372 6f19259b-4bc3-4df7-8a09-765794883524
2007-12-07 10:25:56 +00:00
klu2 1547078bec Roll back wrong check in, peimain and dxe main still dependent on intelframeworkpkg yet.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4354 6f19259b-4bc3-4df7-8a09-765794883524
2007-12-04 03:52:59 +00:00
klu2 2678061975 Remove useful dependency package's relationship
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4353 6f19259b-4bc3-4df7-8a09-765794883524
2007-12-04 02:57:38 +00:00
mdkinney adc8840a25 Update ConnectController() to convert an ImageHandle retrieved from the Platform Driver Override Protocol or the Bus Specific Driver Override Protocol into a set of Driver Binding Handles. This is required if the ImageHandle produces more than one Driver Binding Handle or produces a Driver Binding Protocol on a handle other than the ImageHandle for the driver.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4346 6f19259b-4bc3-4df7-8a09-765794883524
2007-11-30 02:35:26 +00:00
mdkinney b74350e956 1) Improve the EFI Memory Map stability to improve ACPI S4 support
2) Update DXE IPL to always publish the MemoryTypeInformation HOB



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4327 6f19259b-4bc3-4df7-8a09-765794883524
2007-11-27 02:47:37 +00:00
qhuang8 8a7d75b062 Clean up: update "EFI" to "UEFI" if applicable.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4317 6f19259b-4bc3-4df7-8a09-765794883524
2007-11-22 06:00:39 +00:00
qwang12 ef8169977a Use MACRO EFI_FV_FILETYPE_ALL instead of a constant.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4303 6f19259b-4bc3-4df7-8a09-765794883524
2007-11-19 08:03:35 +00:00
vanjeff cfe9de5244 1. CoreOpenImageFile(): FilePath should be IN OUT.
2. Use offset address to build device path instead of absolute address.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4294 6f19259b-4bc3-4df7-8a09-765794883524
2007-11-09 07:26:24 +00:00
qhuang8 f942f10760 Merge EDK899: fixed bug to support EFI_HOB_TYPE_MEMORY_ALLOCATION to allocate resource in PEI
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4289 6f19259b-4bc3-4df7-8a09-765794883524
2007-11-08 03:52:35 +00:00
lgao4 e98cd821eb Print real entry point for IPF image.
Print DxeCore Entry point and image address.
Set FileHandle = NULL when not found FFS file in PeiService PeiFfsFindNextFile. 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4254 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-31 11:46:42 +00:00
yshang1 34ec75fc96 1) Change GUID of emuvariable module.
2) Support print 64bit's HobList.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4245 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-31 08:58:40 +00:00
qwang12 26fa3b4968 Update the return status to comply to PI spec.
According to PI SPEC (Volume3 2.4), GetNextFile() should be return "EFI_NOT_FOUND" instead of "EFI_INVAILD_PARAMETER" when doesn't find the file with related File Type.c

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4159 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-18 01:00:01 +00:00
eric_tian 6979fd9382 fixed the following problems:
1) DMA interrupt don't been cleaning up after one UDMA operation
2) Global variable mHobStart is not updated after invoking CoreInitializeGcdServices() func in the dxemain.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4107 6f19259b-4bc3-4df7-8a09-765794883524
2007-10-12 05:41:48 +00:00
lgao4 18fd8d651d 1. Add ExtractGuidedSectionLib library to replace customdecompress library.
2. Add PeiDxeExtractGuidedSectionLib library instance and one PCD PcdMaximumGuidedExtractHandler in MdePkg.
3. Update DxeIpl and DxeMain to consume new library.
4. Update BaseUefiTianoCustomDecompressLib to register TianoDecomress extractguidedsection handler.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3980 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-29 08:04:29 +00:00
lgao4 a0ae8996bc Update DxeCore to set efi memory type for the different image to be loaded.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3977 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-29 03:16:49 +00:00
lgao4 c58cf83da2 Remove PeCoffLoader library class and its instances.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3967 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-28 08:48:41 +00:00
lgao4 3d7b0992fc 1. Replace PeCoffLoader library by PeCoff lib for PeiCore, DxeIpl and DxeMain.
2. Add three PeCoff library instances for NT32 PeImage load.
3. Update PeCoffGetEntryPointLib to support TeImage.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3965 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-28 08:14:30 +00:00
klu2 b0d803fe3e Merge branch of PI tree to main trunk
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3918 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-24 11:38:43 +00:00
mdkinney 8565806618 1) Remove buffer overflow when the number of Driver Binding Protocols increases in the middle of ConnectController()
2) Remove possibility of getting a CR() macro ASSERT() when DisconnectController() is called during a recursive ConnectController()
3) Make sure the DeviceHandle field of the Loaded Image Protocol is always correct
4) Update Loaded Image Protocol logic to guarantee that the DeviceHandle and FilePath fields are correct the image is loaded from a buffer


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3853 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-14 21:35:03 +00:00
qwang12 0c2b5da80e Merge the PI enabling works from the branch
First round of PI enabling work:
1) PiPeiCis changes (CONST, EFI_PEI_FILE_HANDLE.. etc)
2) Make use of FirmwareVolume 2 protocol.
3) Verified for Nt32Pkg and real platform for S3.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3773 6f19259b-4bc3-4df7-8a09-765794883524
2007-09-04 06:12:48 +00:00
yshang1 623ad724e1 Add dependent packages in INF of modules.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3731 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-29 08:52:49 +00:00
xli24 c97da01907 Update for ICC build.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3701 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-24 02:47:35 +00:00
qwang12 bbc0f1bb24 Allow DXE dispatcher to ignore EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE type FFS file found in EFI_HOB_FIRMWARE_VOLUME2 HOB.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3694 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-23 06:26:50 +00:00
yshang1 702887db45 Update PciCfg2.c to follow strict ANSI C spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3687 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-22 08:42:13 +00:00
mdkinney eba54e17cc Update DXE Core to use gEfiCallerIdGuid instead of the gDxeServicesTableGuid for status codes
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3646 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-16 01:21:02 +00:00
klu2 2a7e6bb29d EFI_FILE_TAIL_ATTRIBUTE does not support in PI specification.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3606 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-10 07:02:47 +00:00
lgao4 88ce0209fc Correct parameter UINTN to UINT32. Fix UINTN conver to UINT32
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3577 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-08 15:21:50 +00:00
qhuang8 7a31af6a12 Fix the type-cast between UINT32 & UINTN
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3575 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-08 15:00:43 +00:00
lgao4 d8c79a815f Update CustomDecompress library to support algorithm guid and Update DxeIpl and DxeCore to support custom decompress guid section parse.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3573 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-08 10:17:57 +00:00
xli24 05339bd79c Update gHobList in DXE core when GCD relocates hob list.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3539 6f19259b-4bc3-4df7-8a09-765794883524
2007-08-03 05:39:46 +00:00
vanjeff ed7748fe4a remove some comments introduced by tools.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3387 6f19259b-4bc3-4df7-8a09-765794883524
2007-07-20 06:10:09 +00:00
vanjeff dd0687a4b1 remove some comments introduced by tools.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3383 6f19259b-4bc3-4df7-8a09-765794883524
2007-07-20 04:33:45 +00:00
yshang1 c21fc3e8ae Clean up the Isa related DXE in IntelFrameworkMoudlePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3359 6f19259b-4bc3-4df7-8a09-765794883524
2007-07-19 07:57:59 +00:00
klu2 9767823fc9 Should use gEfiFirmwareFileSystem2Guid but not gEfiFirmwareFileSystemGuid in DxeCore.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3096 6f19259b-4bc3-4df7-8a09-765794883524
2007-07-06 04:29:38 +00:00
yshang1 21c6d913aa Include "Guid/FirmwareFileSystem.h " provided by IntelFrameworkPkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3049 6f19259b-4bc3-4df7-8a09-765794883524
2007-07-04 11:16:37 +00:00
yshang1 28a0029718 Check in DxeCore for Nt32 platform. Currently, it does not follow PI/UEFI2.1.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3045 6f19259b-4bc3-4df7-8a09-765794883524
2007-07-04 10:51:54 +00:00