The error return is triggered by one of two conditions:
1. rrecp is NULL (calloc failed)
2. strdup(dname) returns NULL
Previously, the function just returned NULL. This patch adds a call to
free rrecp before returning NULL. Since the free() function will properly
do nothing when called with a NULL parameter, it is not necessary to
separate the two tests into separate if clauses.
Reported-by: Colin King <colin.king@canonical.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daryl McDaniel <edk2-lists@mc2research.org>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Replace the existing old-style function declarations for Field, cvtbase and spectHex in BsdSocketLib with real prototypes. This allows StdLib to build using the GCC48 toolchain.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bruce Cran <bruce.cran@gmail.com>
Reviewed-by: Daryl McDaniel <daryl.mcdaniel@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16467 6f19259b-4bc3-4df7-8a09-765794883524
Removed variables that had no effect on code behavior.
Fifo.c::FIFO_Dequeue: Replaced instances of "Self->ElementSize" with preexisting variable "SizeOfElement".
IIOutilities.c::IIO_GetInChar: Fixed variable of wrong, but compatible, type and made updating of housekeeping variables dependent upon successful completion of reading from the buffer.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
Reviewed by: Daryl McDaniel <daryl.mcdaniel@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16276 6f19259b-4bc3-4df7-8a09-765794883524
Fix casts of parameters to sprintf() so that they have the correct type.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Stefan Kaeser <stefankaeser@hotmail.com>
Reviewed-by: daryl.mcdaniel@intel.com
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16125 6f19259b-4bc3-4df7-8a09-765794883524
StdLib\
BsdSocketLib\
ns_print.c
Use "%lu" format instead of "%Lu". A capital 'L' specifies (long double) in print formats.
Add a cast from char to (unsigned int) to match its sprintf format.
res_debug.c
Use "%lu" format instead of "%Lu". A capital 'L' specifies (long double) in print formats.
EfiSocketLib\
Socket.c
Update copyright & correct formatting
Include\
sys\
EfiCdefs.h
Update copyright date
Change type of LONGN and ULONGN to INTN and UINTN, respectively.
errno.h
Update copyright date
Add enum member '__ESUCCESS = 0'
fcntl.h
Update copyright date
Improve comment for O_EXCL
stat.h
Update copyright date
Reorder the S_* flags
Put the S_* predicate macros in the same order as their flag definitions
Add a function header comment to the stat() function declaration.
errno.h
Update copyright date
Define new ESUCCESS error code
wchar.h
Update copyright date
Correct the description of the Nptr parameter to the wcstol, wcstoll, wcstoul, and wcstoull functions.
x86\float.h
Update copyright date
Define 'long double' limits for non-Microsoft compilers
LibC\
Containers\Queues\Fifo.c
Rewrite to make more robust and secure (zeros out old data)
StdLib\realpath.c
Update copyright date
Reformat descriptive comment for realpath()
Add terminating CRLF
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: daryl.mcdaniel@intel.com
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16096 6f19259b-4bc3-4df7-8a09-765794883524
* Fix errors detected by the GCC compiler (pointer conversions and format mismatches).
* Worked around a GCC flow analysis issue in base64.c where the compiler is convinced that there is a path through the code where "input" is used but not initialized.
* Added EFIAPI to the file system operation routines for sockets to match the API declaration.
Note for GCC, the meaning of "l" and "L" are different in printf and sscanf format strings. The lower case "l" indicates a 32-bit value where the capital "L" indicates a 64-bit value. The native (default) integer size may be represented by a size letter of "n".
Signed-off-by: lpleahy
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13023 6f19259b-4bc3-4df7-8a09-765794883524
* Fixed bug report (Duane Voth: Python sockets test application not working) by starting the receive operations when a connection is established!
* Increased performance by extending the idle loop into the network stack with the Poll call.
* Added support for TCPv6 (SOCK_STREAM) and UDPv6 (SOCK_DGRAM).
* Added support for getaddrinfo and getnameinfo calls.
* Moved application PCD values into AppPkg
Signed-off-by: lpleahy
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13002 6f19259b-4bc3-4df7-8a09-765794883524
Daryl McDaniel
Bruce Cran
Olivier Martin
Stefan Kaeser
daryl.mcdaniel
lpleahy
rsun3
darylm503