Commit Graph

14 Commits

Author SHA1 Message Date
qwang12 1c574ee4dc Add a type cast of UINT32 to insure that EBC compiler does not report warning of "Integer conversion resulted in a change of sign" when building with -Za option (accept only ANSI/ISO standard C code). 1 << 31 is consider to be a sign change by compiler.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5325 6f19259b-4bc3-4df7-8a09-765794883524
2008-06-04 10:03:44 +00:00
qwang12 36fe40c2ea 1) Add BufToHexString, HexStringToBuf and IsHexDigit to BaseLib.
2) Remove the duplicated functions implementation  from the modules that reference these APIs 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5283 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-23 05:30:08 +00:00
eric_tian 356e635c15 [Description]
Memory may leak because the handles in IScsiUpdateDeviceList is not freed if the "iSCSIDeviceList" already exists
[Impaction]
add Free() func to free memory properly.
[Reference Info]
The Handles in IScsiUpdateDeviceList is not freed if the "iSCSIDeviceList" already exists

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5211 6f19259b-4bc3-4df7-8a09-765794883524
2008-05-16 07:14:25 +00:00
eric_tian 12618416ec [Description]
change the old code style to comply with Doxgen format
[Impaction]
add comments for every function
[Reference Info]
add comments to achieve the highest standard of code quality matrix

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5079 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-17 08:28:51 +00:00
eric_tian 5c70cb3285 [Description]
solve the big file transfer issue using ISCSI
[Impaction]
change the control flow on IScsiExecuteScsiCommand  function
[Reference Info]
The original design incorrectly uses a timer (its span is usually 2 seconds) to ensure the timely execution of CMD PDU send by initiator. For example: When initiator delivers a CMD PDU(WRITE command) in which the ExpDataXferLength filed is larger than DataSegmentLength field, according to ISCSI protocol spec, the target will respond it with a R2T PDU which is followed by a sequential DATA-OUT PDUs. In this situation, the original code may loop to deal with the arrival packet until initiator receives a RESPONSE PDU or the timer is expired. This way may cause the bigger file is more likely to fail.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5044 6f19259b-4bc3-4df7-8a09-765794883524
2008-04-11 07:20:05 +00:00
jljusten b4df501105 edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDriver.c:
* Fix warning with gcc.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4943 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-21 17:45:46 +00:00
eric_tian f2a94e2558 [Description]
solve the x64 exception issue when unloading iSCSI driver
[Impaction]
add some handler for failure branch and prohibit the additional ISCSI INITIATOR NAME PROTOCOL from being installed. 
[Reference Info]
this bug is reported by DELL. it causes an exception in x64 on unloading iscsi driver.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4941 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-21 03:28:56 +00:00
eric_tian e92d66f280 [Description]
fix the wrote data corrupt bug about iscsi
[Impaction]
modify the IScsiGenerateDataOutPduSequence() function in MdeModulePkg.
[Reference Info]
when writing some data from local disk into remote iscsi disk, the data may be corrupt.The root cause is caused by the data out PDU's offset is not created correctly.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4843 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-13 08:35:18 +00:00
jljusten 9cb8724d68 edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiTcp4Io.h:
edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.h:
edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.h:
edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.h:
edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiIbft.h:
edk2/MdeModulePkg/Universal/Network/IScsiDxe/Md5.h:
edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDriver.h:
edk2/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.h:
edk2/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h:
  Fix filename case(sensitivity) issues.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4840 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 19:38:08 +00:00
jljusten 7c3eaa27b6 edk2/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c:
Resolve warning from gcc. ('Digit' variable may be uninitialized)


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4839 6f19259b-4bc3-4df7-8a09-765794883524
2008-03-11 19:33:19 +00:00
vanjeff e48e37fce2 Use Mde library and definition instead of some native definitions in NetLib, to simply network library.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4693 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-14 09:40:22 +00:00
qwang12 9226efe5eb 1) Cleanup HiiLib, IfrSupportLib.
2) Add ExtendedHiiLib and ExtendedIfrSupportLib which implement APIs that require the OPcode and Device Path which is specific to Intel's implementation.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4662 6f19259b-4bc3-4df7-8a09-765794883524
2008-02-02 13:15:44 +00:00
eric_tian 758cc0cf7e update
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4613 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-22 08:10:49 +00:00
eric_tian 7a444476b4 move iscsi driver into network directory, and change its name to comply with name convention.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4612 6f19259b-4bc3-4df7-8a09-765794883524
2008-01-22 08:07:35 +00:00