Commit Graph

8 Commits

Author SHA1 Message Date
Laszlo Ersek 83be6beea5 DuetPkg: SataControllerDxe: fix private array subscripting
Each one of the DisqualifiedModes, IdentifyData and IdentifyValid arrays
in the EFI_SATA_CONTROLLER_PRIVATE_DATA structure is a matrix, represented
as a flat array.

The code currently uses the incorrect formula

  Channel * Device

to index them. The right formula is

  [Channel][Device]

which can be implemented as

  Channel * NumDevicePerChannel + Device

Add a helper function that does this, and replace the incorrect
subscripts.

Cc: Alexander Graf <agraf@suse.de>
Cc: Reza Jelveh <reza.jelveh@tuhh.de>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Gabriel L. Somlo <somlo@cmu.edu>
Cc: Feng Tian <feng.tian@intel.com>
Reported-by: Feng Tian <feng.tian@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Feng Tian <feng.tian@intel.com>
Tested-by: Gabriel Somlo <somlo@cmu.edu>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18525 6f19259b-4bc3-4df7-8a09-765794883524
2015-09-22 11:18:13 +00:00
Laszlo Ersek d80e8c459a DuetPkg: SataControllerDxe: fix typo in "DisqulifiedModes"
Cc: Alexander Graf <agraf@suse.de>
Cc: Reza Jelveh <reza.jelveh@tuhh.de>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Gabriel L. Somlo <somlo@cmu.edu>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Tested-by: Gabriel Somlo <somlo@cmu.edu>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18524 6f19259b-4bc3-4df7-8a09-765794883524
2015-09-22 11:18:09 +00:00
erictian 86702b3fa9 DuetPkg/SataController: Fix possible memory leak at error handling of SataController driver
Signed-off-by: Feng Tian <feng.tian@intel.com>
Reviewed-by: Jie Lin <jie.lin@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13482 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-03 03:24:47 +00:00
erictian 80d6c273d4 According to PI errata 0000690, word "Ide Bus driver" has been replaced with "Driver entity".
Signed-off-by: erictian
Reviewed-by: lgao4

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12703 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-15 09:42:16 +00:00
lzeng14 271c79012d Fix ICC build error.
Signed-off-by: lzeng14

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11942 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-01 04:59:47 +00:00
lzeng14 976f617719 Fix ICC build error.
Signed-off-by: lzeng14

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11940 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-01 03:56:19 +00:00
lzeng14 61a02ac974 Fix ICC build error.
Signed-off-by: lzeng14

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11939 6f19259b-4bc3-4df7-8a09-765794883524
2011-07-01 03:47:26 +00:00
lzeng14 27f3015903 Add AHCI support for DUET.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11353 6f19259b-4bc3-4df7-8a09-765794883524
2011-03-08 05:42:37 +00:00